Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1050425imm; Wed, 23 May 2018 09:28:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpAt3Spnzuk1hbRmP2b1p9uftaQeDgwlNhkVIZREIA49RGBGlZ3K2MnQUCheRBaxoq7IGes X-Received: by 2002:a65:460f:: with SMTP id v15-v6mr2875459pgq.31.1527092917239; Wed, 23 May 2018 09:28:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527092917; cv=none; d=google.com; s=arc-20160816; b=BCJysm7OrlMCIVqIdPye5SOKha+MTMBXASSiE28ZlfQf0LnyGfTb7EITSxSd0Om026 5me6S7dpfiPiXfPRvo1YEPTYjM/9nalpdfNIxyNrOsa/VkdafZaqa0ybcAHzJ5SVtHKe 1Nj7weYTdESWXVZnvqQcnFbRFhbGbg1BE1Rx3o2YvRnz4wEMH9MSdlpxu1aYqU3Rwc8i 5E1SJLB2PcTaAsxIdf3C3F9yLj9ubU/e0fdupOKzP9pQD9ungAewOmrEVI6AJHZyc93U hiOLtzflgfJSQ6D327aV5F6G+Ni3z9daBQ5uf1L1TmObcGldLoUz8kG3WbU7XPCS/FPL KrRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=XjHLXx51z/qTdw7WgY8qjkcW/zyhsjjm1fmhx3S3f5w=; b=JjZbA0fxCLLyIAVPEsVRf0apUXOe05UShJdrBt7l1cxYVNSL4ZqMEUboV1+TIOuhX2 BXx/08IN0oRGt7mA5NKRFHed8KF+sRVb2j040u2spkvGVdZB/LLAv0J7bSzmFhPiiHxL 99TTZJtms3zEw8F3MRCDR86fAlmjj32DDNPmj2Pv0wIh3yOH/yzXBENMB/SAhnWEcljD klvt1qbv0AtZxV82rthvh8p7Bjb7nOAUSh+5YNaLpN4WavdmJpM6q3nckLSAxHF3Jno3 /O3KsP88mFa2Vrbbh8IfWfJvD6eAOxsGdKR/OwyuWmyNQ23ld/l6y1+5FwvRcB2m0QWI gxYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=KqpcDCaY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k2-v6si18657291pfg.75.2018.05.23.09.28.22; Wed, 23 May 2018 09:28:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=KqpcDCaY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932915AbeEWQ1i (ORCPT + 99 others); Wed, 23 May 2018 12:27:38 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:48514 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754627AbeEWQ1h (ORCPT ); Wed, 23 May 2018 12:27:37 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4NGQeAM194604; Wed, 23 May 2018 16:27:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=XjHLXx51z/qTdw7WgY8qjkcW/zyhsjjm1fmhx3S3f5w=; b=KqpcDCaY22/QdI5PfRbEpsqy5HUezze9gB4GWjgBca7Grvbp44qoayupBmmJp53vIGx3 Q0BByA5PIFbRc2ftb4djrAdtGgsKsgYMNSHjALSCjM0pF/swmLHjNi1e7ryEnUUUMpB0 DHAjRbP7ma4XyNdIQ03D4PtGc9lm2G3lXsklQTHtS6gT1jyNWuRd2qyEMxLY6zW1tHnD mhACe9cP5MRLHXNy/VJX1Y/ZS2s/MFG96iZsqKMkIeBJFUKvskZqiQuM/gekcxQ9djGo KJwTQ97t08bpJtGHF5GL/75/hwUsAzcTJz/xDensns8eRDf0L1cN0Eiupv/CY8C2ey4d Ng== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2j4nh7vud5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 May 2018 16:27:33 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4NGRWau005938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 May 2018 16:27:32 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4NGRWwN001558; Wed, 23 May 2018 16:27:32 GMT Received: from dhcp-burlington7-2nd-B-east-10-152-55-162.usdhcp.oraclecorp.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 23 May 2018 09:27:32 -0700 Subject: Re: [PATCH v5 1/2] xen/PVH: Set up GS segment for stack canary To: Jan Beulich Cc: brgerst@gmail.com, xen-devel , Juergen Gross , linux-kernel@vger.kernel.org References: <20180523143002.29252-1-boris.ostrovsky@oracle.com> <20180523143002.29252-2-boris.ostrovsky@oracle.com> <5B058BA002000078001C523F@prv1-mh.provo.novell.com> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <19ab48d1-333c-73fa-8586-c433b5bd7b90@oracle.com> Date: Wed, 23 May 2018 12:30:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <5B058BA002000078001C523F@prv1-mh.provo.novell.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8902 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=493 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805230162 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2018 11:41 AM, Jan Beulich wrote: >>>> On 23.05.18 at 16:30, wrote: >> @@ -98,6 +101,12 @@ ENTRY(pvh_start_xen) >> /* 64-bit entry point. */ >> .code64 >> 1: >> + /* Set base address in stack canary descriptor. */ >> + mov $MSR_GS_BASE,%ecx >> + mov $_pa(canary), %rax >> + xor %rdx, %rdx > Why rax and rdx instead of eax and edx? In the former case, the > relocation produced might confuse whatever entity processing it > (it'll have a sign-extended 32-bit quantity to deal with, which > wouldn't allow representing an address in the [2Gb, 4Gb) range). > In the latter case, while surely neither performance nor code size > matter much here, it's still a bad precedent (people copy-and-paste > code all the time): Zero-ing of registers should generally use the > 32-bit forms of the insn. Gas has actually gained an optimization > mode recently (upon request from Linus and the x86 maintainers) > to silently "repair" such inefficiencies. Sure, I can replace these two with 32-bit variants. If there are no other comments I won't re-send this again. -boris