Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1081609imm; Wed, 23 May 2018 09:59:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp5v/5z6Znuqvt7iCYAwjUpaml1FZCSZVjPpN12DURDPhpcIYiUm4444H56Y5rEpiVuG587 X-Received: by 2002:a17:902:1c7:: with SMTP id b65-v6mr3699415plb.298.1527094765256; Wed, 23 May 2018 09:59:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527094765; cv=none; d=google.com; s=arc-20160816; b=XKM6SF/POPboH0n7zRVdhjicwkimIcWUG9J0Klnz6ZBLgdUqHJdq43rCx64FByDzk0 7zhLV9/Js0HOxQ0Lpto7E69Boz2CSj3nnuE7gC6UDXA9q8migyDy4eppTslGL5yk7syk WaShJL530QGzPKgdMsI2yUEiSSXous6DZESLkyQROQkrt66x4ZMace3be9zdWSt1IMCZ kfQzhb0h9HzL5wfbFb2heXtnpLVfN+AR+vZgG59NMTOVFt8HdzsKK8KfJF4KcdppaNOW 5mqkrkSx/g/7DnbURkwPuGJs/Cn1xz365U4j9u2O3mCwibdEtbLX8PPV4iPSPqS/mVsG NrQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=LE6sopiq6raXQhNVmTPzQtAx5yL/DeNRWk7Wu1guGlo=; b=MrTMqBci3mD035lBaZFrq5wVEc0Jw5949Ih0G42qvz9cx3li/46vq05L8jDnRlANq6 LVQ0dqcivWYxcKleQ8U+jp0hU0d5vnhhKPDffrs4jpO5uvAtkDZXVkoiQVj4G9pqLaoi OyK8C+WvVSko/QY6+v+TzJePENB7xGBSloKukyrzh2/H90ay+yOjUM32o1lXWf/2mFIA IvnP66df0G7PCY3T0C/coDLWnjhXtFGAHIVlw4jNcmgAvh2FdQDNQKGv7MXQTi7CCzbh xCfxwFN3/lPBzI/8S+rgo1j10W8HjrIgnbMrPjJNErVHVDLBLjcocy/plxRuttxPOrFT fIAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3-v6si18521163plo.554.2018.05.23.09.59.10; Wed, 23 May 2018 09:59:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933781AbeEWQ6i (ORCPT + 99 others); Wed, 23 May 2018 12:58:38 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:36042 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933476AbeEWQ6g (ORCPT ); Wed, 23 May 2018 12:58:36 -0400 Received: by mail-yb0-f195.google.com with SMTP id o14-v6so7877733ybq.3; Wed, 23 May 2018 09:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LE6sopiq6raXQhNVmTPzQtAx5yL/DeNRWk7Wu1guGlo=; b=Hs1Sp8cHOtD6BoPVoMqK/rbCXmNBMDJXmKApdkU80kHhCagrFbnGfgWYJWIrIW2BDm GWj2whjxq6vZ61bgdRxqdgef7fJLDYrgvSBU++Z17DWbLdAOv+6pdJfC+xRR6Iez8sR6 4OxWYOIEd+zGujPdX5E95buDgLfoeW3J9QMBzei9oaClxhoGT28l7Lp85k+hY5qDZavY 1ZVKh8QeMyl1F6Oq1qBzPDgFFhsLLQxqlGFcUEWROoPojKCb5QXhDQLKEdzBSreTQIfA +VqAgdIwJHPoLqI+ej+/Q7Aamz8JG4bSVyokCO0PoBcKDgxZsVnAZhYsdguUh41NPTEX OlfA== X-Gm-Message-State: ALKqPwfwbqCcuhPBpbTBDs/ie2bMq6BNDRnJUQCGG6p8ks9OF5wO/a5x LPvrYzGaK+0uEjX57KVEPw== X-Received: by 2002:a25:aba9:: with SMTP id v38-v6mr2095425ybi.388.1527094716018; Wed, 23 May 2018 09:58:36 -0700 (PDT) Received: from localhost (24-223-123-72.static.usa-companies.net. [24.223.123.72]) by smtp.gmail.com with ESMTPSA id g145-v6sm7994615ywb.62.2018.05.23.09.58.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 09:58:35 -0700 (PDT) Date: Wed, 23 May 2018 11:58:34 -0500 From: Rob Herring To: Saravana Kannan Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mark Rutland , Rajendra Nayak , Amit Kucheria , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] PM / devfreq: Generic cpufreq governor Message-ID: <20180523165834.GA11016@rob-hp-laptop> References: <1526631889-5084-1-git-send-email-skannan@codeaurora.org> <1526631889-5084-3-git-send-email-skannan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526631889-5084-3-git-send-email-skannan@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 18, 2018 at 01:24:48AM -0700, Saravana Kannan wrote: > This devfreq governor is a generic implementation that can scale any > devfreq device based on the current CPU frequency of all ONLINE CPUs. It > allows for specifying CPU freq to devfreq mapping for specific devices. > When such a mapping is not present, it defaults to scaling the device > frequency in proportion to the CPU frequency. > > Change-Id: I7f786b9059435afe85b9ec8c504a4655731ee20e drop this. > Signed-off-by: Saravana Kannan > --- > .../bindings/devfreq/devfreq-cpufreq.txt | 53 ++ Please split bindings to separate patch. > drivers/devfreq/Kconfig | 8 + > drivers/devfreq/Makefile | 1 + > drivers/devfreq/governor_cpufreq.c | 628 +++++++++++++++++++++ > 4 files changed, 690 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/devfreq-cpufreq.txt > create mode 100644 drivers/devfreq/governor_cpufreq.c > > diff --git a/Documentation/devicetree/bindings/devfreq/devfreq-cpufreq.txt b/Documentation/devicetree/bindings/devfreq/devfreq-cpufreq.txt > new file mode 100644 > index 0000000..6537538 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/devfreq-cpufreq.txt > @@ -0,0 +1,53 @@ > +Devfreq CPUfreq governor > + > +devfreq-cpufreq is a parent device that contains one or more child devices. > +Each child device provides CPU frequency to device frequency mapping for a > +specific device. Examples of devices that could use this are: DDR, cache and > +CCI. > + > +Parent device name shall be "devfreq-cpufreq". I don't really understand any of this and how it relates to the other QCom cpufreq and devfreq bindings. Seems like this all needs some discussion amongst the PM folks first. Rob