Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1169033imm; Wed, 23 May 2018 11:22:47 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpLBGk1u+ic/3sVckczG3f+wIPL4G3p/AoI6e08sypKbUPm9pl518yrljy3iaE90+H48gyu X-Received: by 2002:a62:ac14:: with SMTP id v20-v6mr3970691pfe.101.1527099767579; Wed, 23 May 2018 11:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527099767; cv=none; d=google.com; s=arc-20160816; b=BmDAau6/h5NncT10Dknu+zL/khdV4Taf4OBtmsZtkzm+hkCW7NIx2sobwDCtLmll8y qUClfWoa25Zbux6y+Vfr6nfPbOhqhpKW0ROnb/T9sTZ1Wxbl9twqyUqlOBSG5l4Zi7gc 4gdmZePPsITF1RpLZh4W+mnAevySYur0m2jc9waTJe7Mb6XDf7ImulcLdN6snUyFAs/f 96bI+8YP16LwTyV4ImMtsATW0GW7xJnwRb5iBqXs81ftfrWPRgk69QHBL+2B7kyb++FX VhmGQQU/gdxMiGE4MPtHaoQsfe4D1t1GcrypliigKNh0pMNpnqK9Mp7x75egTS9mnEN/ zfWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:mime-version:date:references :in-reply-to:subject:to:from:arc-authentication-results; bh=21bKdxHOAcTnKqen4gzVHZTkIw+2aH4JNcyMg7yChjQ=; b=Zxcm7oOEeRvdmxqzMpAw5vDh7TpZapPC5FOgoLwNUduw65lvoJOS1DYgHMyoiTzn9U waZQ/nI+h3ZHTebWvjwzgNzzQtnLeBlvQbJso4Mke3mrhR4Qx/OmzyJY8PGH90gyRu0T BIbalVBuoKcCMb2MxxSY9FOnsOd5KCmicuGkaNYHGgsVeoKm2R7o3L1+H7QmFAyJBi+R 0MDLkKPGVUqcnRqHDFDOGOtAHuF08UY+FP84XOgCfdgcPn65taSfs88/ru8ov2myalFw N6jd/m157HCeTOx5oA+gA7AHBrJ5WoUPdAtWZELyGo7w16jhIvgpuPHl2X6ozNzCPNRQ ES1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j3-v6si18957980pld.300.2018.05.23.11.22.32; Wed, 23 May 2018 11:22:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbeEWSV7 (ORCPT + 99 others); Wed, 23 May 2018 14:21:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59710 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbeEWSV6 (ORCPT ); Wed, 23 May 2018 14:21:58 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4NIJHpl016455 for ; Wed, 23 May 2018 14:21:57 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j5cxt1gd9-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 23 May 2018 14:21:57 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 May 2018 19:21:55 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 May 2018 19:21:52 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4NILp934456724; Wed, 23 May 2018 18:21:51 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC43742042; Wed, 23 May 2018 19:12:32 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 34A684204B; Wed, 23 May 2018 19:12:28 +0100 (BST) Received: from vajain21.in.ibm.com (unknown [9.80.222.52]) by d06av24.portsmouth.uk.ibm.com (Postfix) with SMTP; Wed, 23 May 2018 19:12:27 +0100 (BST) Received: by vajain21.in.ibm.com (sSMTP sendmail emulation); Wed, 23 May 2018 23:51:45 +0530 From: Vaibhav Jain To: Michal Suchanek , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Balbir Singh , Nicholas Piggin , Breno Leitao , "Guilherme G. Piccoli" , Michal Suchanek , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] powerpc/xmon: Also setup debugger hooks when single-stepping In-Reply-To: <20180523180054.9937-1-msuchanek@suse.de> References: <20180523180054.9937-1-msuchanek@suse.de> Date: Wed, 23 May 2018 23:51:45 +0530 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18052318-0008-0000-0000-000004FA6395 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18052318-0009-0000-0000-00001E8E6845 Message-Id: <877enuxmfa.fsf@vajain21.in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-23_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805230178 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Suchanek writes: > When single-stepping kernel code from xmon without a debug hook enabled > the kernel crashes. This can happen when kernel starts with xmon on > crash disabled but xmon is entered using sysrq. > > Call force_enable_xmon when single-stepping in xmon to install the xmon > debug hooks. > > Fixes: e1368d0c9edb ("powerpc/xmon: Setup debugger hooks when first > break-point is set") > > Signed-off-by: Michal Suchanek > --- LGTM, Reviewed-by: Vaibhav Jain -- Vaibhav Jain Linux Technology Center, IBM India Pvt. Ltd.