Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1232524imm; Wed, 23 May 2018 12:29:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqSpLRn9GbruPytucqMppzEkuos4ZeTzdGxzf15MOtK2kk8m+58CcdABEqf9FtR2vodbuqQ X-Received: by 2002:a17:902:aa04:: with SMTP id be4-v6mr4214689plb.20.1527103778514; Wed, 23 May 2018 12:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527103778; cv=none; d=google.com; s=arc-20160816; b=yQEgUyn8UuEMXXQsdpMfcC1Y5JEIQtXjBBa7DBPCxMS9eKPf168R1yKfBqY/9zlBaZ zZ8/MOrxvsf/CyaVofF6BKyQJ39r2Ecfc7IGFC0xUIYV1I02dE1hKSco5jdC0ONW2/1q IdS5dji2QtyAdeI3Qz7fI0uML69UIR1sTVKe7ClY4x0fgXEXgDb87s6ryouQ6UlufIse cMXK0Zw9ubPtj1WHmNoH5YCkVa3JqU2fCSHXImWhV36mEtNPkJoSOz9AsqObxO6X0dAk XJxGIP8Mg/pl686yofHOmrcHEQlCS1B4/0wfjgeiaI4oE74bh8xHRKxy7VrdMHmvaJqy n19Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=DOFvpMmWj+HKvM5SUBRkkfdjZPpVoTYYDCRk5o0fMp4=; b=W76wNi8MN7Hu8ZN3ufap5OHhxnDpXADhteeakoqAHSV5VA91NrXDby9zimcAsasq3H IKffINn09d8uuDQd9oCcPZCYSDwPITCTdpwX4lVB/Ph4w1UO4Nvk0qBs00WsdG6Ia0kt 0aI2zyYYDKfoPOFMWXkR8QQFuYXaO2k0HOfF4QsgYb3aBeNIgyRCEVK1cSlXesW7ci8a R8oAs7FHrfoyBWbq94Q3vLaMtltKJzspP1A7DFTkWciXe87MZVgmO8XxwbprAKs/T/WF fXp4fhSAnuQwwebZkrXxmMPP509ZGvYze+QUWXd5CZxuo7Q2lSUjW6XdCcmLM3T371fo av2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mhhh1U7l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j14-v6si15095480pgc.627.2018.05.23.12.29.23; Wed, 23 May 2018 12:29:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mhhh1U7l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934728AbeEWT3U (ORCPT + 99 others); Wed, 23 May 2018 15:29:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:39552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934441AbeEWT3P (ORCPT ); Wed, 23 May 2018 15:29:15 -0400 Received: from mail-qt0-f174.google.com (mail-qt0-f174.google.com [209.85.216.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D39202087C; Wed, 23 May 2018 19:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527103755; bh=IGRRT8eQCaqzs11d7MVZFC7HLznr3MF+6ziicYeSd1g=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=mhhh1U7ljPbg1RaZyxdqJT+oDOs1+dfDUHXvgNup7cZ9tzHFN5Rgm4Kx3K5BV99SW /8PqPvAdHHk1xK9/fei5iipwfwb/q4bqg97gkr9MlreY0p8iZllS3bBGhNaBxQGYW4 3Wxuo8vNBT1tlL+kUVFYajv57wtcYp1S01N2IlYQ= Received: by mail-qt0-f174.google.com with SMTP id e8-v6so29633906qth.0; Wed, 23 May 2018 12:29:14 -0700 (PDT) X-Gm-Message-State: ALKqPwdjbCoDionOGrXTlRghdsJof/oh7BX+jjyq+dVd/Rdx4aYjXlGK rM0Z+Uo8jNfu6B5kTXXKne/+aI6wrAfizWbawQ== X-Received: by 2002:a0c:aa9a:: with SMTP id f26-v6mr3953355qvb.106.1527103754070; Wed, 23 May 2018 12:29:14 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a0c:9b02:0:0:0:0:0 with HTTP; Wed, 23 May 2018 12:28:53 -0700 (PDT) In-Reply-To: <4b83b699-59ad-b177-f360-3e76ba847892@linaro.org> References: <20180516165118.16551-1-srinivas.kandagatla@linaro.org> <20180516165118.16551-2-srinivas.kandagatla@linaro.org> <20180523164023.GA24671@rob-hp-laptop> <4b83b699-59ad-b177-f360-3e76ba847892@linaro.org> From: Rob Herring Date: Wed, 23 May 2018 14:28:53 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] slimbus: ngd: dt-bindings: Add slim ngd dt bindings To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Karthikeyan Ramasubramanian , sdharia@quicinc.com, girishm@quicinc.com, "linux-kernel@vger.kernel.org" , Mark Rutland , Banajit Goswami , devicetree@vger.kernel.org, Mark Brown , linux-arm-msm , Linux-ALSA Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 1:11 PM, Srinivas Kandagatla wrote: > > > On 23/05/18 17:40, Rob Herring wrote: >>> >>> + >>> +- qcom,ngd-id >>> + Usage: required >>> + Value type: >>> + Definition: ngd instance id in the controller >> >> Why do you need this? >> > Please ignore my comment from previous reply. > > There are more than one instances of ngd in this slim controller. > We need this to make sure we are programming the correct one. Doesn't the parent-child relationship of devices on the bus provide that? If you mean to provide consistent numbering to userspace, then that's not a DT problem (nor one that Linux plans to solve). > We also need this instance ID during powering it up using QMI. Wouldn't that be a QMI ID? Rob