Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1243947imm; Wed, 23 May 2018 12:41:42 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoH3KoSjjCS1tG3Y0lGcT3hrUXe8XQjVLazkkMA+TeW6heRo/JH0J6oDxFq9iIL53V4lUjn X-Received: by 2002:a17:902:8b82:: with SMTP id ay2-v6mr4136352plb.295.1527104502812; Wed, 23 May 2018 12:41:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527104502; cv=none; d=google.com; s=arc-20160816; b=NYxG0dX265T5cj10y0gZHjox+0YwtOBgBxq9Ou5dj9FrMTysBVKmO3oXNZk601vs3a nIFsei//FRojd0l6JI2Jl6ESp1yMpqgBGXYep+o5AUYw4jy9mocBBSrG+7NXiLdXcKbN KAAoTVE3u4yPqeLdVO6Zpq0FcTBXvdoWsuwpzumTrohessGDls29Xv/NxPm3lebWf7J3 x5+9xPMez2VJmO5aY+mQPT7nPv0khX5tqhuwPnrUATgY1t+o+Rb6I9sYfN8ctLKcmERt drwZWSqVxe8zijENbvB5D3qa5vo3SvV9s8MO/m2oWmjkFRzMBKRfrVZDzy2kUa1uKn3Q iXTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=0DpBRTYifU+UN/50ayKbeZ4e8FhJ3pR04I5HmFHxrxQ=; b=g7NPaynJJNv4bQpkqUdKIE/mnjjbIjSO7r2uIc3kWugC2ebY0bLL7+ZDUkhrWFITJn NGK0bFLNCYQvUag+3aunXbQGo/8KM5j/0GHREwugz86hh3itSNt5+H4O78pbyCCLm4dZ nc7hv6HbhL3lCyVjFgOJc6vPQJ9MTjcMAicWAY2mQEkFL2Ys6As7U6ypTG5utuv9P+6h zZVzJekZ3ofH7mdqsFENqnUedp38vB+Q0pYk7Ik8XFDO9FrpwVJd2Q7/RuHBz6MHUoTo 6V1a5eUM2lqkgoPaU+9TW76eQUWaAsLvZkytQLhzdcvOkWU5mCuTpTprFWyvfkTmd8qh ztxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=mD9v3E4u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16-v6si18757848plo.5.2018.05.23.12.41.27; Wed, 23 May 2018 12:41:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=mD9v3E4u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934427AbeEWTlY (ORCPT + 99 others); Wed, 23 May 2018 15:41:24 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33775 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934270AbeEWTlV (ORCPT ); Wed, 23 May 2018 15:41:21 -0400 Received: by mail-wr0-f193.google.com with SMTP id a15-v6so21291424wrm.0 for ; Wed, 23 May 2018 12:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0DpBRTYifU+UN/50ayKbeZ4e8FhJ3pR04I5HmFHxrxQ=; b=mD9v3E4uD0Hax/wsv7sgCaNNNP6o7Ix9+gGsWzoK49+jkKmNOTbLSGDwCv0oa1t3iL 4cVHu16uX0wSoyWYrpx9PaABoXAA6tqYfz0Edtj4EjG1fNsLTv8MnAQqnsOJ6XlNktpW bXEzGe3ZUa25yg8+g7T5MQyCsIJzLkh84mbOrb06sL9ZHcGDusj8UnuXH8marFA9czvl zXQAds29XrucWl4JAf7cOiPPPwnrylIzHOa1Rzdhmrh80w7avFjlpHPBCI5VnVLS4HmN fEhCYg5xE4bZJjywZOUgX5DDyJ9ZdBMMz9YpcPaZq1/jrzBF6RjtUvIb008as9+/Cb8x eLZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0DpBRTYifU+UN/50ayKbeZ4e8FhJ3pR04I5HmFHxrxQ=; b=nQPrmEngf3SZaqpt1xJmzYn/SvHSqI/NuLi6r0gHpF09fOS2QpXfLpU4U/TdN56wRB //JuEhdHcMNSv3Uwe8B+TxXShflwrAjeeHvtoGhD+7q5glugbKAm3MGGTVD17AZfuS0P ey4DzJD30NTWX+v8E073wVcIvFIKKts91w0eI6Uw73h6itn09WVggsP8L9amDBorPmPq 7boKeHre0SXVFf4w2Kx2kYCzUuXExDxGupzRIo9Y2Tx0tygaJvHqg28jFw66ehOsNlMN bLYuHpL29J/BvGNeeu311G1dTm0z7HplFWcyYkJJ1ksMnIImH7K9rGR2nlhkovZg99fn WKIQ== X-Gm-Message-State: ALKqPwfaiRdMdBUZff0ecSMN7m+sJub979F8sXl1HEAgFGatRi54zaQd zVy4K7rHvFbWlQRefCSvYMHuPw== X-Received: by 2002:adf:c4b6:: with SMTP id m51-v6mr3588609wrf.126.1527104479862; Wed, 23 May 2018 12:41:19 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id 16-v6sm40452096wrt.20.2018.05.23.12.41.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 12:41:19 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1fLZdL-00060K-CH; Wed, 23 May 2018 13:41:15 -0600 Date: Wed, 23 May 2018 13:41:15 -0600 From: Jason Gunthorpe To: Tadeusz Struk Cc: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] tpm: fix race condition in tpm_common_write() Message-ID: <20180523194115.GC8705@ziepe.ca> References: <152701036671.19968.17347263774570787595.stgit@tstruk-mobl1.jf.intel.com> <20180523132318.GE363@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 10:57:07AM -0700, Tadeusz Struk wrote: > On 05/23/2018 06:23 AM, Jarkko Sakkinen wrote: > > Ouch o_O Do you have a fixes tag for this one? > > > > This one is quite tricky. > The original bug was introduced by abce9ac292e13 (tpm: Propagate error from tpm_transmit to fix a timeout hang) > and the code back then was in drivers/char/tpm/tpm-interface.c file No, it has been wrong since before git history started, so just use Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") All the other commits you listed are just moving the bad code around to new files. Jason