Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1338103imm; Wed, 23 May 2018 14:27:45 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqy0g+HiRhTQWBCJbGEXVJLiXgyamnAA6nKX2xzY8Qysd7k/G0cVFp69I/FCjEY+ZhY72VE X-Received: by 2002:a17:902:2983:: with SMTP id h3-v6mr4553264plb.232.1527110865700; Wed, 23 May 2018 14:27:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527110865; cv=none; d=google.com; s=arc-20160816; b=q5lWsv2vFxBp/DzzFeSZZX9gu3tJLUMT6SY1Sne3JuT1J9BrYWlJtMm737OidczzFv GNhXMn4+qJgaaI4zbaan5/CsG3Yzt21t+By8/VTNIhDSsB7lrmwu6+gUqMam4ztddkRU XPjbo8OiuoQyaFOi1ubcn3uEPGhLS4Yg6e3gqmWi/FZWTaeJFuTfFmikdD33cY3FwcHM fR0rSmxy8DjIBkxx4En6FraocJ4O6ZjhkP9Q84vo+woqLhNN/6xDJAbuvGAojgvitE44 aJTz1rXwEuwBwWMPspHwe50fZ93pn7c6zMwrQhZqkZOurff8y4VL0RvwI7/j4NpyuDyK +Mag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=9p1FV0J7sMbmr4u9cGtJxFN1WA74CWs8/ArM3DQkNPM=; b=Kt+wwMxXd+ueLN3jmGmEPAvLoa/JjvfoopjolJopTF5eu5tTfs9txgZRWzfP6jz9RN ovO37vTEFuBalEqcCtRsd3Oejk3iif6op35GLeuEdtPpzsgi6Bahnnp1TGoKaSCA6tg9 AvAZdKTuaW9wqttvXUNLuPn1sNEPtwJ+O/pMMVMr7Mu5Rs6d5PZVHaWgRnGFKcPLGxNU CKn1KO3iEWigzT0ApItnum6CFLYSItHwyb0mLExGcsJogogeIaL0uFhV1MsI9PIhvh3n cyPxI7DquNWGcP4vinuDYhh9OhixLQA+RM07QjNKfYR2n6348iJhlWKOz0Uy8xuPkCXG Xztw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0puZjlds; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9-v6si15212415pgq.145.2018.05.23.14.27.30; Wed, 23 May 2018 14:27:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0puZjlds; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934317AbeEWV1T (ORCPT + 99 others); Wed, 23 May 2018 17:27:19 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:34986 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933195AbeEWV1P (ORCPT ); Wed, 23 May 2018 17:27:15 -0400 Received: by mail-io0-f195.google.com with SMTP id g1-v6so24578226iob.2 for ; Wed, 23 May 2018 14:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9p1FV0J7sMbmr4u9cGtJxFN1WA74CWs8/ArM3DQkNPM=; b=0puZjldsZWU8mYPidDXAddd7OCdZpUFrHMDgUoEOxhrI5bLGD/dFrLDzEgIh8saB5o yKjNClx0ghH1AUB+37ynJt7dKTx/mNXxWVL/yjmwMjkC10WvdSbBYWeekve4VtURQb8e 2yLZqF/Zby/OHX4gk3oLRj3OH8WhJXYQj0AFoUSbVfYzVCFxJc0oOKEBn6lOUKccNvzX Kx0VckGvkiXIlmGK5Ep88zP8UE9mJt0zPpS7I6hQBbTXu9oXT9fQt9E/owG50DqGX9ab J//3uv3iHxU2M4GCb295RVJVO3Lu4t2ta2HAuByjpmtCP+z+WYQRa1Zrk70ZZxHQZLEW HZdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9p1FV0J7sMbmr4u9cGtJxFN1WA74CWs8/ArM3DQkNPM=; b=hk77zYRES2HSGu2adl+wIDco0OKtFkVHQbM/okaH0a/JJ49ea7ut3h86drFIjEqyhH 5TTExCjltQ8iR+qEDBzFSarsLDYLMl//kKzJp9/Ju2IvPubECJHvkHUi1KYj2fe0iI8z OXx2z5iexk0G4Q/0J7Rh3U2OUtr6g7kwCcILf+l1M+9l8ExpKe6HiaSDOmSI04iwqM3J Psz6lq6mFxOg2zF4xOLlBDFrW83z9H5lCFPMoyS3nCgLZ+m/1Baun5HBiylvqsA7RwJY NgbXZFlA2xgQykza9LISsKGlx7z2BQikF4fTMXNyQ1MPuozLoPXK8iA9b+SuRgVIaLdI b+Ww== X-Gm-Message-State: ALKqPwdQOqO4ud6x4e447OHaNG82+KoIQ/jN17276k0zVHJGhcNr0L/z 4xqD48C46SEeqwiIXAuaw9KlTA== X-Received: by 2002:a6b:e50:: with SMTP id 77-v6mr4055920ioo.83.1527110835170; Wed, 23 May 2018 14:27:15 -0700 (PDT) Received: from [192.168.1.211] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id z2-v6sm1747021ita.16.2018.05.23.14.27.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 14:27:14 -0700 (PDT) Subject: Re: [PATCH] block drivers/block: Use octal not symbolic permissions To: Joe Perches , "Ed L. Cashin" , Philipp Reisner , Lars Ellenberg , Jiri Kosina , Josef Bacik , linux-block@vger.kernel.org, Ilya Dryomov , Sage Weil , Alex Elder , Joshua Morris , Philip Kelleher , "Michael S. Tsirkin" , Jason Wang , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky , Juergen Gross Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org References: <5e97a292c1ba38a6b5a0caa271d85dc3de1b2aa7.1527105857.git.joe@perches.com> From: Jens Axboe Message-ID: <6bf44255-145f-bf14-e254-860731ff9296@kernel.dk> Date: Wed, 23 May 2018 15:27:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <5e97a292c1ba38a6b5a0caa271d85dc3de1b2aa7.1527105857.git.joe@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/18 2:05 PM, Joe Perches wrote: > Convert the S_ symbolic permissions to their octal equivalents as > using octal and not symbolic permissions is preferred by many as more > readable. > > see: https://lkml.org/lkml/2016/8/2/1945 > > Done with automated conversion via: > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace > > Miscellanea: > > o Wrapped modified multi-line calls to a single line where appropriate > o Realign modified multi-line calls to open parenthesis Honestly, I see this as pretty needless churn. -- Jens Axboe