Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1732784imm; Wed, 23 May 2018 23:30:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqZzNsgCUEclqAfGF8V0gpN796Y2krodlnNpUw9e//hN1wXRrkgJgoD2nzvHQ4OiJ2yhMFl X-Received: by 2002:a65:4c4f:: with SMTP id l15-v6mr4782491pgr.61.1527143403691; Wed, 23 May 2018 23:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527143403; cv=none; d=google.com; s=arc-20160816; b=KSenWVRh8rf1uwV58sl5lFxOuoSRb0wu/zMKUrf4/NZIHYzdXx3x6E0SwPZtHbwRy5 PYoTawyR8j/lwauIZaM8moiwY0ry8L6ipVdlau9zM3P219oS6rZ/8hut6mBkru41kThH RDO9JeCxaewEvQXKctHl5Yg4flq/6TJmNvN1BhR09NxXoBrU+CUlMieHhwh1OykPrnZo 8DUcZU4hLu74nyojR64l9TobcnaaCfNvfl0VNEPhFw+atYoMzBZDRFgmdO2rxT8GUErx yCcwNpK2H918gD6rCY6+eF1Oxv3zHDBRvIPUC3cjBnVxX8ZyQ1N5l23dHvYsz03f3Jl7 nYFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature:dkim-filter :arc-authentication-results; bh=cgYUfjH8VK9stCFUGwqhqBs5wdipRTaDsYNmwQ2E98w=; b=RzI+Hm1C0ZaPc0i8S5hfEBabREoxoROcYMHKu//hLxoGavak0NYEioOP+7qh81ywC8 JyH9pAzbpck9dWQw4+EYkckXgsSUpCP9ONAeKcYF2Vg2F7yTAir0eyijYGcHBj5B9ZHU zaiYlaWJxw+4T6aX6Mmc57CrMkXg1FjHDtcrVFypzcoMP8/z0cpJfpRqLiLPnQccsAqc q6X5rjivoyvkKY0aS9x4lGpTEMl+xgHOcuRARgAbGuw1UurKizqk6HCtQ6ft4+pihBA1 Mqdwoo3x4hRBVH5BesmvHveKQed7IuXLQz33vICFqXPBDKWvBr8DXkd6x/nUCA+sK6ki r9Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wiesinger.com header.s=default header.b=SjCqjIYw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5-v6si21095403ply.598.2018.05.23.23.29.48; Wed, 23 May 2018 23:30:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@wiesinger.com header.s=default header.b=SjCqjIYw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755197AbeEXGWb (ORCPT + 99 others); Thu, 24 May 2018 02:22:31 -0400 Received: from vps01.wiesinger.com ([46.36.37.179]:38462 "EHLO vps01.wiesinger.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755032AbeEXGW3 (ORCPT ); Thu, 24 May 2018 02:22:29 -0400 Received: from wiesinger.com (wiesinger.com [84.113.44.87]) by vps01.wiesinger.com (Postfix) with ESMTPS id 7BA7E9F3E1; Thu, 24 May 2018 08:22:27 +0200 (CEST) Received: from [192.168.0.14] ([192.168.0.14]) (authenticated bits=0) by wiesinger.com (8.15.2/8.15.2) with ESMTPSA id w4O6MNv2011643 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 24 May 2018 08:22:24 +0200 DKIM-Filter: OpenDKIM Filter v2.11.0 wiesinger.com w4O6MNv2011643 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wiesinger.com; s=default; t=1527142945; bh=cgYUfjH8VK9stCFUGwqhqBs5wdipRTaDsYNmwQ2E98w=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=SjCqjIYwMQ5kNOJKCgCPRgbAwBsYDt4QNzoDW4h18I8rBhHOsYZpz5J47Y6t/wYer KXMlcNpuxbDjzMa/IWF7Oi13aBC/c5pF+BUFdPllx9Y9sB57RxKgJXV34jvAyCBCQJ jHL+QNvkSkEU/gOc9pfeymQ2AGwE5tEN3wpEkoghFXEBrMbv+BHkcw4IIriI8/bxvH AsiHI3v9xvZ0Mrh3zABOSAm/SPSCPFwEGHlL30MEcXmnAfcW3SL8ovdALRyNeHHe1W m7r1iup2oVyp2LYB1STrJxlo1FrW3WxKloZ/9xgAykZ+L9ewmt1v7Iw8u/GDNaFc90 RE/sHkKe4k4n103SXBZFSCtFvbNazzD1g67wapRvDxdbgq2U5XHeRj4yza5kD13DDl vJiVKwqtTpot++ZRyiU+NxtD5st3b+D69KA5PlR+QFt8nmG2LWV2S5L/tzW66i5suL /kaWFjC/32LCJOldS1FdY14NJDvcCF+R1acTW3wqjrKF2kjk63C6C9k4WXPZNElgKe OklfngBwtGth+W50Mywzyzs+dDAtDckda1D8ruGxu9yKzI9UD6J0fRnXVSPI8jOhWu c+8LBgnmGf2Kj7GLpSr66WdPjUA/5pWkyfqv/Goz5h/ZvqDiA9ZfuRPO1GKcnKbiOo o0n/gKNgyH5uQOJ2hdLYcquQ= Subject: Re: B53 DSA switch problem on Banana Pi-R1 on Fedora 26 From: Gerhard Wiesinger To: Florian Fainelli , Andrew Lunn Cc: linux-kernel@vger.kernel.org References: <3bdb712d-38bd-e2ca-63cf-8406a7b5689d@wiesinger.com> <20180522201632.GB4396@lunn.ch> <59d6b55f-d50a-063c-90a9-31a758e01383@gmail.com> <76c3f5ec-0ab2-c06d-98e8-277284bb1a8e@gmail.com> <779f2be3-3e74-e650-5240-efaf1003d77c@wiesinger.com> <4f7c5173-019d-ba0e-70b3-addf64a6a9fa@gmail.com> <53c9272a-0e1a-e8fb-a3e4-b4e23e77be10@gmail.com> Message-ID: <18ca17a1-4673-2ace-7142-d4aef6854bc4@wiesinger.com> Date: Thu, 24 May 2018 08:22:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.05.2018 07:29, Gerhard Wiesinger wrote: > After some analysis with Florian (thnx) we found out that the current > implementation is broken: > > https://patchwork.ozlabs.org/patch/836538/ > https://github.com/torvalds/linux/commit/c499696e7901bda18385ac723b7bd27c3a4af624#diff-a2b6f8d89e18de600e873ac3ac43fa1d > > > Florians comment: > > c499696e7901bda18385ac723b7bd27c3a4af624 ("net: dsa: b53: Stop using > dev->cpu_port incorrectly") since it would result in no longer setting > the CPU port as tagged for a specific VLAN. Easiest way for you right > now is to just revert it, but this needs some more thoughts for a proper > upstream change. I will think about it some more. Can confirm 4.14.18-200.fc26.armv7hl works, 4.15.x should be broken. # Kernel 4.14.x ok https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/dsa/b53?h=v4.14.43 # Kernel 4.15.x should be NOT ok https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/dsa/b53?h=v4.15.18 Ciao, Gerhard