Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1773948imm; Thu, 24 May 2018 00:15:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqUWizJEl8TznYAW7kzbYsIj2dsGiHu6SwvtiDJiDAKIcHMvuE2/MwcsyGKGC7+w1KryCSv X-Received: by 2002:a62:18d6:: with SMTP id 205-v6mr6056464pfy.242.1527146159922; Thu, 24 May 2018 00:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527146159; cv=none; d=google.com; s=arc-20160816; b=y91TvdFAKkYPSwIJJXB8dErifwrmk+KnWfgslelWFxsn1xcCxpRIoBPBEMHIilzis1 YbvugOcHn3PITp9oYCFNJwoSS3k2Sq5DDWy9zu113naUrtxC3vXc6XOlxYPx46rdqmv/ 2/LH5ZZ+TSE7iNiUJMGeeeOr5U0unodw0ymXk3mZEqXOirf6umnUQ/Vj2IRSijc5d1De yb3W1JKYcJDXmsUsTQBzSg1gMOMeJ5KfI/a/KSiE86Nz2wWEfUztSKycKKtGOIcX2xzr T3zpYIs1np0Y565HtquSOUeiYQqm88c7X8bl7ArR3tdn6OJ8XAKDuzZ4Qv5vc1ju/2Lh xk7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=SjSTbv+So7x3DXyfXhtNpJSn6T44tw12W3d/zJFiy+o=; b=IZXXzdqMLp9qnDxOMxEXMWVrUjz/Z1mW2MsoXnYRGgrgTjhmJ5KbcCtHJqnIEbBLzq qVSY0FKA9Lr1hSRtTDMpCN0nCH6HxL+bdXZXWUOMNoyRDddvluUhLKtHoXdWn6+It+9W 8u8La8RbF6ucPFKSkGHSg7g8rmWLIKHS+QNAm87viZxdGgv0L34+oklHdc0Qdiax04pX jrxb8c63KYDucoW++dZ4XFv8EroIAwv6VtX1uGX5YLe+RBAMCmaF9XDVvXbueCaG86rP rEfOhTAthCUeM1+HR/aOX3BbgHWfsNMPVZVFwHlYw3PU7KfMAAciGQoCnZdu8m3QQtai SzRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=DlXWkucI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9-v6si312450pgc.597.2018.05.24.00.15.45; Thu, 24 May 2018 00:15:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=DlXWkucI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935658AbeEXHOY (ORCPT + 99 others); Thu, 24 May 2018 03:14:24 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935346AbeEXHOX (ORCPT ); Thu, 24 May 2018 03:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SjSTbv+So7x3DXyfXhtNpJSn6T44tw12W3d/zJFiy+o=; b=DlXWkucIgc0oQDK5TMFguzIfU kBXMaeZFWUTy1Pzo/oWbq1EGI6veqa9Sdutw+6X8qtUs29hT03OnqruDT4ZsxgqKP9Yp5zZh2wnNt V0spV8/Lv0Bl92h8/1F4N6MwwWFPjntE4t+aC8PJ8bO/mMwgvq9xFLWqU66zYyt6wHRRZWHVuOVfa 6ZY8u1wo7dDbL16UQ63Bauv4eCwKzZ4XEhrjRoDIx12XBCHXlvUhfNQV8uleI4N1CevA6BiV4mH20 aciQ1vFGCByE2bI9U/IBGWJJmxLWkenaJNVxJN3os09AMOmZTPGkHwVZToJUb2jfzccJRusIZizlx e0AxAeoGg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fLkRz-0007tg-7w; Thu, 24 May 2018 07:14:15 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 971152029F86E; Thu, 24 May 2018 09:14:13 +0200 (CEST) Date: Thu, 24 May 2018 09:14:13 +0200 From: Peter Zijlstra To: Shaohua Li Cc: Matthew Wilcox , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, tglx@linutronix.de, Ingo Molnar , linux-mm@kvack.org, linux-raid@vger.kernel.org, Anna-Maria Gleixner Subject: Re: [PATCH 3/8] md: raid5: use refcount_t for reference counting instead atomic_t Message-ID: <20180524071413.GC12198@hirez.programming.kicks-ass.net> References: <20180509193645.830-1-bigeasy@linutronix.de> <20180509193645.830-4-bigeasy@linutronix.de> <20180523132119.GC19987@bombadil.infradead.org> <20180523174904.GY12198@hirez.programming.kicks-ass.net> <20180523192239.GA59657@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180523192239.GA59657@kernel.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 12:22:39PM -0700, Shaohua Li wrote: > I don't know what is changed in the refcount, such raid5 change has attempted > before and didn't work. 0 for the stripe count is a valid usage and we do > inc-from-zero in several places. Nothing much has changed with refcount; and the above does indeed still appear to be an issue. Thanks for confirming.