Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 24 May 2018 09:34:00 +0200
From:   Michael Grzeschik <mgr@pengutronix.de>
To:     Shuah Khan <shuah@kernel.org>
Cc:     linux-usb@vger.kernel.org, valentina.manea.m@gmail.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v3] usbip: dynamically allocate idev by nports found in
 sysfs
Message-ID: <20180524073400.qqwyy7zsihjjswse@pengutronix.de>
References: <c57fa7e9-d811-234b-fefc-1be998c5a8f1@kernel.org>
 <20180523092256.25922-1-m.grzeschik@pengutronix.de>
 <ac85c509-72ec-c126-afb7-521ddde87ec1@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qruuw5b52p5p2hdm"
Content-Disposition: inline
In-Reply-To: <ac85c509-72ec-c126-afb7-521ddde87ec1@kernel.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qruuw5b52p5p2hdm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 23, 2018 at 10:44:57AM -0600, Shuah Khan wrote:
> On 05/23/2018 03:22 AM, Michael Grzeschik wrote:
> > As the amount of available ports varies by the kernels build
> > configuration. To remove the limitation of the fixed 128 ports
> > we allocate the amount of idevs by using the number we get
> > from the kernel.
> >=20
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> > v1 -> v2: - reworked memory allocation into one calloc call
> >           - added error path on allocation failure
> > v2 -> v3: - moved check for available nports to beginning of function
> >=20
>=20
> Hmm. With this patch I see a segfault when I run usbip port command.
> I think this patch is incomplete and more changes are needed to the
> code that references the idev array.
>=20
> I can't take this patch.

I missed that get_nports depends on vhci_driver->hc_device which is
not initialized that early. I will rework it to get the hc_device
by parameter and send v4.

Thanks,
Michael

--=20
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--qruuw5b52p5p2hdm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEElXvEUs6VPX6mDPT8C+njFXoeLGQFAlsGat0ACgkQC+njFXoe
LGQf6A/9EHkG4NJ39OCL/sPOIOVcpMpUpNygcirXau208M5Oc8GgW8xtJuBjJ+f2
2NrCBPeSKPvw70C0IfxjuDYKCQgIMO+HI8MWLhnFuzk+1+n+mF1zspA8EkRUdqZx
S2b8myivm6E5G59ShSMj+skY9PtLOmoGOlE/QheuWqwD/GkTOFE449Zi+Z5rqOTz
wc4q/u2ntr6ZlgTmcsIinfxBvW8Gs/B7GHGA8wGBsm25/BSI5vzDVfICJNpPOig1
gkMw6OghL8VhX/O6Es4KpP8vlvxk5y2zYnP5YpQ4gT//bFXoT6i6b5SEWCu1a0TK
p9rUDlBzmgn0k06pr5jF80rUNFhZ/hakquWMoMKf88su3T9oy2/oIsuw3ZEIQxXP
TRZq61d3d59vimT0zAfzeNz0Wx2zRxz7/KyqwLN8dvVj8hWcQ1cBYZDVB5VP9Nvd
bSHUC5rYX27+xyJZ5jcBdZCV9M39yg0NF+L8FHX8LHOvUF72cx6kUYPxY7jzrzB4
IHxcwhaYsA/e/GtO0FqZsz74E5oTBnRs2Kju9maHJkm9J3aiFUxfWVMKybsYYek3
/GLSJFjeDdedaVksmV6bSvf/SIc0MMOMvQC4pw8jTz/5NVRnGqncYtkEo/lH+kBH
2Lxyhmih6K0vw/Jef7FJtyQEXumjt4oEPm/xme7dUQ8UCQRvZEI=
=NuhD
-----END PGP SIGNATURE-----

--qruuw5b52p5p2hdm--