Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1938534imm; Thu, 24 May 2018 03:15:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrlxgXhXvoHB4RFnr9znPDTSWJKfmT7dWCTcNKcFB6Ls83NP4HwNatd457no3HTSKDCUYAU X-Received: by 2002:a65:6182:: with SMTP id c2-v6mr5430221pgv.219.1527156934249; Thu, 24 May 2018 03:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527156934; cv=none; d=google.com; s=arc-20160816; b=smqiyNWOlY6rqm9x4HY9PYAnQdfkmLtae1IyCrk5Ma8STyTHjLP3qDVOAnJyJhnn1d XklLdTIkWDVRQCcsivwpELU4Yz5gFJEOPwD9lmaU/kSri/FMNo+C8eI3jalRveHB+bBh x+JDql/uogsaZ2jugo8z6577NUFgoLfXSnZoVwVj/0xFMChdkbVvpe/65JRTUascKJfw 2z2E0NFkz9E+WycwMcDaR7+BqNgYhdJrUF0vemGsIs+UoSJJhjxK7WiH0oIpt90lAWVW Pu2vGCgsv9eHlWyHCCamqpyMVe4+1TBFMX2SEO0rT/1m9whzV7eRYBFFheK4WkAvQRGI 2a2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=bBkvbykfY3oF1LJO2WE/X2vY6a9bKh8GCrYea6x5o4s=; b=Blq6xswxod0isf4WSoFzwIRaZV4QT21iMPTkqXHNBXaW20kexaGjTtaTYy8OMr4Xkc DnS4MB+4AoHbgBM2QgaQjyqvjYm5uDPYP53rZCjaiaiHewerpWYg4Y12Z4RHDB3d0MCR +hYCUvuKTYwGs/sXpSxrEE17ocEdZBHc+SqZCQ52nKSDfbTHIvLv/DjLVfRlo0JNJ3wN OlUVCocMQui317plAul0RXsaOQeyst6Oum9SXCYLoaVlb3A4GfGzHlXXBRtb9g5HOv3T utaKoktHLW+0icx3XtGrQPHQTbWwwgBcafqmq1GDuvsfNi2LFB763kQnKNM6/kOV49Sr FCMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GdOE3rE6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6-v6si2138739pln.250.2018.05.24.03.15.19; Thu, 24 May 2018 03:15:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GdOE3rE6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031849AbeEXKOR (ORCPT + 99 others); Thu, 24 May 2018 06:14:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:53988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031450AbeEXKEi (ORCPT ); Thu, 24 May 2018 06:04:38 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92F7D20891; Thu, 24 May 2018 10:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527156278; bh=jXcL+s1HhHf/+/D0bKKnflbg5MsFDHH/7PSo1iDBJ84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GdOE3rE6kTSb3LY7UV77ixrbUHckN/l2UMINbydOYUDjE0ek353t6mGutQa2gh4wz QS2vyBA3RF1zbmcRuFEbmcKlSODmhfjcBkci63zOFWPwtf6qkw5wQFnGG9fnHLZ3P2 cRyp4G2w3kEpGGiwUw3AQUMqj9EJYVqfRBEo5MjA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrzej Hajda , Tomasz Figa , Chanwoo Choi , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.16 127/161] clk: samsung: exynos7: Fix PLL rates Date: Thu, 24 May 2018 11:39:12 +0200 Message-Id: <20180524093033.528569490@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093018.331893860@linuxfoundation.org> References: <20180524093018.331893860@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrzej Hajda [ Upstream commit 7e4db0c2836e892766565965207eee051c8037b9 ] Rates declared in PLL rate tables should match exactly rates calculated from the PLL coefficients. If that is not the case, rate of the PLL's child clock might be set not as expected. For instance, if in the PLL rates table we have a 393216000 Hz entry and the real value as returned by the PLL's recalc_rate callback is 393216003, after setting PLL's clk rate to 393216000 clk_get_rate will return 393216003. If we now attempt to set rate of a PLL's child divider clock to 393216000/2 its rate will be 131072001, rather than 196608000. That is, the divider will be set to 3 instead of 2, because 393216003/2 is greater than 196608000. To fix this issue declared rates are changed to exactly match rates generated by the PLL, as calculated from the P, M, S, K coefficients. Signed-off-by: Andrzej Hajda Acked-by: Tomasz Figa Acked-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/clk/samsung/clk-exynos7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/clk/samsung/clk-exynos7.c +++ b/drivers/clk/samsung/clk-exynos7.c @@ -140,7 +140,7 @@ static const struct samsung_div_clock to }; static const struct samsung_pll_rate_table pll1460x_24mhz_tbl[] __initconst = { - PLL_36XX_RATE(491520000, 20, 1, 0, 31457), + PLL_36XX_RATE(491519897, 20, 1, 0, 31457), {}, };