Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1943263imm; Thu, 24 May 2018 03:20:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZofd/jtBypMYhGFW499YNK4H+mLTmLfAp84JLU7vp6Uny/VQmR+E1MR77Z3hkK+xGgWcAo6 X-Received: by 2002:a62:850f:: with SMTP id u15-v6mr6578687pfd.160.1527157238571; Thu, 24 May 2018 03:20:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527157238; cv=none; d=google.com; s=arc-20160816; b=ipEiqGuKljPVnhPgVsp6saQx99gz8yCo0p7e/lDB06MdZAzIPtXnzC33pa+mMybUwE 8Wd8u6xPbPTTVoLhigeFXqW74vYtSyo9uGk4QkWkUxpnW68mdu6ieuJymqBrKx08Or2M W1YQj9ZHpTJDhm/e1qJ/X92nRiMFx4zYjucg5EVSHn1nlmGa3xLftMq2TOJdU4OVCgPd S/1WHLtwkcoNsXZ0nfK1l5pQYaU/7f7TQ2g253R1DnKFVstO4AW2nvxK1LeGYSteJ3Ve VkDFjp0V4JV8mhnnI5fonOfxCZryMrOnFUjzs17t6L0J7/YlFR8NCh6vhOLAsAn1FtXl /a9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=84Zc8fVAwRI0HgLca5JRwLI+/ttVX9TDI1m+rUHT+5c=; b=uvaQ2rAzZjpbEDa7gcmcPme1LC4uYTPf8X/x3sXip6pCAegPI0xf68ko6VbdYdn202 zl0Un56d4HMf8V8rwe4VBbMC91cpona911DsuLj+Vhjjjr+XgKWYeIpBawYBklIhfgfr 3v872nGnYZuTdAwGA+oC9hJyMZVEOQkS1jroj2fzWlPn8P+53BHJN4jajCyFtEgsT5at A6bqBxaRYHeqGcYJIlCnOdnWoo+A0IoINHXj06Ag3jYWodQULSkLBrzLPVf6y6dnOH9v 3Qw+sGsps6mSpX5qG6+LPYKm+eAaxfIyugd3t3Jw/ziBqFDTCs+SVMRJ4NsmPI1ZYhMk GeFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Dkfo0aLg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q14-v6si12090938pgc.620.2018.05.24.03.20.24; Thu, 24 May 2018 03:20:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Dkfo0aLg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031276AbeEXKD2 (ORCPT + 99 others); Thu, 24 May 2018 06:03:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:52222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030922AbeEXKDY (ORCPT ); Thu, 24 May 2018 06:03:24 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2F2120870; Thu, 24 May 2018 10:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527156203; bh=bD+bLd74LFdjGK+EUjrjSSk7IhDqlxd2OOZsInQWhX4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dkfo0aLgefwgKEQc1qXxpyT28iGl8D8hT5KtliI3aRWTF+BfsndsTudmsruI4ZcPb LOnEaWojHsn0B/6o7ChKVqale8NshdJtURW5Ca2MFQ+R/VKcZazVi53rKuQ7yvS1ct 7hhTXCX8Pnagt5i8PClgh35hoPCTBDD+pgmjqhhk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen , Felipe Balbi , Sasha Levin Subject: [PATCH 4.16 068/161] usb: dwc3: Add SoftReset PHY synchonization delay Date: Thu, 24 May 2018 11:38:13 +0200 Message-Id: <20180524093026.645181858@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093018.331893860@linuxfoundation.org> References: <20180524093018.331893860@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thinh Nguyen [ Upstream commit fab3833338779e1e668bd58d1f76d601657304b8 ] >From DWC_usb31 programming guide section 1.3.2, once DWC3_DCTL_CSFTRST bit is cleared, we must wait at least 50ms before accessing the PHY domain (synchronization delay). Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/core.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -232,7 +232,7 @@ static int dwc3_core_soft_reset(struct d do { reg = dwc3_readl(dwc->regs, DWC3_DCTL); if (!(reg & DWC3_DCTL_CSFTRST)) - return 0; + goto done; udelay(1); } while (--retries); @@ -241,6 +241,17 @@ static int dwc3_core_soft_reset(struct d phy_exit(dwc->usb2_generic_phy); return -ETIMEDOUT; + +done: + /* + * For DWC_usb31 controller, once DWC3_DCTL_CSFTRST bit is cleared, + * we must wait at least 50ms before accessing the PHY domain + * (synchronization delay). DWC_usb31 programming guide section 1.3.2. + */ + if (dwc3_is_usb31(dwc)) + msleep(50); + + return 0; } /*