Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1946857imm; Thu, 24 May 2018 03:24:49 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpS2lO4fpFO9NdyX6PuWvTDBdvYhDYv2CFU2AHhsoTYkhMoR2eRscY7gpHD/e+2F1LyWA5B X-Received: by 2002:a17:902:8a81:: with SMTP id p1-v6mr6907689plo.33.1527157489263; Thu, 24 May 2018 03:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527157489; cv=none; d=google.com; s=arc-20160816; b=Jspny2iShr/U5lgLGyy+dZPhmLzC0tcjNJKMSrCL7sV576hv8ZNftc/kM2X7aIvS+q 357snRqK0YR3OZn3Hey9K2ASXM7lFntvkGdu41qF+B2HdUTDAVONLufolmcdnJKI/FSA cNxEzNigrRq/FCImfo7srhcCLdR9N+SS8A5F04f7YSlvmZ+4UmuNRgWUq0PHyoU6xzbC wzLcrpc5F5dvUY2dRzyueR4mWOC9gA/+woJiduQBlqGCxasTE0GFN6qocbzQBalMrvTN 1TltbvISwnp+I99CRd2Bd1NijXIGtTi4DBeo4E1u1XNIu/qbEjhOewMsxMc7oG8WYVIY NY7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=QE9vsZ9r5ojRLLGlgkfS0JRIGyKyigyWKzvcwqSPNMY=; b=kc4VOgBZp8broPvA4Cuqv8kssx+ecpJonu67RgMAcXVgARe81s/iGUnipFBvhS7lmS 0Y6ujeC2w+5lt4geBtZBGEbkFGi/153VnZjgN4IZJwSlWdenzYVOi8jdb+YOjdI1nCKn 2GZA42Jl70DEXx+klOl26XzJfY6MlHo50rRopejXIzi4gdz+cChitNrnB9HaWZ63fbC0 0ZYTsf5tL2dKGBUUH5cLA7AenVL4MG+DZLiN70sV2Wvd+lqXD4HcDcC391HlbHPQd3+S JKLfh5s9+cz7xhGJzdF6GmycOWuQpkHBRWQtZGJsMapwUPtWgb1xNsbJsezl8hon6S6W b9Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b6XoJEIB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si19759031pli.129.2018.05.24.03.24.34; Thu, 24 May 2018 03:24:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b6XoJEIB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031938AbeEXKX6 (ORCPT + 99 others); Thu, 24 May 2018 06:23:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:49284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031097AbeEXKCa (ORCPT ); Thu, 24 May 2018 06:02:30 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0328B20870; Thu, 24 May 2018 10:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527156149; bh=PpR7a+c1mupPm2ayfp3NIi7QbWejLRdnusoMiQbhuWQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b6XoJEIB9yd0mAti8ImCbOH/X0H4ZnIPJA/KztwWUdaEe786liKQQvSk782fxzd25 htML410lzA+bZn28kEKBgobw3YovtaKYuRDWUc2j7uF6S6iZLl4tEicUkRN9rC2hos 7aSvhi9XRF9nG6ldUxQ1f06fr2FxoQb2jf7rbf7c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brad Love , Michael Ira Krufky , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.16 081/161] media: em28xx: USB bulk packet size fix Date: Thu, 24 May 2018 11:38:26 +0200 Message-Id: <20180524093028.261972329@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093018.331893860@linuxfoundation.org> References: <20180524093018.331893860@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brad Love [ Upstream commit c7c7e8d7803406daa21e96d00c357de8b77b6764 ] Hauppauge em28xx bulk devices exhibit continuity errors and corrupted packets, when run in VMWare virtual machines. Unknown if other manufacturers bulk models exhibit the same issue. KVM/Qemu is unaffected. According to documentation the maximum packet multiplier for em28xx in bulk transfer mode is 256 * 188 bytes. This changes the size of bulk transfers to maximum supported value and have a bonus beneficial alignment. Before: After: This sets up USB to expect just as many bytes as the em28xx is set to emit. Successful usage under load afterwards natively and in both VMWare and KVM/Qemu virtual machines. Signed-off-by: Brad Love Reviewed-by: Michael Ira Krufky Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/em28xx/em28xx.h +++ b/drivers/media/usb/em28xx/em28xx.h @@ -191,7 +191,7 @@ USB 2.0 spec says bulk packet size is always 512 bytes */ #define EM28XX_BULK_PACKET_MULTIPLIER 384 -#define EM28XX_DVB_BULK_PACKET_MULTIPLIER 384 +#define EM28XX_DVB_BULK_PACKET_MULTIPLIER 94 #define EM28XX_INTERLACED_DEFAULT 1