Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1964048imm; Thu, 24 May 2018 03:41:33 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqDGWC5crgLE7qfMtFrgpoYuPI7ff0TBinwNxzgMtlBnYLlkvkCPvW3zCuYKjBBJd07rw0G X-Received: by 2002:a63:8c4f:: with SMTP id q15-v6mr4536414pgn.236.1527158493377; Thu, 24 May 2018 03:41:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527158493; cv=none; d=google.com; s=arc-20160816; b=fdzMRXeeHXJ0WVRx7mtoQxFzzpABaj/+bswfYbugXExKX7h4Xd1PMutbMGw3YP1LlM +GehNYsm9eYCLOPCnKiCHrYqfvo5hLGqvH8RWKeGpgggiLS2ss6V1Izi3I8HTfvs87mG KlgIG4rujcjfmAoz1uyr5mOUUf+9HrwoMWrZX+eUUm8uiv9NTxCG0FsVezZLaOgIBr3r /1R7zJBYbQL15iW/CJYQGqhBtJFQd7gH1G6xwTVsGT/T1+usg2Ubg+S63Dp+plHhu0mE fH8Z79ZyGvzOUk564/j+Ef/klQIVJKow8QqE9jir0eY+qGCuYd9o5V/8JAz203hUyEws Qn6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=/m88lrf39K62ASw0l7EEdNuX2NqTzZKdx4i13k0ayT8=; b=y+8ZErdaDJ06JMuBtZGpHtuMLplSibetTDmWmx02TECN9gRNKXPjEFgrCThbOaBHWy 0T112yUQ702A3cV6THU4r8blfc29Cd9ISW3iOr00iohA4ssDDvaDn0p6engADPyJ1x9E y7/vRtf/y0/0af+NfQJr0Xr0ydP17Hwd7HHN5AqUx431YJ7OOfu4iT8vKuwR73RRG4ne vvtgdER8dxX9zvq2atzMc98UfB6XczZPQLCwgWuEjAyAK3iGh62Mmx1Qf6wftJrepOrN x7AmPGBgY9p3ioMc07SXU7Spc5xJrhY0qEuZGDcxeH/+DVHeX5gicYRW2qntdudTVFz1 uhqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VCiQBXwX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14-v6si20998697plr.131.2018.05.24.03.41.18; Thu, 24 May 2018 03:41:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VCiQBXwX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030722AbeEXJ7J (ORCPT + 99 others); Thu, 24 May 2018 05:59:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:39544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030388AbeEXJ7B (ORCPT ); Thu, 24 May 2018 05:59:01 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38CC020893; Thu, 24 May 2018 09:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527155940; bh=54LsSTzbnP0g16cswNSBsJqaP6rcb1MPYY8VOiWP+Bk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VCiQBXwXTe1Lz1CGpzcxqdVdAByETAbOW24GQbCAiu5snfNzAxvi9x+krwSlRlcs3 F1gUOdpRCfguApsoko7d8DaVoxpkRFY+BmuSzBtMDWQr74FqwDJfUbFNJUD/w5BQTi 9A3Ui9QuZLVbBvs0a+ysj7wHSlQxWL5mClR1QXO8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bryan ODonoghue , Shawn Guo , Alexandre Belloni , Sasha Levin Subject: [PATCH 4.14 159/165] rtc: snvs: Fix usage of snvs_rtc_enable Date: Thu, 24 May 2018 11:39:25 +0200 Message-Id: <20180524093628.518858670@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093621.979359379@linuxfoundation.org> References: <20180524093621.979359379@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bryan O'Donoghue [ Upstream commit 1485991c024603b2fb4ae77beb7a0d741128a48e ] commit 179a502f8c46 ("rtc: snvs: add Freescale rtc-snvs driver") introduces the SNVS RTC driver with a function snvs_rtc_enable(). snvs_rtc_enable() can return an error on the enable path however this driver does not currently trap that failure on the probe() path and consequently if enabling the RTC fails we encounter a later error spinning forever in rtc_write_sync_lp(). [ 36.093481] [] (__irq_svc) from [] (_raw_spin_unlock_irqrestore+0x34/0x44) [ 36.102122] [] (_raw_spin_unlock_irqrestore) from [] (regmap_read+0x4c/0x5c) [ 36.110938] [] (regmap_read) from [] (rtc_write_sync_lp+0x6c/0x98) [ 36.118881] [] (rtc_write_sync_lp) from [] (snvs_rtc_alarm_irq_enable+0x40/0x4c) [ 36.128041] [] (snvs_rtc_alarm_irq_enable) from [] (rtc_timer_do_work+0xd8/0x1a8) [ 36.137291] [] (rtc_timer_do_work) from [] (process_one_work+0x28c/0x76c) [ 36.145840] [] (process_one_work) from [] (worker_thread+0x34/0x58c) [ 36.153961] [] (worker_thread) from [] (kthread+0x138/0x150) [ 36.161388] [] (kthread) from [] (ret_from_fork+0x14/0x20) [ 36.168635] rcu_sched kthread starved for 2602 jiffies! g496 c495 f0x2 RCU_GP_WAIT_FQS(3) ->state=0x0 ->cpu=0 [ 36.178564] rcu_sched R running task 0 8 2 0x00000000 [ 36.185664] [] (__schedule) from [] (schedule+0x3c/0xa0) [ 36.192739] [] (schedule) from [] (schedule_timeout+0x78/0x4e0) [ 36.200422] [] (schedule_timeout) from [] (rcu_gp_kthread+0x648/0x1864) [ 36.208800] [] (rcu_gp_kthread) from [] (kthread+0x138/0x150) [ 36.216309] [] (kthread) from [] (ret_from_fork+0x14/0x20) This patch fixes by parsing the result of rtc_write_sync_lp() and propagating both in the probe and elsewhere. If the RTC doesn't start we don't proceed loading the driver and don't get into this loop mess later on. Fixes: 179a502f8c46 ("rtc: snvs: add Freescale rtc-snvs driver") Signed-off-by: Bryan O'Donoghue Acked-by: Shawn Guo Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/rtc/rtc-snvs.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) --- a/drivers/rtc/rtc-snvs.c +++ b/drivers/rtc/rtc-snvs.c @@ -132,20 +132,23 @@ static int snvs_rtc_set_time(struct devi { struct snvs_rtc_data *data = dev_get_drvdata(dev); unsigned long time; + int ret; rtc_tm_to_time(tm, &time); /* Disable RTC first */ - snvs_rtc_enable(data, false); + ret = snvs_rtc_enable(data, false); + if (ret) + return ret; /* Write 32-bit time to 47-bit timer, leaving 15 LSBs blank */ regmap_write(data->regmap, data->offset + SNVS_LPSRTCLR, time << CNTR_TO_SECS_SH); regmap_write(data->regmap, data->offset + SNVS_LPSRTCMR, time >> (32 - CNTR_TO_SECS_SH)); /* Enable RTC again */ - snvs_rtc_enable(data, true); + ret = snvs_rtc_enable(data, true); - return 0; + return ret; } static int snvs_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) @@ -288,7 +291,11 @@ static int snvs_rtc_probe(struct platfor regmap_write(data->regmap, data->offset + SNVS_LPSR, 0xffffffff); /* Enable RTC */ - snvs_rtc_enable(data, true); + ret = snvs_rtc_enable(data, true); + if (ret) { + dev_err(&pdev->dev, "failed to enable rtc %d\n", ret); + goto error_rtc_device_register; + } device_init_wakeup(&pdev->dev, true);