Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1976314imm; Thu, 24 May 2018 03:54:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqv+q9mXi1u0DB5KnD/G3uByURK+ciDV5Ue1SxxYL7+JfpVmtJOA3GK4GGM3SJuq5PEo5EE X-Received: by 2002:a62:b509:: with SMTP id y9-v6mr6745218pfe.121.1527159278345; Thu, 24 May 2018 03:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527159278; cv=none; d=google.com; s=arc-20160816; b=bdXEkXtjSBAK46onrx9KYaT1LMlAhwvGQXO3qPmp3PC9X/wJpi5x+41b3CRyFzUu4M DsnGD0FQ0HyFJXtRhMpU3oI5oDPqgzWcFQU7oISWVU0IUOf5ZpyjPGntQH9FtbB6i6nv 2dZ7F/1rWetqzmF9RSvLHiCLjQdNmkRF+uY5Zw9vtYHA1UyP3JBRq0A7yV7rSw/KhIlv CpRJzTYBoTTSusgfI+/1A6Ml37XSURQmjRYVjJ/njd1fi2DQUQud/0in+zDLYXvFeORG qI8m2Suwrv3EMeUZBUIpVL7/YNFnA3DcTvT+oeo8mUdawa5RMSzQTjncpvvGdVpIVTFE 5vIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=qeDW8EWkSQDVK7Cyh4/J9At2sWJ4Y0O0gF1gPOin2IY=; b=SATzdDszlFiUsdeSI1IJUHAfVB9WHrLmLG64UIi4bF6Bd9bX72pRWSypMlU/fH+9i/ w63kCeMyR/KkLmenH2eJJg1kS/q0ntg5pruAiOXwRp3SlwyAnbzcK3/zZJ6MkykY/nnW 9wwhFWb+K959eZOY7qr9/dzcQqx9Sz0gr7RgjdQWRiy3AnvetVft4sUxTPiH1TGzIXPH iGXN7tsBhaFUtTv+qZN4k+FceSQSWn8UyRXV2cMWkNKPhIL0ZlHYx+U9YV2eidcCB8u7 JCx4qL18+dXLRd3NKyrQzxX9JJ+oL2BjJI1rGPFVi02+11iarxeS7l6pohGJJosDHiLM GdQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eSLEOGdP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z10-v6si16175698pgp.419.2018.05.24.03.54.23; Thu, 24 May 2018 03:54:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eSLEOGdP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032663AbeEXKxf (ORCPT + 99 others); Thu, 24 May 2018 06:53:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:36970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030402AbeEXJ5I (ORCPT ); Thu, 24 May 2018 05:57:08 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37A44208B1; Thu, 24 May 2018 09:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527155827; bh=s+HxOwBMDqdeeeNAUHqIPkDHbXsVkCvLi5b8txaiOuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eSLEOGdPvsktOal+Iq+xlIx1uTQOwLOH1Opu21HC2HXKzKDOVtk7XS6x7ZUDGEwqC s4tpxWpbuhiesKjzhJ4LuceMtvcjtMTxjab3hPrG3zo98MD+jsCjWDvZXbHx4XFfe1 MZ9AZwiDOKeZ0G56zagubbqFvHB4WtV8QQvGUST0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrzej Hajda , Tomasz Figa , Chanwoo Choi , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.14 132/165] clk: samsung: exynos7: Fix PLL rates Date: Thu, 24 May 2018 11:38:58 +0200 Message-Id: <20180524093627.340243027@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093621.979359379@linuxfoundation.org> References: <20180524093621.979359379@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrzej Hajda [ Upstream commit 7e4db0c2836e892766565965207eee051c8037b9 ] Rates declared in PLL rate tables should match exactly rates calculated from the PLL coefficients. If that is not the case, rate of the PLL's child clock might be set not as expected. For instance, if in the PLL rates table we have a 393216000 Hz entry and the real value as returned by the PLL's recalc_rate callback is 393216003, after setting PLL's clk rate to 393216000 clk_get_rate will return 393216003. If we now attempt to set rate of a PLL's child divider clock to 393216000/2 its rate will be 131072001, rather than 196608000. That is, the divider will be set to 3 instead of 2, because 393216003/2 is greater than 196608000. To fix this issue declared rates are changed to exactly match rates generated by the PLL, as calculated from the P, M, S, K coefficients. Signed-off-by: Andrzej Hajda Acked-by: Tomasz Figa Acked-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/clk/samsung/clk-exynos7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/clk/samsung/clk-exynos7.c +++ b/drivers/clk/samsung/clk-exynos7.c @@ -140,7 +140,7 @@ static const struct samsung_div_clock to }; static const struct samsung_pll_rate_table pll1460x_24mhz_tbl[] __initconst = { - PLL_36XX_RATE(491520000, 20, 1, 0, 31457), + PLL_36XX_RATE(491519897, 20, 1, 0, 31457), {}, };