Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1979840imm; Thu, 24 May 2018 03:59:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp73uyBYt3IeOUeA4GjuporBxH0x2WxBRyAvXwRATaX35+Xmj2KlbFxvunsqI9lpluHUZGm X-Received: by 2002:a63:8f43:: with SMTP id r3-v6mr5449573pgn.10.1527159540086; Thu, 24 May 2018 03:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527159540; cv=none; d=google.com; s=arc-20160816; b=OqgMwEa46Y4Bmp4n25pIpXJR4Kp+JfqA8vXz83jeiwlnRUhClybl/F5sihOUnUzmEo VSuiLJGjhJ4TTQwbOKHKtrwfhERQzWrHQU3WKoqbF98NHFF/LyIb1vhRFEfyrvsWm2gz 6C6+WNJEIEHg5QHxXPunDcLPln7dUq+sHrn3MuQrEgTxq/NFHDlvmkmwOXwOxC4x1lbH qcENh9e5W2SMFFiGtQYb1Nl8WsDBrn0bPzDVK97U/YaORbaNs76X7Ya0hL6GmCSTNXDR xWpPAB7HGdwjKcwo+Q4yeOJw8D19VXmEIN73UWD7UfxsQgDF+FcDvD40kiC9Ujh+SQki BNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=vWZpe/psZw62xljLviW4k2Qk1HEBlTIyYGjWanMVcrc=; b=dgdPey3P3HrUhIS4iupo9WSfKP6Gg3I6Zf+N/DhjzvIUilHtEAVdZ4GO557J9+uCdI zFEpqA6oO1RbwJ9xMzepMZdyH5ojrzFg0FjDP4vhka1UhDqLHx/76FvM0++u6dvBVirr cS7EAlgMW7fa7aSS1cTGAxF69U6TAKcvs5GsnE4Zsa9vicyJWDmEgltaJmYe/6/slXNn QRYlJU0S5ZKTuMq+6I033w4VvO9U7Zywpo3mu3bO5kPwq42vZki/IOOnBK78NbU2mNhT oRZWrkRN33omBeJL5S9QIEksMnhoXtvr2DIRqH30j0Pe4S9grukaKO5g1Z4TDHV5TPIJ RPnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HCqFOJUz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s88-v6si20575324pfa.339.2018.05.24.03.58.45; Thu, 24 May 2018 03:59:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HCqFOJUz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032721AbeEXK4w (ORCPT + 99 others); Thu, 24 May 2018 06:56:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967722AbeEXJ4Y (ORCPT ); Thu, 24 May 2018 05:56:24 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCA1A20893; Thu, 24 May 2018 09:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527155784; bh=r2x74T/7xNFUBW72K5Hn5ejImPQgOwE4/XKCOS1cN4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HCqFOJUzUdzRd14RZXPqktG1RiUXCzQpQ68IZ4QgJDAy45jmdC0/cJY8Ba09w2ROn EqUpMmwUEx6AhHf/NY3uYBtwFEZ9RJi9KtvWh8AyjLrZ3vJRRz55I7YqcDwyM9EqoJ jx5PO+7Q5H3Tq8URT731Y4CATgaO++qNJ/u22fm0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brad Love , Michael Ira Krufky , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 082/165] media: em28xx: USB bulk packet size fix Date: Thu, 24 May 2018 11:38:08 +0200 Message-Id: <20180524093625.335962903@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093621.979359379@linuxfoundation.org> References: <20180524093621.979359379@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brad Love [ Upstream commit c7c7e8d7803406daa21e96d00c357de8b77b6764 ] Hauppauge em28xx bulk devices exhibit continuity errors and corrupted packets, when run in VMWare virtual machines. Unknown if other manufacturers bulk models exhibit the same issue. KVM/Qemu is unaffected. According to documentation the maximum packet multiplier for em28xx in bulk transfer mode is 256 * 188 bytes. This changes the size of bulk transfers to maximum supported value and have a bonus beneficial alignment. Before: After: This sets up USB to expect just as many bytes as the em28xx is set to emit. Successful usage under load afterwards natively and in both VMWare and KVM/Qemu virtual machines. Signed-off-by: Brad Love Reviewed-by: Michael Ira Krufky Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/em28xx/em28xx.h +++ b/drivers/media/usb/em28xx/em28xx.h @@ -191,7 +191,7 @@ USB 2.0 spec says bulk packet size is always 512 bytes */ #define EM28XX_BULK_PACKET_MULTIPLIER 384 -#define EM28XX_DVB_BULK_PACKET_MULTIPLIER 384 +#define EM28XX_DVB_BULK_PACKET_MULTIPLIER 94 #define EM28XX_INTERLACED_DEFAULT 1