Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2008175imm; Thu, 24 May 2018 04:26:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrOB1V66qZGFmcSkUsXNERFtmVLLkdk8kxo6xMSRcnsofa8x8YOjdeu/RmznvBY96Tf9LnZ X-Received: by 2002:a17:902:1007:: with SMTP id b7-v6mr6816235pla.88.1527161177220; Thu, 24 May 2018 04:26:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527161177; cv=none; d=google.com; s=arc-20160816; b=AC2CTWhdIMiDznik2ApYimS0nuP/J3mEMJB4gxisPsGa9BXVrgqXX2yDwUTnZqmJ68 lyV+Flcpp0JClJ+9bXAiK/M4/Zq/bOpFpqGXzjnC/umUZP6IIXECgumClvSNTj/NPMmx wpNcEGTiBD3z8PjVWO+25Qa7vNTvo1b86iuYi/YU4fFzYda0jUK7gAtGtp91bZVgAcwx IkNoLImZkVwW4aVjzUAZjtOAcxAhNfVkTNz4X88nK51zrTQ8k/XhiH1X2XlWuW3oHkhx od2aTBwNxrf/XAPtRPwEvYNsbzRNEb/Z6qX/DX1WkO8acInej9kQZ1MouIxp2eGvxYaj oQOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=RgkwoWkG0peZRQdKusYC9/Npey3Lz04rTHJOR1XPVJs=; b=dugUWohyV7hNuGMQkH4HS5oOvn36V3Wqb99L05wlRqln3CmQ0lANfdkAHHemcsHda/ xns2gjJ185MyJOzvbGxX1z/OUSybZkgy0fleWYa4xlBdIGFYlqJ/igZr5g7nqU+QWWhQ ZKh8BC0EWh+qUBlps1MWOxrAgTrAXgs2Hjx3rj6NQBl9JhTf/Z6Kf+Vo66LFgVCyiQFp 0ipfhY8ZUY3aiRrmeZZIiyHxYQRSVDcf5cNq2xRwY/XIfLkGfjZhM+OvSvhbY0ytbx45 3juWhJZkezTgYPRpVqTd3idKk7pY9uQljp7SN0MhDtpGVn6C8tn9l5Ewp6Z97ZHLoVmc 8yFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@verdurent-com.20150623.gappssmtp.com header.s=20150623 header.b=q+OSl8fe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a92-v6si21196521pla.291.2018.05.24.04.26.02; Thu, 24 May 2018 04:26:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@verdurent-com.20150623.gappssmtp.com header.s=20150623 header.b=q+OSl8fe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968844AbeEXLZS (ORCPT + 99 others); Thu, 24 May 2018 07:25:18 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:43147 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967855AbeEXLZL (ORCPT ); Thu, 24 May 2018 07:25:11 -0400 Received: by mail-ot0-f193.google.com with SMTP id y10-v6so1460330otg.10 for ; Thu, 24 May 2018 04:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verdurent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RgkwoWkG0peZRQdKusYC9/Npey3Lz04rTHJOR1XPVJs=; b=q+OSl8fem0duEsQUhedvuV1oyIB5TjS6Jbh9WpywpPJvzoDWgxjwdOIPUNl7JYxNg+ LKqaiUmUcl2it0TAjV1XiEJc0rBxTHjwET21GpqRPj7MTBgeecHxrRoEDjqk5VSnbp+o RxfePwwQyfRWkD7MQfc0Eu8ZHQO81cC9HP+Ts1iRGPYdCuiHMQpbkQq+OZaCgeBBvYFv yiu2GvLj2yUvorQ1yZ+7loC6OriHPNvmyjwmm+VhxBOvwFQtlIBAZ60radVV5+FVry3g IzjcSaUci9+LulvEm4cL4dMBtmjqgKjgboVl+3y4UUq44FqX2myU7WIlOByI5dPUMI/f nzsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RgkwoWkG0peZRQdKusYC9/Npey3Lz04rTHJOR1XPVJs=; b=AqRo0yg5VFz87EUpTLj+rzeLP3LYilNtGftSXsKBwg8CLKjK0bSiADzYyRY5psWI9S F4TzmSRMsk4U/tdU7gw1um+HDfYdNWuFMPny8svU9LIDbp0U6lJxQtnALY18Ii4lEb+3 zXtkcYIG6ilce/FFwmpYu3Px+FZ8KyjCAPG29ILh6T6S/iv2u6n9aLeyMl836O4ucU62 dxYrpRHabJzvJrtMINHSbXg+EeC5H+palcZ3YeoHSaZQSSsofp1SWdZoP6Tw8avTshbY AbmqjFhXglgaONAo5tipT7BPjCgkQLHQoA6pUnhZKi6iW1dUaFD0YNbvAfnphrzfoY9j +Qyw== X-Gm-Message-State: ALKqPweHf6TQzsElat2xnEksVITQUVQ+5bESFXJEaVxPclOlmGR9Qgsq I5cUtoUs3NKSt3sNOJqGWJG6wIM7aRqfEbtveqiRgw== X-Received: by 2002:a9d:2c7:: with SMTP id 65-v6mr4597657otl.71.1527161111023; Thu, 24 May 2018 04:25:11 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:c485:0:0:0:0:0 with HTTP; Thu, 24 May 2018 04:25:10 -0700 (PDT) In-Reply-To: <1527148218-16540-1-git-send-email-ilialin@codeaurora.org> References: <1527148218-16540-1-git-send-email-ilialin@codeaurora.org> From: Amit Kucheria Date: Thu, 24 May 2018 14:25:10 +0300 Message-ID: Subject: Re: [PATCH v12 0/8] Clock for CPU scaling support for msm8996 To: Ilia Lin Cc: Michael Turquette , sboyd@kernel.org, Rob Herring , Mark Rutland , Andy Gross , David Brown , will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, LKML , vireshk@kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, lakml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 24, 2018 at 10:50 AM, Ilia Lin wrote: > [v12] > * Addressed the kbuild fail on arm architecture > > [v11] > * Split the series into domains > > [v9] > * Addressed comments from Viresh and Russel about the error handling > > [v8] > * Reordered the patch series into 4 groups > * Addressed comments from Amit about the comments and commit messages > * Addressed comments from Amit and Viresh about the resourses deallocation > > [v7] > * Addressed comments from Viresh about resourses deallocation > and DT compatible > > [v6] > * Addressed comments from Viresh about: > ** Comments style > ** Kconfig bool instead of tristate > ** DT and documentation style > ** Resourses deallocation on an error > ** Typos > > [v5] > * Rebased > * Addressed comments from Bjorn about SPDX style, > functions and parameters naming > * Addressed comments from Viresh DT properties and style, comments style, > resourses deallocation, documentation placement > * Addressed comments from Sricharan about unnessesary include > * Addressed comments from Nicolas > * Addressed comments from Rob about the commit messages and acks > * Addressed comments from Mark > > [v4] > * Adressed all comments from Stephen > * Added CPU regulator support > * Added qcom-cpufreq-kryo driver > > [v3] > * Rebased on top of the latest PLL driver changes > * Addressed comment from Rob Herring for bindings > > [v2] > * Addressed comments from Rob Herring for bindings > * Addressed comments from Mark Rutland for memory barrier > * Addressed comments from Julien Thierry for clock reenabling condition > * Tuned the HW configuration for clock frequencies below 600MHz > > SOC (1/15): > Extracts the kryo l2 accessors driver from the QCOM PMU driver > > Clocks (2/15-9/15): > This series adds support for the CPU clocks on msm8996 devices. > The driver uses the existing PLL drivers and is required to control > the CPU frequency scaling on the MSM8996. > > Ilia Lin (6): > soc: qcom: Separate kryo l2 accessors from PMU driver > clk: Use devm_ in the register fixed factor clock > clk: qcom: Add CPU clock driver for msm8996 > dt-bindings: clk: qcom: Add bindings for CPU clock for msm8996 > clk: qcom: cpu-8996: Add support to switch below 600Mhz > clk: qcom: Add ACD path to CPU clock driver for msm8996 > > Rajendra Nayak (2): > clk: qcom: Make clk_alpha_pll_configure available to modules > clk: qcom: cpu-8996: Add support to switch to alternate PLL > > .../devicetree/bindings/clock/qcom,kryocc.txt | 17 + > drivers/clk/clk-fixed-factor.c | 2 +- > drivers/clk/qcom/Kconfig | 10 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/clk-alpha-pll.c | 1 + > drivers/clk/qcom/clk-alpha-pll.h | 6 + > drivers/clk/qcom/clk-cpu-8996.c | 510 +++++++++++++++++++++ > drivers/perf/Kconfig | 1 + > drivers/perf/qcom_l2_pmu.c | 90 +--- > drivers/soc/qcom/Kconfig | 3 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/kryo-l2-accessors.c | 56 +++ > include/soc/qcom/kryo-l2-accessors.h | 12 + For the perf/l2-accessors part, Reviewed-by: Amit Kucheria For the entire series, Tested-by: Amit Kucheria