Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2016661imm; Thu, 24 May 2018 04:34:33 -0700 (PDT) X-Google-Smtp-Source: AB8JxZojRNUQ/r6bHNGgIdcy0B85mqrGTNNZvqEMLtceZGLHovZVOvnklxm09WJ7fmlhquLJyiqX X-Received: by 2002:a17:902:988b:: with SMTP id s11-v6mr6982618plp.304.1527161673507; Thu, 24 May 2018 04:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527161673; cv=none; d=google.com; s=arc-20160816; b=ZK2NNopmYa9EYH4tD964JIUwT8v6w2LxyxRvRKO95IQEdnmljtgZs2x9Vjdloq/4ZG HazzPTC7QKJ/utagzuXU44F57wGC6UjjOx1kTLGY12OltOO3wXer6RQOeA/HUg4bGst0 0GNXii95z2ztZxppiHYIDrrYqbKgRSrof1pOLml9jyWTlMKqwq3qRSzoHCdqxj5k6geM dMmsrt6B5dpLBx2GWt1DDSCwfDw/xWNqI+a+mc+AEr/YIIW2MMO1C7frt2uGEHjHq6mC uVWBsRWEX0vwsRT115sz1EbfBJWRB8e4oQjN7XjKumladkmhVXz6peKKiYO6x1nhikcL oVIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=t0wpvtMRIE/dX6xlA8Zd0t7JDMFUlY4KrGhqACa24PM=; b=kbzsVJJEl/W/Yx5Er9MXRbH/97KF/9+bLWP/UM1d11s6PY+I/nN9cmS1pzvQ+Q75YL J07nbUaQK5pIBB3Yuktpog/c0mfMspdJ7WWM/9KUZiwSth7mE2dP9FFXMZgc+HTgp6ki Wlri9h9ntsb7xo4O5LeXIvX7rhiJvbc2y5PFQa1AHGN6XEorpS4hj46J3gcrBrybGgd1 Wp2/cJBqjuprefVyGK4rHcnxOe+m7fOzlPVHE7s+gz0tegBhSnZIarQb7B0l3je6KXz2 720XsYs2Pb2mX9XlupPsK+uPGzxFZcMcCS1Sim5ZTZXAhu6lxr2ScyctX4RLWsyyc6PE y8HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T4k5XqUb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13-v6si16346069pgq.675.2018.05.24.04.34.18; Thu, 24 May 2018 04:34:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T4k5XqUb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967577AbeEXJu2 (ORCPT + 99 others); Thu, 24 May 2018 05:50:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:40990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967432AbeEXJuN (ORCPT ); Thu, 24 May 2018 05:50:13 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F25F20847; Thu, 24 May 2018 09:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527155412; bh=DCA7+JH/TVAqJnsp/L4CAwL2S3fFhy6Dr8p69DFd74M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T4k5XqUb+Mu/eI74LTVqBooyeYxvvo/SDgB5/T+SeLR8eQp0R4cNiS7UZ1Ha/cpn4 InKnGIUmkxO4Io31qgbt+QXZJlfw+YJ7JPHRkBpx++0FbLGnZig0iXTgjqmby5ufl6 bg8bw3jwFcGiP7lN5l9SlAi2g08FV2eADtduGPkU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrzej Hajda , Tomasz Figa , Chanwoo Choi , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.9 77/96] clk: samsung: exynos5260: Fix PLL rates Date: Thu, 24 May 2018 11:39:00 +0200 Message-Id: <20180524093609.812313765@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093605.602125311@linuxfoundation.org> References: <20180524093605.602125311@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrzej Hajda [ Upstream commit cdb68fbd4e7962be742c4f29475220c5bf28d8a5 ] Rates declared in PLL rate tables should match exactly rates calculated from the PLL coefficients. If that is not the case, rate of the PLL's child clock might be set not as expected. For instance, if in the PLL rates table we have a 393216000 Hz entry and the real value as returned by the PLL's recalc_rate callback is 393216003, after setting PLL's clk rate to 393216000 clk_get_rate will return 393216003. If we now attempt to set rate of a PLL's child divider clock to 393216000/2 its rate will be 131072001, rather than 196608000. That is, the divider will be set to 3 instead of 2, because 393216003/2 is greater than 196608000. To fix this issue declared rates are changed to exactly match rates generated by the PLL, as calculated from the P, M, S, K coefficients. Signed-off-by: Andrzej Hajda Acked-by: Tomasz Figa Acked-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/clk/samsung/clk-exynos5260.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/clk/samsung/clk-exynos5260.c +++ b/drivers/clk/samsung/clk-exynos5260.c @@ -65,7 +65,7 @@ static const struct samsung_pll_rate_tab PLL_36XX_RATE(480000000, 160, 2, 2, 0), PLL_36XX_RATE(432000000, 144, 2, 2, 0), PLL_36XX_RATE(400000000, 200, 3, 2, 0), - PLL_36XX_RATE(394073130, 459, 7, 2, 49282), + PLL_36XX_RATE(394073128, 459, 7, 2, 49282), PLL_36XX_RATE(333000000, 111, 2, 2, 0), PLL_36XX_RATE(300000000, 100, 2, 2, 0), PLL_36XX_RATE(266000000, 266, 3, 3, 0),