Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2018104imm; Thu, 24 May 2018 04:36:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqVkzpQ/S7DwaOEkAYtqwU4Sb95Wn21ROMQHFcM6uwgwO1jcvwXi5YNI4nYD9tPBnSs2zNX X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr7136006pln.114.1527161760189; Thu, 24 May 2018 04:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527161760; cv=none; d=google.com; s=arc-20160816; b=iAtBY+pLYOIqc1mh676li3vz2MXc5e7WJRbJbUKg3fd5snRdk+LXHb+bB7BW1cafi5 36hk1oDXsepc4daF2278dbIKjOLPfsPnjfdeK9OiDT24Ge5T1bnnZm/95AMycSVx3HMU 2LAOS4xe+Yk4MdinK4A9QuEYluQkL4PNczed+JwSlK3ZD5k6hY15yg0gLTI55K2pkSCf LI+vCx2jIjEiCcraZR2zYdXmbwzx2oRrgMRNkVi16E7EJOR8zBuTW9BX9Z0LBNdInppg cBBSPOAUqKYEWb9L1ABinRf337N/B/Oo5zC9osQaQdlRf66ElP2pd8wRqIshiM15BJ65 XTyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=e4n+Ufo+qimGYc+IDOBc8l4OfJzo2UWbEn8i+GzoIig=; b=SoHcPw9SoGVda0LA675miWKASzrI+TPilwGMJuxZiqfg2NzMk8anZ3WsQXxUcvgx5n 5Ff2rTTmEdSISuzrUjTftsw8iGPidMlxa7oLvbK7sLeFu+CEkTDqsYb6csZB7SpPX/0l Hdx3M7JJMT5T69BNJo+k+IUGoLEg7hFWBhxLBOS/kj5rQ/ah5F869kgi927o4VGDXXGx zsaGWcQ5drueSyOQGbqlaZ1rXjnnQgVGIN7Q4mg3riCqMlwBVhuH2oIwlNjf9xyP6+bX YaCNEZ+x94/OvT8gP67GGeiSWib1Bj7tuucuoN/cQ8qA74pwiY3cJ+oAAQALuHV2zi0W jOww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r5Ql1zS3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6-v6si16175145pgc.140.2018.05.24.04.35.45; Thu, 24 May 2018 04:36:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r5Ql1zS3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969068AbeEXLfN (ORCPT + 99 others); Thu, 24 May 2018 07:35:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:40854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967525AbeEXJuK (ORCPT ); Thu, 24 May 2018 05:50:10 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF8B820870; Thu, 24 May 2018 09:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527155410; bh=9TFJK9p/l+Du33x5m08YbA5OFdd1nkrRYVPu8l1grHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r5Ql1zS3f9WuP0p8bVSgjJNWUsSVRF4uL/qdIktPSMpZkwkMxC0k3aukyNGrw7iqd smISIFols7NX5BZMlqxo5DePL8oc32fg6a2NQ9eRSIOdUnzS+iNilcfw+qZE1pebV3 Eqx3qC5SG3KodB+uJAs3v7VcrUHe02p61NagRTUU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrzej Hajda , Tomasz Figa , Chanwoo Choi , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.9 76/96] clk: samsung: exynos7: Fix PLL rates Date: Thu, 24 May 2018 11:38:59 +0200 Message-Id: <20180524093609.758870746@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180524093605.602125311@linuxfoundation.org> References: <20180524093605.602125311@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrzej Hajda [ Upstream commit 7e4db0c2836e892766565965207eee051c8037b9 ] Rates declared in PLL rate tables should match exactly rates calculated from the PLL coefficients. If that is not the case, rate of the PLL's child clock might be set not as expected. For instance, if in the PLL rates table we have a 393216000 Hz entry and the real value as returned by the PLL's recalc_rate callback is 393216003, after setting PLL's clk rate to 393216000 clk_get_rate will return 393216003. If we now attempt to set rate of a PLL's child divider clock to 393216000/2 its rate will be 131072001, rather than 196608000. That is, the divider will be set to 3 instead of 2, because 393216003/2 is greater than 196608000. To fix this issue declared rates are changed to exactly match rates generated by the PLL, as calculated from the P, M, S, K coefficients. Signed-off-by: Andrzej Hajda Acked-by: Tomasz Figa Acked-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/clk/samsung/clk-exynos7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/clk/samsung/clk-exynos7.c +++ b/drivers/clk/samsung/clk-exynos7.c @@ -140,7 +140,7 @@ static const struct samsung_div_clock to }; static const struct samsung_pll_rate_table pll1460x_24mhz_tbl[] __initconst = { - PLL_36XX_RATE(491520000, 20, 1, 0, 31457), + PLL_36XX_RATE(491519897, 20, 1, 0, 31457), {}, };