Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2040757imm; Thu, 24 May 2018 04:59:54 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpmFI6bI3TdhUJlEoJTEGUI35OeON3UoZtFSa1fe1ibZTQYIXSxYdnRjSgPLlgIgMekQ4U6 X-Received: by 2002:a17:902:a507:: with SMTP id s7-v6mr7057163plq.258.1527163194444; Thu, 24 May 2018 04:59:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527163194; cv=none; d=google.com; s=arc-20160816; b=MqpKcR7xLCEY82kyxkZgLMG9Rx7oQe7CwusEZo4mttbHZS3pNiOfJcVS9Fpf1e+9ql aiFUsAtKllwgmxIr82sr6t+R247JOPFAqSSLgOCFadO8VElSLOcvCCFZlnAAzam/1aWj aApR3Exog/MVbwTp44C3Y3cp+uJasiVeNg5pHa5qqukQLCaqmhg1mmBmvtqTJHZZACOd YA/lmEYYuDxVUfmvGkfRceYBGDfUpQmR5e8mxv+32Wvk6/QliteIquz2zoaHbl/MK9t9 CKrq0Dc6bfg51TIKMrReiY9T5WuSzRLO7dWqH3fg9L9ar7SwoVQAJ6VlffVW8YiCmKBD Wv9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=kVmYRJk/SYlNEkZ918H8fc5G4Zku/9PFniKHn5bBBQA=; b=a5bhcWynfJM81pEE2gHDo5o8CaJb+J4YW0QeE8UP0q/nPzwucZCvjtcJz/Es8+a4Ie pj6hXPF7PLPBJzlgicW3yYoOcnX0RV1sGiirYZLUhQf50dYJ/ocv5X3KEWu4ZLTH2QTN 872sfjAmOwAIrWilW34lsvJhxfFfTVWX3KfFgWGSw3YZiCR0xrjhqmcSVKsk54E5Ms/x rFCHLR41zU4PfzmAJFTbtNkQ6bIdPu9bOjy5rvLWTpOQPuxROdpo3OFREeRzdBJ4E0Lc 4R1nzJjkMB5b/83LG1Gcs6kvGnYNC2cNTCuvN329SysUyhjgwiW64J9+FUhPlEeTV9yy ZaFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bd8-v6si19680129plb.559.2018.05.24.04.59.39; Thu, 24 May 2018 04:59:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969516AbeEXL7G (ORCPT + 99 others); Thu, 24 May 2018 07:59:06 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:42991 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969503AbeEXL64 (ORCPT ); Thu, 24 May 2018 07:58:56 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id B41BB80523; Thu, 24 May 2018 13:58:55 +0200 (CEST) Date: Thu, 24 May 2018 13:58:55 +0200 From: Pavel Machek To: Luis Henriques Cc: Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: class: ensure workqueue is initialized before setting brightness Message-ID: <20180524115855.GE27040@amd> References: <20180523222221.27621-1-lhenriques@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Content-Disposition: inline In-Reply-To: <20180523222221.27621-1-lhenriques@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2018-05-23 23:22:21, Luis Henriques wrote: > An application can try to set brightness before all the initialization is > done, in particular before the workqueue is initialized with the call to > led_init_core(). Here's a WARNING easy to trigger: Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --9l24NVCWtSuIVIod Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlsGqP8ACgkQMOfwapXb+vJ6JACgi04gYcyZrSvzMLIIVPwyCtHH vF0AmQEYa39unPnJ8xLUBks95xU+3+Dv =S7Vp -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod--