Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2796571imm; Thu, 24 May 2018 16:23:42 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo997otfabLnPWhZpsQYiOaLWC1mmyPWDpWfL7mutmtvtTfeDz6NEgDOk8ZNWfKufNjMoL2 X-Received: by 2002:a17:902:7d87:: with SMTP id a7-v6mr29163plm.264.1527204222103; Thu, 24 May 2018 16:23:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527204222; cv=none; d=google.com; s=arc-20160816; b=gLLWceQZdaynMOBeRbO/yUw/L3Ey1IcfONsYUa1/iHHic6uTaCkD66o5t9VakfpXa+ JYIFj2BFt4iSzp/6I0OYWdFCGFigJDRS4NfI57rJ+UYYDFHNTIaoQpyJyZTUg6C53N+Z ZT++QWxa8TydK5IEnqwcZdeczsu4XfyG5m9zBGswJQInZaSPOf4SVIJCA4hucvnxjEl9 InjekxrIiwJH+qEMtPiAUh10MsSu6qNfPRU7g+FAN3wZgDvLZL/l6lNUiCsJp+c8MkvV ebqxHuxLjOjfQzsKhpaC2QPHJ0x6dXVnnR7aGiQWRvQjm6KVMDinIr3Dpnc6kuu/VZPl REFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=lV6hw7zYFbCWwshmbT+XXlpaqfCL1RIklhzRHHrmDMo=; b=xO57SGrDns58DYygIUrr2Y6O8dhlQviHsQKicWEhDBpw1F3nXGPY6TO3dYfTnndOsM zhthFIZqERBWVyGkzeYLqUbk1T/EwciOwwFl9K4MOJURZGesVvVX+ASihQEY1X0+iL7l BykRn0bQbt8o3xp6vdjZngL6xRDf81l+IHVqkrYBq9m2bnYR3MsH7PcEA74sSTDzphNq QSTuQiFmCt2PnMPyzsJVyQFNrocY6VFE5N3Dqlrtsk4PXg8kK2dkQrEeFthWxTRbpcbt 8um8a/YJl8JTCxmLmVxrE3JWc4mb+fU4P6Ql0FcMZkafwuhQRnOGmN3zS1dKYnFxvbB5 ospQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g67-v6si22925618pfe.4.2018.05.24.16.23.27; Thu, 24 May 2018 16:23:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969176AbeEXNeU (ORCPT + 99 others); Thu, 24 May 2018 09:34:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:5859 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965818AbeEXNeT (ORCPT ); Thu, 24 May 2018 09:34:19 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2018 06:34:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,436,1520924400"; d="scan'208";a="49760095" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by fmsmga002.fm.intel.com with ESMTP; 24 May 2018 06:34:17 -0700 Date: Thu, 24 May 2018 07:36:34 -0600 From: Keith Busch To: Jianchao Wang Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 1/2] nvme-pci: set nvmeq->cq_vector after alloc cq/sq Message-ID: <20180524133634.GG11037@localhost.localdomain> References: <1527155494-1891-1-git-send-email-jianchao.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527155494-1891-1-git-send-email-jianchao.w.wang@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This looks fine. Reviewed-by: Keith Busch