Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 24 May 2018 19:28:21 +0200
From:   Christian Brauner <christian@brauner.io>
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     Linux Containers <containers@lists.linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Seth Forshee <seth.forshee@canonical.com>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [REVIEW][PATCH 4/6] fs: Allow superblock owner to access
 do_remount_sb()
Message-ID: <20180524172821.GA27641@mailbox.org>
References: <87o9h6554f.fsf@xmission.com>
 <20180523232538.4880-4-ebiederm@xmission.com>
 <20180524155803.GB19932@mailbox.org>
 <87603d3svh.fsf@xmission.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87603d3svh.fsf@xmission.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 24, 2018 at 11:45:06AM -0500, Eric W. Biederman wrote:
> Christian Brauner <christian@brauner.io> writes:
> 
> > On Wed, May 23, 2018 at 06:25:36PM -0500, Eric W. Biederman wrote:
> >> Superblock level remounts are currently restricted to global
> >> CAP_SYS_ADMIN, as is the path for changing the root mount to
> >> read only on umount. Loosen both of these permission checks to
> >> also allow CAP_SYS_ADMIN in any namespace which is privileged
> >> towards the userns which originally mounted the filesystem.
> >
> > Acked-by: Christian Brauner <christian@brauner.io>
> >
> >> 
> >> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> >> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> >> Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> >
> > Note, I just talked to Serge. This should be Acked-by: Serge Hallyn <serge@hallyn.com>
> 
> Now you know how long these patches have been sitting waiting to get
> merged.

Indeed. :)

Christian