Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2950623imm; Thu, 24 May 2018 19:44:32 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrxC5GAm+heSEUwB+Wvke8D+44KTj4aJBeLwkZYA6vuZQsrAaorAyfxALexf7lJ21JTExAl X-Received: by 2002:a62:ed12:: with SMTP id u18-v6mr583196pfh.127.1527216272097; Thu, 24 May 2018 19:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527216272; cv=none; d=google.com; s=arc-20160816; b=y5v35tj6uxUNhLmcw6btkLXMCMdT5vItcJt2K8FA1m6ZF58yFum0tC5lGmRLX1S5Mg tZC0TSiBasd+uxNuzL6kZF16aRbe1pbK97+oXDBL7xcgAYed/sg2x/Fa9JPakkV2XnWT GjDQT/ExhVQI19PXQdTlFJqj0hkXFX/w2ZNTywa9WaQ2sscAPGjQUFQBDajDiM9ZMVqj BWFHzTonOgHxZqdNX3VC93LlVM/ZDrOx4YhMaVqb6Ymmvc0yRtTMuqSWsFdBb1tHH3Yu vpeIm5+vg3HvLADnccSFMu+TD/dTTxWsZlcPqt218HVlBHw48FUlniexl85heBb52DU9 8gjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=nSpsnenQTOOBWQGkFsBDzg/xfd8W6RDLSrOiC/VatF8=; b=Ddn689toSCGFzKrW6QEny1J9CxUmNoE0jtkU0f+u7KYVv6nEbrrGYLO8gJv3pePVBs jE+jdOGhrUP00YzVOP/KlaFkFNwthyzAMFARU0p+CxTTS7wl14AF8u86z1ZxHrfa8YF5 zlRLwhKSce8Tit7ilDUCRmBtsJAXoPblDO4bUtbxF1m7nG2aNip6wlJIRfVZu0O8Y88j ntOStMmlmKWe4Czpr4Bqn78T/Yq7GHZfwRIogU5HUZR/9f2BiwHP+gmjZKmZh6ZjXoen EFX1IfERQ3YM0ONl52PvT7Noy0NpYim21cEx9Agz1SyuX8SwE1810UXzXvwHF7HYiIAs 3EfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TVlEN/P9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi10-v6si20700116plb.399.2018.05.24.19.44.17; Thu, 24 May 2018 19:44:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TVlEN/P9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161464AbeEXVjd (ORCPT + 99 others); Thu, 24 May 2018 17:39:33 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:44659 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966304AbeEXVjb (ORCPT ); Thu, 24 May 2018 17:39:31 -0400 Received: by mail-pg0-f65.google.com with SMTP id p21-v6so1345614pgd.11; Thu, 24 May 2018 14:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nSpsnenQTOOBWQGkFsBDzg/xfd8W6RDLSrOiC/VatF8=; b=TVlEN/P9MrDUYpy4yNgOjY31JHjtQzjoYPkuQAWXVx2gsSAmXByvmTVWx12FYy6KJL 74PDI9fQkGETuAPtNAJNVu1clsEEg0UfLJqhw4aJB1NHr7NNUdTeSeYVMdTzzi16BjUF kyF2LHKiMIqISnkEcp6Qve+61q3ryQsAN6E7CdXLh2w8CvqFY8BMou1lXEHhaHAnc1fG cEjLGwM17V/RbZUfC5EaFRYy2cfeMtSDvCPUA/mQwVRoP46KGKM3Xt4CtL7KFne2MqW5 SvX+T6dN3J9EyCzse0McYcFqRecnZOicPyB7/swJ3tNikySSNOliI7VIBML8UUfR4Y5f vTKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nSpsnenQTOOBWQGkFsBDzg/xfd8W6RDLSrOiC/VatF8=; b=Hwzyo2WSV8F+wz+vlVpFzS8jgNe+chRc355il4r3+q5GL4R/FvzBxE4cqQGfTeki4n AjJDU9H8l+IR5AI7rRuirPw/DS2OoT5lY7pcxX8/yCQ6ecXn6xBkhzEWtpDT1r10o/4v RnV7ELw4sFgwBEZaYmZibYiVTAIsyEz9jcPvJxr2SYmX0B4i2qMaprTlP1DBYiwsA0qw yT8UZy+wxadD6Jce4LIAvhUZViHToxnHLtl2nHHwJFANDcSlwt9KytboCmPpV+vOfUGm ULXJAy23h1cpuCK18mASrOzvPmvJaY91MDC+mGl+bx96vZQ2PmFuGeb/FmUzs1Rm0/4s UkeQ== X-Gm-Message-State: ALKqPwebu1YrvCXLbrnv5DUaE3zB7uRbwhZXfG01OQE9gsNzdEofH7sX nD2fhRqgRyniwj3pvSaEIAA= X-Received: by 2002:a65:5206:: with SMTP id o6-v6mr7317524pgp.157.1527197970825; Thu, 24 May 2018 14:39:30 -0700 (PDT) Received: from 192-168-1-10.tpgi.com.com (110-175-8-199.static.tpgi.com.au. [110.175.8.199]) by smtp.gmail.com with ESMTPSA id g68-v6sm37384054pfk.53.2018.05.24.14.39.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 May 2018 14:39:29 -0700 (PDT) From: Jon Maxwell To: davem@davemloft.net Cc: dsahern@gmail.com, mschiffer@universe-factory.net, zhangshengju@cmss.chinamobile.com, ktkhai@virtuozzo.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jmaxwell@redhat.com Subject: [PATCH net-next] ifb: fix packets checksum Date: Fri, 25 May 2018 07:38:29 +1000 Message-Id: <20180524213829.15208-1-jmaxwell37@gmail.com> X-Mailer: git-send-email 2.13.6 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path. Otherwise we get splats when tc mirred is used to redirect packets to ifb. Before fix: nic: hw csum failure Signed-off-by: Jon Maxwell --- drivers/net/ifb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c index 5f2897ec0edc..d345c61d476c 100644 --- a/drivers/net/ifb.c +++ b/drivers/net/ifb.c @@ -102,7 +102,7 @@ static void ifb_ri_tasklet(unsigned long _txp) if (!skb->tc_from_ingress) { dev_queue_xmit(skb); } else { - skb_pull(skb, skb->mac_len); + skb_pull_rcsum(skb, skb->mac_len); netif_receive_skb(skb); } } -- 2.13.6