Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2953814imm; Thu, 24 May 2018 19:48:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpSEz6bOyJYs95zQcDYh5mvsr5y0yxqRXvQiOOoM/x+D6Y6knBoRXu9LkcZ2jY2uzKoVq8r X-Received: by 2002:a65:534d:: with SMTP id w13-v6mr485348pgr.178.1527216517173; Thu, 24 May 2018 19:48:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527216517; cv=none; d=google.com; s=arc-20160816; b=Fx8D1sThap8J+KXO+R5m/pzLYactQ9D9ENymIAzouDmRAoQjCmAs0t0NTaEEB0GLI6 IBdzC7h/l2QOw9ys2HIc2iNSdGj0qNIUeoRVhjOkYdztkD12IDk9VWoCtBmVDXmzNdso vWTlOSzzYONI9rjSxx1TFrDFbDhm86faAvK5GidRLyMDMr3MDXJIMJD7AyMjxg+FvWyg GdpdOxH+fXONHZ2itgdfvgb6Ym+GFjRXOPG3rW7DPxe3SO26e/ALVmrnU6cg2UGrCkPY oSOvHqvq4HA4WvYgZZDi7rx63Hdvn4MgsxDyL1/4Fc1dcnhNmQrtnKLs3Vo7eP+KaRuB dUww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=6U3hBReMBxBXgs/DvdFYmDhmur9Jjj1+toFTAVPkV/k=; b=olnZzdQpZZHDa/13l0dvuzHIKWGFGxK9vAd/OtSamQC9QmfvL4WkCtBOEumFkUexbq LgyqwdkojNxyFBd6G82uHt6lD8+crT/xSr9RhSNrytaQeracyf2cNRRjTdUCXIjK6SDu zYo0uFcYM4mAGwDtJNsFzoK1XZH56LsCQvKkv4iAaoJR58M7vXNFzEiXxAG4RHuzpJeK 1K7cYTDJUYfTiL2Qxl4kWP807Pcl9+2Tc4E6CaccQblLXxPRmMsk1ydVKusd98GpkIjm YMD4OwDd3iEi96IMZnVH1gIUqQq+vKJjabfn/x0a05DrGFG8QeQXxPNQU/xAjfcpQ2Vx khyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@infradead.org header.s=bombadil.20170209 header.b=RZF8GRI4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1-v6si21597578plr.332.2018.05.24.19.48.23; Thu, 24 May 2018 19:48:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@infradead.org header.s=bombadil.20170209 header.b=RZF8GRI4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969985AbeEXXwT (ORCPT + 99 others); Thu, 24 May 2018 19:52:19 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49980 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935346AbeEXXwR (ORCPT ); Thu, 24 May 2018 19:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BewuukGDBD1GI/SXglkAQPfVjEe6jafnmuXD0EKic3Q=; b=RZF8GRI4McyJfR3//+XDK5zq0 gpOM69uEDqodSPgCyrYmGEq+ne2mrnL7CMOj96bgW4kuddrLwzVBEAX/CZsBvA7QrupEckM16sVY+ HAHhRgXs55vfkMYEhSGqO54HpFpXfHHH+61hiFZfnelBlPFljDfgdSZjSw0qSaS9ady9ByRzSFTTV sJPhvVsdfyuJlhLQXpdUeKZkb+m6BqRFCwm2hCFLpNoumzjQzPzvJQaBlL8rJSNDyZOESfp9h+RRS plnqDuttX6CfmPQSeaym+TSu/gvXzXopxYQ+Crb9/98ufrALi6uPIfA7cNcx8wXMNsL0W9tnCFYuA qxUUkOVZQ==; Received: from dvhart by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fM01o-0000Hl-0t; Thu, 24 May 2018 23:52:16 +0000 Date: Thu, 24 May 2018 16:52:14 -0700 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, michaelsh@mellanox.com, ivecera@redhat.com Subject: Re: [PATCH v2 3/7] platform/mellanox: mlxreg-hotplug: add extra cycle for hotplug work queue Message-ID: <20180524235214.GA10172@fury> References: <1525675735-125547-1-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525675735-125547-1-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 07, 2018 at 06:48:51AM +0000, Vadim Pasternak wrote: Hi Vadim, > Add extra cycle for hotplug work queue to handle the case when a signal is > It adds missed logic for signal acknowledge, by adding an extra run for > received, but no specific signal assertion is detected. Such case > theoretically can happen for example in case several units are removed or > inserted at the same time. In this situation acknowledge for some signal > can be missed at signal top aggreagation status level. The extra run will > allow to handler to acknowledge the missed signal. > ... > > Fixes: 07b89c2b2a5e ("platform/x86: Introduce support for Mellanox hotplug driver") This sha doesn't exist in mainline, I believe you are referring to: $ git l | grep "Introduce support for Mellanox hotplug" 304887041d95 platform/x86: Introduce support for Mellanox hotplug driver While this was introduced in 4.10. There have been many changes since then, with significant changes in the 4.17 cycle. I have not added the stable tag, please let me know if you think this should be pushed to stable, and which of the intervening patches you'd consider dependencies. I've fixed the sha in the commit message, and queued for testing. Thanks, -- Darren Hart VMware Open Source Technology Center