Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2953981imm; Thu, 24 May 2018 19:48:51 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrDOJI74r4HDIzm9Rjdp9hRrPsc1ag+DOniaLrG4b1BuF6/fFqMCvsMKRgI36UStqY0o/9D X-Received: by 2002:a62:db05:: with SMTP id f5-v6mr592928pfg.137.1527216531904; Thu, 24 May 2018 19:48:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527216531; cv=none; d=google.com; s=arc-20160816; b=I1Pevm8F3fiusw1gdMNghhb+6wSgLO2nGvXm7w190LliKLrl+Wq0+etdDXY0ckOmtl BuEfuMnkgFAEqE8ismuE5JE/y7D5tLtUWrSzdiuV8Tiq4y1tJbVSdz93ECil+PhmASj6 83yVgr9eHeWJwoEs+GIkourpL2FDdH3/iCC5CQUcdk7ZL3UbJqY0uUU80K7Xxg7hCU8B bVJCJxpdh42lkhCfP+Tf6FkOolW+U8BgJaOaDjK8g8XvC963OORlHSOoH8SgBOQvcKu1 g4sDSEM4AzoRR/4SdfG02WzYJ6phBG0HylKF3HfCwuVHBbCsSBDHffyiBBV8fWPSUpyj Bodw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization:arc-authentication-results; bh=h6/uKOauG6Oq3WoK+nw1LiR6OvgO9T9qqmvqIFhGLPg=; b=iLdSkwrUQHN8YZB8yiMxAK0+Cca8E0hm4vwjkfLHCzoJOxhCGg5yYCTTVHcXSZNR/t czoOt7d0eZzJf+AKlo8v7IYnqkFlf8GXlkSaGwRZPr83l1RCJ6r7581JVMR135q3n+Lf 0WMcdP7w55cCOJc7Mw8OlEVLkkPuRPc6rZDXU+VdKYJLGsGeqLLu+Q7zONbwcQMk9nXe B0+5GWLbp1OPJa+uXRIZ7bG4xOfnak593WYmAXzCCQ2TgNqbVrXUJkwt9NScnwiLD9g/ o9PbIJiZYLGQN5JNP6D6sRBNBFuZ6W01dpWqu/3Db5La0yDUjCJdzIOtpe9rMCqMudrj U+HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h62-v6si22925442pfg.308.2018.05.24.19.48.37; Thu, 24 May 2018 19:48:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S971870AbeEYAIE (ORCPT + 99 others); Thu, 24 May 2018 20:08:04 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36030 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S971861AbeEYAIB (ORCPT ); Thu, 24 May 2018 20:08:01 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C422DC12B3; Fri, 25 May 2018 00:08:00 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25AC9946BB; Fri, 25 May 2018 00:08:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 24/32] vfs: Add some logging to the core users of the fs_context log [ver #8] From: David Howells To: viro@zeniv.linux.org.uk Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 25 May 2018 01:07:59 +0100 Message-ID: <152720687964.9073.10576985036203472428.stgit@warthog.procyon.org.uk> In-Reply-To: <152720672288.9073.9868393448836301272.stgit@warthog.procyon.org.uk> References: <152720672288.9073.9868393448836301272.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 25 May 2018 00:08:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 25 May 2018 00:08:00 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add some logging to the core users of the fs_context log so that information can be extracted from them as to the reason for failure. Signed-off-by: David Howells --- fs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/super.c b/fs/super.c index 06a665628939..447476d4371c 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1743,8 +1743,10 @@ int vfs_get_tree(struct fs_context *fc) struct super_block *sb; int ret; - if (fc->fs_type->fs_flags & FS_REQUIRES_DEV && !fc->source) + if (fc->fs_type->fs_flags & FS_REQUIRES_DEV && !fc->source) { + errorf(fc, "Filesystem requires source device"); return -ENOENT; + } if (fc->root) return -EBUSY;