Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2955408imm; Thu, 24 May 2018 19:50:43 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqeUPEaRNx+5v3SD/JCjihCWjLy2TZ5xuHGuSc9d06Sx3cFkLd6JSQp67aYIrTFj14KLQoG X-Received: by 2002:a63:a902:: with SMTP id u2-v6mr475979pge.169.1527216643084; Thu, 24 May 2018 19:50:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527216643; cv=none; d=google.com; s=arc-20160816; b=PG3375+m62I3f/4W/c1V8wJm+Zijum6+IQopAipLAvlp2W2I7TBW2hHhMrPnqj1UdS +/IFK94CE9a7Cu9RfLMsdgm2HlMjFVM1WS6amjI8pLvgOvlH+wkgUhXs88siUWXaUoPR TePRAY9Ft87RYYrshnvWCT57LRkj/X8TKjigMvVbbNKbB001ou1uc/xceUAJMqEwf4RU W6CyJZe0NaP+x+SRyEhyVziOFY6j1AR28VgV3pAZ2zEBbyQHZO5mytNnw/fP0IZnyvRz s3i+x3H9qRstFbY2QNaQdxpNic2uO9C03uDGSF817rFaURpEQuD5bag6bAbkpyEtGSxq XWmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=4qZiuSelAFs9os5uMLXt4TsyuTJ72ltK6Id+j8OD6Oc=; b=D0ufZUn8A77/nzSjmDKrEuizXYR/rLk0sz7i2mL30mBSc+TOlWKLzOzC7ZVns4G+zn zzbpLQe1wrbYiGFiIWddirYTbtl7gkKF1Ut/mPDRimyKlRZMm38NJki9AIbKZ7Vz9YnQ rLRNPe3TuQpwg62oTzKBWujgmeGsUIaqnyIM9FzXDRKPb4n1pISVEFrEADDZQnA5TZFp NX/yPOZp82w2t2pfOjPzdq70De0chC2a5C8r45/0tdYlF/B34GH2IsFGe95sNkOqveg+ y9CLys0chTwfgNGqogakzNirFQxkmAHGhxOHn/m/YH9ttvWduqvKaR8R0fXZhD8HnuTu WyqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t128-v6si17674145pgc.582.2018.05.24.19.50.28; Thu, 24 May 2018 19:50:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935769AbeEYCbf (ORCPT + 99 others); Thu, 24 May 2018 22:31:35 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935184AbeEYCbd (ORCPT ); Thu, 24 May 2018 22:31:33 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24562402290A; Fri, 25 May 2018 02:31:33 +0000 (UTC) Received: from [10.72.12.58] (ovpn-12-58.pek2.redhat.com [10.72.12.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47F912026DEF; Fri, 25 May 2018 02:31:28 +0000 (UTC) Subject: Re: [RFC v5 0/5] virtio: support packed ring To: Tiwei Bie , mst@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: wexu@redhat.com, jfreimann@redhat.com References: <20180522081648.14768-1-tiwei.bie@intel.com> From: Jason Wang Message-ID: Date: Fri, 25 May 2018 10:31:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180522081648.14768-1-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 25 May 2018 02:31:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 25 May 2018 02:31:33 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jasowang@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年05月22日 16:16, Tiwei Bie wrote: > Hello everyone, > > This RFC implements packed ring support in virtio driver. > > Some simple functional tests have been done with Jason's > packed ring implementation in vhost (RFC v4): > > https://lkml.org/lkml/2018/5/16/501 > > Both of ping and netperf worked as expected w/ EVENT_IDX > disabled. Ping worked as expected w/ EVENT_IDX enabled, > but netperf didn't (A hack has been added in the driver > to make netperf test pass in this case. The hack can be > found by `grep -rw XXX` in the code). Looks like this is because a bug in vhost which wrongly track signalled_used and may miss an interrupt. After fixing that, both side works like a charm. I'm testing vIOMMU and zerocopy, and will post a new version shortly. (Hope it would be the last RFC version). Thanks