Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2959952imm; Thu, 24 May 2018 19:57:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq/aFIgnfS0PCZyxy/t5Y9eyfmko3jlnR0S/UZUQZIRaRdX0fZVPkE3ROkEHCG3K1/sIJ1e X-Received: by 2002:a63:7341:: with SMTP id d1-v6mr493075pgn.404.1527217033890; Thu, 24 May 2018 19:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527217033; cv=none; d=google.com; s=arc-20160816; b=JQbx5g5bRfr9srQW0SnGp+EGkZ/vFmaor1IiaVJs5j6YrMSRSvLUCpEqShhow9lAC9 x/hnWWoh3Lqc6auGv8D/rkFBVi0gxVq0wM97i7j0W/bA7CX+5qHX/38vUY5Z8U5A8iC0 nlp0T5cOvKEHGQ6/ykFzygwKd5nofNKe1c9R8U25mIPO/WZytcAqjQ7oWh1hs3yoJpZQ v9Q9c8PjFuOMOk73kovqNKh0OuMQFuiFeByVKANLnST7iHsTWUayo8tDHVmMlCgDkDqh ZL/xDwOilu3JU7ovFXOwf2gy+u6qp1FG62v03hDxOGx2epvx7BgdkTg3Mec2UJnoG2xb GbzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=dDSG+AxxzxQdsowS3FoWJORUXXG5OxPdRljjY3WDUsA=; b=jeM4ID8G2oiBevuo0PhohbbaYgkQIjX4ra7BGLCJT52iPlsXytQhisjGLB7itnP8dE BVbeZvTVYc+sj82vEdXzyCOggBlQHGI7AC89KLYldXgzoJZ46nPgoINwsyrXf1AbHd6H VrCXsJT7DU+h2wGGhwePI0QhMbWBCcQpjtPWl+8G2qgmcbJ9VtLqAzMv02O/zabFdqnp z4CQIk+h3ABXW6NEfJ754o8h5Nt2dnFKWMkkPzTClrMZIGNwwL334AQcWUOU4Skj4yL2 ohPmOmUF7/cdez5hqID0rs0aCeFWacNSWvSlnpWKd/5qutm+yZ9j2lTDIbxmiPWD3lP4 6jpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14-v6si4528126pgz.284.2018.05.24.19.56.58; Thu, 24 May 2018 19:57:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710AbeEYCzZ (ORCPT + 99 others); Thu, 24 May 2018 22:55:25 -0400 Received: from mga05.intel.com ([192.55.52.43]:22224 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbeEYCzW (ORCPT ); Thu, 24 May 2018 22:55:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2018 19:55:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,438,1520924400"; d="scan'208";a="42054613" Received: from theros.lm.intel.com ([10.232.112.164]) by fmsmga007.fm.intel.com with ESMTP; 24 May 2018 19:55:21 -0700 From: Ross Zwisler To: Toshi Kani , Mike Snitzer , dm-devel@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, Ross Zwisler Subject: [PATCH 0/7] Fix DM DAX handling Date: Thu, 24 May 2018 20:55:11 -0600 Message-Id: <20180525025518.11405-1-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series fixes a few issues that I found with DM's handling of DAX devices. Here are some of the issues I found: * We can create a dm-stripe or dm-linear device which is made up of an fsdax PMEM namespace and a raw PMEM namespace but which can hold a filesystem mounted with the -o dax mount option. DAX operations to the raw PMEM namespace part lack struct page and can fail in interesting/unexpected ways when doing things like fork(), examining memory with gdb, etc. * We can create a dm-stripe or dm-linear device which is made up of an fsdax PMEM namespace and a BRD ramdisk which can hold a filesystem mounted with the -o dax mount option. All I/O to this filesystem will fail. * In DM you can't transition a dm target which could possibly support DAX (mode DM_TYPE_DAX_BIO_BASED) to one which can't support DAX (mode DM_TYPE_BIO_BASED), even if you never use DAX. The first 2 patches in this series are prep work from Darrick and Dave which improve bdev_dax_supported(). The last 5 problems fix the above mentioned problems in DM. I feel that this series simplifies the handling of DAX devices in DM, and the last 5 DM-related patches have a net code reduction of 50 lines. Darrick J. Wong (1): fs: allow per-device dax status checking for filesystems Dave Jiang (1): dax: change bdev_dax_supported() to support boolean returns Ross Zwisler (5): dm: fix test for DAX device support dm: prevent DAX mounts if not supported dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode dm-snap: remove unnecessary direct_access() stub dm-error: remove unnecessary direct_access() stub drivers/dax/super.c | 44 +++++++++++++++++++++---------------------- drivers/md/dm-ioctl.c | 16 ++++++---------- drivers/md/dm-snap.c | 8 -------- drivers/md/dm-table.c | 29 +++++++++++----------------- drivers/md/dm-target.c | 7 ------- drivers/md/dm.c | 7 ++----- fs/ext2/super.c | 3 +-- fs/ext4/super.c | 3 +-- fs/xfs/xfs_ioctl.c | 3 ++- fs/xfs/xfs_iops.c | 30 ++++++++++++++++++++++++----- fs/xfs/xfs_super.c | 10 ++++++++-- include/linux/dax.h | 12 ++++-------- include/linux/device-mapper.h | 8 ++++++-- 13 files changed, 88 insertions(+), 92 deletions(-) -- 2.14.3