Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2961012imm; Thu, 24 May 2018 19:58:49 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrpvww8vWT9Qh3gEmhX6v9bQjlWw0xqQQpQDZbyW7sJusyVAEs9BkBK5PsQMo23WMYl4fCG X-Received: by 2002:a17:902:f83:: with SMTP id 3-v6mr661504plz.336.1527217129881; Thu, 24 May 2018 19:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527217129; cv=none; d=google.com; s=arc-20160816; b=vWYtnfYvjSuZvp30IzcMNYSZYsi0DMbJq3ii1BeI/R1sIIUNImF80Y6+frv6OSgG01 H5j6aJ8ixODClE6Ymj0evV0+pskYzKHd6OZbEQMahY5cAh8X2MU2niGbNzLgGeZwr3h3 rHqua0yb1GWRhOCRUlnW4+g9+jUVjiqPtEuolyDUbifYRWsKI0JUVqW1MsGjEYHSrVME Rt2nSuyID5VnlujQ8yFcDHc2b+K0vlfcNuISNAsv1J9MkJjOiCQc2iz1xdVta70Owz0h 8UtSXC8CuRzTTtCQne68Jn1jYawp4PFCvYlvJySs1SCQl53+/YOZaJJvXCCtAuBCy5+P ol1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=GEVHRWA+I7U/uPYPdhd3Qo9nyqtJEp60t3Enc3KKffg=; b=GHms55ixCa+cG+fcJVOXRwLVqFcWqEjfNXEJANrihPGh3izgYU5ckPJbBmT6UqRmaC BPNeWCbOgVTVStXYymUqwGdzE914kj1A2PmrePYa2aJNEFoQ0+h8mfGi9OK+T+JG6Lrj PzoPTB7I1mAPtAsc6/XrQZhRed/bN91T8+gcSzBMBrXiMqIJsr5Os5Yo9DfpKxA8rrmm U1QWjmLenLFzD1YfsTHp+SjScSyjEA+funVht094npmn8ea+cCR3V6c2AIqQjPPZRHwS L5vTe7Ass/VADsFscMiOGfZKQlPxGMdrpi2KBlVAPWM0Zp9EYZJX5/pJaQDckISpX3FS 1ODw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4-v6si17759001pgp.74.2018.05.24.19.58.35; Thu, 24 May 2018 19:58:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755296AbeEYC4f (ORCPT + 99 others); Thu, 24 May 2018 22:56:35 -0400 Received: from mga05.intel.com ([192.55.52.43]:22228 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754762AbeEYCzg (ORCPT ); Thu, 24 May 2018 22:55:36 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2018 19:55:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,438,1520924400"; d="scan'208";a="42054623" Received: from theros.lm.intel.com ([10.232.112.164]) by fmsmga007.fm.intel.com with ESMTP; 24 May 2018 19:55:24 -0700 From: Ross Zwisler To: Toshi Kani , Mike Snitzer , dm-devel@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, Ross Zwisler Subject: [PATCH 6/7] dm-snap: remove unnecessary direct_access() stub Date: Thu, 24 May 2018 20:55:17 -0600 Message-Id: <20180525025518.11405-7-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180525025518.11405-1-ross.zwisler@linux.intel.com> References: <20180525025518.11405-1-ross.zwisler@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-snap.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 216035be5661..0143b158d52d 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -2305,13 +2305,6 @@ static int origin_map(struct dm_target *ti, struct bio *bio) return do_origin(o->dev, bio); } -static long origin_dax_direct_access(struct dm_target *ti, pgoff_t pgoff, - long nr_pages, void **kaddr, pfn_t *pfn) -{ - DMWARN("device does not support dax."); - return -EIO; -} - /* * Set the target "max_io_len" field to the minimum of all the snapshots' * chunk sizes. @@ -2371,7 +2364,6 @@ static struct target_type origin_target = { .postsuspend = origin_postsuspend, .status = origin_status, .iterate_devices = origin_iterate_devices, - .direct_access = origin_dax_direct_access, }; static struct target_type snapshot_target = { -- 2.14.3