Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3000744imm; Thu, 24 May 2018 20:53:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZopCozFiyu8blqqAZml+YzqRMZs6CVPXm4K5O+VNRUmEqdlJCsKS17ivhK3tRiRMK6e+Kqi X-Received: by 2002:a63:770f:: with SMTP id s15-v6mr668784pgc.30.1527220439225; Thu, 24 May 2018 20:53:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527220439; cv=none; d=google.com; s=arc-20160816; b=lW3XKUli139wOdhoww9FloDGOcu5R14bF11N9BJUJIvGLK9n+D7ZbZXzQ2BJF6dnfy 6p8mu6b5gASVmU74nw2uxIHEreHjNIxEE/wtlJD+0Fs76mt0PkURRtQxvRfT8h2BKQJs 3zQyNwMqsca0wArUvrC+35j2Ox2bNXuRi8MwcHKMnXijGEFqFpfn3TmRkz/yIcreZ5j1 yYrffebwsmu0LWW90+9oGqOtK8ZN50MfJo0u6y0wXYWcdRjza0D6X0pY647q5t04tdFW izEJ4+Xq264PIxNFqWLoigej3RBH/SgNIVleswu48PUUh8OsMB5WV+EF2vvbNie+Ln2H hm+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=xNSZsQhcTWf4Fi1+5kv/C+HXBI2hb81QgVCjYUqd4kQ=; b=ADV5kgoJr2cu3bIPJdhz2/0+kQNEiutNfSvALVDbiUfjGq63UF3SXW06ghAuyoJBbU OmpMpi18NSYiFfmZSWOsouzMtkQTNz9LLjBi4x3MT3FITgrwvTALmc1CANhQp6H++HlJ 2Ujh8mUMx3440LVkD06AOfRyo4sFv8vqhPrTDKr84bnrgXi52zaabPfFQb93/P/uOoDq EYlEJEW7GhIO8TemPx4GFKNzf3nAQ6KHJpMEKz9KRGzo4Ej/Krz2u6YaQ1WbtWFnt1qw PR9Ve7T3xP2q58gv8ei4bnMQDEL3+Q/O+UN6ZE77WU9JGJJAgvfSvBLoXadOhgRsxBbx yMCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s187-v6si826131pgc.447.2018.05.24.20.53.44; Thu, 24 May 2018 20:53:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935669AbeEYDx3 (ORCPT + 99 others); Thu, 24 May 2018 23:53:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41618 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754950AbeEYDwV (ORCPT ); Thu, 24 May 2018 23:52:21 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E081C401EF03; Fri, 25 May 2018 03:52:20 +0000 (UTC) Received: from localhost (ovpn-12-30.pek2.redhat.com [10.72.12.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id C37432166BB2; Fri, 25 May 2018 03:52:13 +0000 (UTC) From: Ming Lei To: Jens Axboe , Christoph Hellwig , Alexander Viro , Kent Overstreet Cc: David Sterba , Huang Ying , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , "Darrick J . Wong" , Coly Li , Filipe Manana , Ming Lei Subject: [RESEND PATCH V5 30/33] block: enable multipage bvecs Date: Fri, 25 May 2018 11:46:18 +0800 Message-Id: <20180525034621.31147-31-ming.lei@redhat.com> In-Reply-To: <20180525034621.31147-1-ming.lei@redhat.com> References: <20180525034621.31147-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 25 May 2018 03:52:21 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 25 May 2018 03:52:21 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ming.lei@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch pulls the trigger for multipage bvecs. Now any request queue which supports queue cluster will see multipage bvecs. Signed-off-by: Ming Lei --- block/bio.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/block/bio.c b/block/bio.c index c160c143cc1b..bc3992f52fe8 100644 --- a/block/bio.c +++ b/block/bio.c @@ -876,6 +876,11 @@ int bio_add_page(struct bio *bio, struct page *page, * a consecutive offset. Optimize this special case. */ if (bio->bi_vcnt > 0) { + struct request_queue *q = NULL; + + if (bio->bi_disk) + q = bio->bi_disk->queue; + bv = &bio->bi_io_vec[bio->bi_vcnt - 1]; if (page == bv->bv_page && @@ -883,6 +888,14 @@ int bio_add_page(struct bio *bio, struct page *page, bv->bv_len += len; goto done; } + + /* disable multipage bvec too if cluster isn't enabled */ + if (q && blk_queue_cluster(q) && + (bvec_to_phys(bv) + bv->bv_len == + page_to_phys(page) + offset)) { + bv->bv_len += len; + goto done; + } } if (bio->bi_vcnt >= bio->bi_max_vecs) -- 2.9.5