Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3079903imm; Thu, 24 May 2018 22:41:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq87YPkq15yfiJpKD8O1PnAsqTY7va29jrlLILymfXXu6YPZGx1+qTP1uDtWRwn+hCm946x X-Received: by 2002:a62:3d54:: with SMTP id k81-v6mr1072444pfa.193.1527226874208; Thu, 24 May 2018 22:41:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527226874; cv=none; d=google.com; s=arc-20160816; b=sTQUSyJjwopn2hXHGfGrbXpsbjCzml2Vb/9P4HTX2a3MwplkE5PTwsa3SXZjG+l2ek HfigSiuSt5xUkmHGSOdfvx/YDdEE4j13Fdh6nTkLWi/iEeFrT3fHtQlnTE/j8BMA3Su5 5kj/90SDIpNqt3skExd8K+VzinHIWQkBgNMxEGzA5VKomlHK0yaQf79S9EanLhA4eZ/r dKTxLGO5DF2GtcppvWPIXv2A2QSLKb5jmJ5nB+E2+Y6RE/lk+0BSnDWHw9bE2ciUuxbo NjkyKm1yhZH4PKOrip4GIk1x2jfpaJULDRE9gj2+vqqVWTzrhIAG0Ct1t8fCC0tW1Scv MD1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=3owkLNekyB+F51qF2xmEv7fT8CE3xQHPsbGPpJfAzZM=; b=Xf24HMsM7uf5ihU40SGx/xRL8p+KJah3yhoWfq3h9IsqiwJoZ0eGL9Yagregnq1YBw 28h/iFUZvc/hq4jFeHCTgl7W+S5Qn7jXQgcHc2itHRXO9DHg4iL2YWVvOJ/OmsZZ8dEc YpHuO5QIBTm4/xl5y1kqhVkjYASrlTAnq8AlG5vk/JJKOfj56KRqDbv35fc7IVpkSOh/ n960vkOLHZQDKBoLCZiMZLEzZqZ50ggEj7gNHAEhostGT8yDd4y6RoiQkQnE34SdhPfk EPqG4fjnSLlGo1V4UmOS7G/8/QngNufheDuMhILeHlfITEcbUUrabwBB9++Zp2X2DrrA qNyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=c1TyAYId; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3-v6si22842964plt.71.2018.05.24.22.40.59; Thu, 24 May 2018 22:41:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=c1TyAYId; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964917AbeEYFkj (ORCPT + 99 others); Fri, 25 May 2018 01:40:39 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:43761 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964843AbeEYFkg (ORCPT ); Fri, 25 May 2018 01:40:36 -0400 Received: by mail-pg0-f68.google.com with SMTP id p8-v6so1798336pgq.10 for ; Thu, 24 May 2018 22:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3owkLNekyB+F51qF2xmEv7fT8CE3xQHPsbGPpJfAzZM=; b=c1TyAYIdLK96SC7lMfn+y01IAgExPuLevGOOnIWa4EcLo/368TrCNU+rX8D2CJsWQJ cVIiIpMdryPl9k1AyVRzxnmFUusN4DOgJuls0DWtnUwUMD3/3Z/MrQCjUa0ZWwoGIFLp M2CcfzTGB2ZilLmx+lUV/7S3DTkwiNFw9NrDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=3owkLNekyB+F51qF2xmEv7fT8CE3xQHPsbGPpJfAzZM=; b=KIhdCPwxcZ5cp9KKWNZ4jcCc3YAIPWWFpeoZviKQC/PFlZRJ8c/N6xOTJFPqVJ5MHJ OLY1ua+TjaO7upHox/VTVV51jW7+d2lIEFDJMm1Phal9CjtdP0TMv31UOF7Q1UsfKBdX oH5bNSO5Qmv/OD1cdVJi6PVfm2sjfVh9sMSoLwj5gREoh1iUYbskYOYBb3fc+Pc1d/Io WUSVPbkOYVeL1ut/exCC2+Bc2ZoCKvzX2NMFS5q9LnM+2dZxJfyD4foihfSa/1vCLNQL P3QPxQfvepBwHM049Pv5IRWdLaTPw1YorQozT9p7SzM0ytyv0z65LmZyiKBJ9kF811hD TP4w== X-Gm-Message-State: ALKqPwc3oaS7E8Pnu/Fq2lN3N4IiSlIXlaiXXh9XkMoSzgFrT4p6zNMX 2jiL7bTp5iaO6cqSnDJpZW3bqFu6o6A= X-Received: by 2002:a62:9056:: with SMTP id a83-v6mr1098973pfe.186.1527226835339; Thu, 24 May 2018 22:40:35 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id a10-v6sm35398333pfo.55.2018.05.24.22.40.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 22:40:34 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] arm64: dts: freescale: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 11:10:02 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Do minor rearrangement as well to keep ordering consistent. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 5 ++++- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 +++ arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 6 ++++++ arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 4 ++++ arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++ 5 files changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index 1109f22bda5e..630ee47441f2 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -80,8 +80,8 @@ reg = <0x0>; clocks = <&clockgen 1 0>; next-level-cache = <&l2>; - #cooling-cells = <2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu1: cpu@1 { @@ -91,6 +91,7 @@ clocks = <&clockgen 1 0>; next-level-cache = <&l2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu2: cpu@2 { @@ -100,6 +101,7 @@ clocks = <&clockgen 1 0>; next-level-cache = <&l2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu3: cpu@3 { @@ -109,6 +111,7 @@ clocks = <&clockgen 1 0>; next-level-cache = <&l2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; l2: l2-cache { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi index 136ebfa9b333..ee7beab8bfae 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi @@ -87,6 +87,7 @@ clocks = <&clockgen 1 0>; next-level-cache = <&l2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu2: cpu@2 { @@ -96,6 +97,7 @@ clocks = <&clockgen 1 0>; next-level-cache = <&l2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu3: cpu@3 { @@ -105,6 +107,7 @@ clocks = <&clockgen 1 0>; next-level-cache = <&l2>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; l2: l2-cache { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi index 1c6556bcfddf..e64823a25158 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi @@ -76,6 +76,7 @@ reg = <0x1>; clocks = <&clockgen 1 0>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu2: cpu@2 { @@ -84,6 +85,7 @@ reg = <0x2>; clocks = <&clockgen 1 0>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu3: cpu@3 { @@ -92,6 +94,7 @@ reg = <0x3>; clocks = <&clockgen 1 0>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu4: cpu@100 { @@ -109,6 +112,7 @@ reg = <0x101>; clocks = <&clockgen 1 1>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu6: cpu@102 { @@ -117,6 +121,7 @@ reg = <0x102>; clocks = <&clockgen 1 1>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; cpu7: cpu@103 { @@ -125,6 +130,7 @@ reg = <0x103>; clocks = <&clockgen 1 1>; cpu-idle-states = <&CPU_PH20>; + #cooling-cells = <2>; }; CPU_PH20: cpu-ph20 { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi index 8d739301e7b8..c264b6d1bd7f 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi @@ -65,6 +65,7 @@ clocks = <&clockgen 1 0>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster0_l2>; + #cooling-cells = <2>; }; cpu2: cpu@100 { @@ -84,6 +85,7 @@ clocks = <&clockgen 1 1>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster1_l2>; + #cooling-cells = <2>; }; cpu4: cpu@200 { @@ -103,6 +105,7 @@ clocks = <&clockgen 1 2>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster2_l2>; + #cooling-cells = <2>; }; cpu6: cpu@300 { @@ -122,6 +125,7 @@ clocks = <&clockgen 1 3>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster3_l2>; + #cooling-cells = <2>; }; cluster0_l2: l2-cache0 { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi index 0884e1a77901..b6ea9e96c866 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi @@ -65,6 +65,7 @@ clocks = <&clockgen 1 0>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster0_l2>; + #cooling-cells = <2>; }; cpu2: cpu@100 { @@ -84,6 +85,7 @@ clocks = <&clockgen 1 1>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster1_l2>; + #cooling-cells = <2>; }; cpu4: cpu@200 { @@ -103,6 +105,7 @@ clocks = <&clockgen 1 2>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster2_l2>; + #cooling-cells = <2>; }; cpu6: cpu@300 { @@ -122,6 +125,7 @@ clocks = <&clockgen 1 3>; cpu-idle-states = <&CPU_PW20>; next-level-cache = <&cluster3_l2>; + #cooling-cells = <2>; }; cluster0_l2: l2-cache0 { -- 2.15.0.194.g9af6a3dea062