Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3079990imm; Thu, 24 May 2018 22:41:21 -0700 (PDT) X-Google-Smtp-Source: AB8JxZonsmcG621sfID2e3tFvTx2xdpb4bwHtOixe+Omij0Mkz68Nga1SbhGvmRc7nS1AzPp3NrC X-Received: by 2002:a62:ee15:: with SMTP id e21-v6mr1070537pfi.203.1527226881256; Thu, 24 May 2018 22:41:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527226881; cv=none; d=google.com; s=arc-20160816; b=EJ22uDy4n7dtvjyG23vXqK3Y2XNTUnM5xwdmhvU5nUEp/SizKbTuqvkfz1T3auCTRK bcyvTHZkueEBK9gxCpO3fBGFc6SR2AHzAQT4QDfkTBQXj1MbnMVp66IdkK1TGgcm+kbK lP2p2WCO63avNQeZOdZnUedJ6mgoZcav53VxEA1j+lVizJI7UrtDqwJDR2epRREXbS6U deWzr0/WdrdaE/k1OnA5LXpXdSZFGKNr5nFQQF24joye81EtBXrDneD0vOf0HH+Mbr1+ tKJGNR/w0GO9PTf27OrUBWmIenuR3TiQlFsIVYZegZda3gCGv1zwyagbLhM368bXf06j VFrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=0R4yxojOPc8DMkNP+2+XwqTUa9Wws43ZzgN5jtGILvc=; b=VrEIlQt8wVhYXkiO3GsmKMwJkoBueVNXkoLrBE629lFNpCL1dMbYYcFzz1IlUYbmYl K9QU0FBbGehW9/FQTa8gOwiBSErhdPxoz9VK046zOFC4Ad4VW3hr+TvcscGGBoOMTEGG uJNbI52L9zZzZ+IoeZmrxuHDoGjN3QXNqg3hvAxUvUQdM6Ckkw94QYEdeBfW5FXT9EgG gkpx53xG5rHkhhifyNp3wZW0BDXa7jHU7Z5RjAlnQ5WTQZmndpkMIakay4GOhwRxGpAS ctcaU8lI64wVAVbMsPFvf1b8Sgcka998m3bafbmXMZMJgd68xD6lKHQywnUBtFu/Z0VN K4/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d/zmHH+J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2-v6si23958881plk.433.2018.05.24.22.41.06; Thu, 24 May 2018 22:41:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d/zmHH+J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935831AbeEYFkr (ORCPT + 99 others); Fri, 25 May 2018 01:40:47 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:45122 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964947AbeEYFkl (ORCPT ); Fri, 25 May 2018 01:40:41 -0400 Received: by mail-pl0-f67.google.com with SMTP id bi12-v6so2450358plb.12 for ; Thu, 24 May 2018 22:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=0R4yxojOPc8DMkNP+2+XwqTUa9Wws43ZzgN5jtGILvc=; b=d/zmHH+JWhIDThSRy/cZ01hDHm5bv44LmAxGmS6gnOHSOUzJo1V2KDlPL+zj6NcreG 24bLrxc9fXqrDLbUM3thwFqOAmsRHOVrL9rHXUnBPt2HkjXTS2TjLtX/bY3/QwB43IQk Zz7asRRPp/5TUJ/trxOjyDG5eKKV2mTRwFUFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=0R4yxojOPc8DMkNP+2+XwqTUa9Wws43ZzgN5jtGILvc=; b=cRCiAarvY8EbYrqwq1MJaHQGbGRJBtJchWLHXxM8lX7eUqY44+I8orRbzcfvcmSSly WsDlQbLXpfB6/wJ08XNYXhWThRn1JqL6yw4z9bXjp8MPo2Hu8PubN4YrAmILto9qwWNj 550lT1JnHnGgHZy4b5UF/l2jSiptK3VKk5EDyGqUxXhwwKsUY67JnCkXWCy8DW5RPhc3 ZBUOACi2khTOctBZSWPV+CDNr287MlsgA6VTTgCTLmILD+N/LNZcirggPBT0CPOhl79p ImEn7BxxAMRYaNj1BIBQ6XReHGkjE/Vchw+WuwFCO1pJXz/LK4zVMsrWIdp3Jwekx/gC MEaw== X-Gm-Message-State: ALKqPwcoEz6d9xzOrbmIKqSc8D7IGZIZJ+rmc6xI8+6RB6v7UVmjizNp zsfZT1Q7VVa+6HYEac0eia3jwQ== X-Received: by 2002:a17:902:d20c:: with SMTP id t12-v6mr1115186ply.364.1527226841306; Thu, 24 May 2018 22:40:41 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id p6-v6sm43193894pfg.157.2018.05.24.22.40.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 22:40:40 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Matthias Brugger , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] arm64: dts: mediatek: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 11:10:04 +0530 Message-Id: <49b1086c104b0ee22f6e992a0abb380de9320c09.1527225682.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 9213c966c224..d49fe125e770 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -89,6 +89,7 @@ <&apmixedsys CLK_APMIXED_MAIN_CORE_EN>; clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; enable-method = "psci"; clock-frequency = <1300000000>; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 94597e33c806..abd2f15a544b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -168,6 +168,7 @@ reg = <0x001>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + #cooling-cells = <2>; clocks = <&infracfg CLK_INFRA_CA53SEL>, <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate"; @@ -193,6 +194,7 @@ reg = <0x101>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + #cooling-cells = <2>; clocks = <&infracfg CLK_INFRA_CA57SEL>, <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate"; -- 2.15.0.194.g9af6a3dea062