Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3241012imm; Fri, 25 May 2018 02:09:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqJP48DvalgneGunPG+yWlshmwdOj4Ka5SGUIUt8f4FBB5EwYln1plMjqsN/RHr7ri2kSpo X-Received: by 2002:a62:4086:: with SMTP id f6-v6mr1690827pfd.194.1527239378138; Fri, 25 May 2018 02:09:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527239378; cv=none; d=google.com; s=arc-20160816; b=pC8qlu7PntD+/k9OqhUxLPKRk6qnYBxXwbGuQK2M6I8tdO0rhe/Vv66n+zXrXRXGx/ PcEBMVLfDbCr6EmFXhtx7vjvnD+Lg76OkWL0MwODjuP9d73R3iNu6wEDMqLGCTUuHVUB ZTwgqjZU+48D9uR+kobSQXFzrFdeddju9F0ZrmSFtP7IRS6nSX/mI7GuijLg9oaj0eBd Ys1Y/zt9wNlsnr64kNUBDuWiPdPbefggTjtjKRaGqgqkz1TacKH5vdbhk5s6syqxKls4 auQQW35oPs/unJYIim/5tMYNPxjZOoDaeg3JVkikejgEEJLLOr77s/Ij7jOOrul7Kpr6 ECiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=qSEaEDNzhldBnXafj+K8gypgUYWiqqavUCFPzTOI6vI=; b=IjCMa65EtRcDQ/lJfuUlnvJRoPDXudyu1+xVU69o8RusiPyUITZVBYJx0UWKSnqLBk Yp27GYypeza1R3qwxmGJV7/oekDrr4653RoP5nBERjVemVR+stgRdoO7wuMJssu5QmyP 0h/WlgOpHVyCydWGG+WBG2sAO+iYPk6nWKi2Tsbpz33nGWUt50lksNuFURHDeXHqmOoF qoxbdCLt2lWBwbNw3KvQ0zcWJe6mneH+ZLMmUlt6A3tRr9F8JYajGumaJQkFt0oy+raJ 0ovNl7gFL2ZxBAMxhupx+VwWxJACYsom6h8gYyVQN2IEZOs5er1CqfofDA3CsbIBKCKY nhkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@rainbow-software.org header.s=atlsmtp header.b=ckP6ExFI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w187-v6si448010pgb.11.2018.05.25.02.09.23; Fri, 25 May 2018 02:09:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@rainbow-software.org header.s=atlsmtp header.b=ckP6ExFI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965406AbeEYJIv (ORCPT + 99 others); Fri, 25 May 2018 05:08:51 -0400 Received: from smtp-1b.atlantis.sk ([80.94.52.26]:48602 "EHLO smtp-1b.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964917AbeEYJIr (ORCPT ); Fri, 25 May 2018 05:08:47 -0400 Received: from gsql.ggedos.sk (off-7.infotel.telecom.sk [212.5.213.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-1b.atlantis.sk (Postfix) with ESMTPSA id E178C8346C56; Fri, 25 May 2018 11:08:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rainbow-software.org; s=atlsmtp; t=1527239325; bh=+U4HBBii/1sjrMM2xKPv4CG0pg0aCHcZndvzkRmAq9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ckP6ExFIhafOFDYu0uJt2mpIJVDY+Vq+1U43lpilD1oFkISyPIZE8S4zKMmnw6UT5 HR6K8cX/waC5NXoO+QwcfBFK+eCcwZ+IGrKwTl/S7pD+/ZtLVDzZd8aydo/R08+tVe kNv8ZsQu9kuQKUU1iAZXVAFpJixUeeyDdd7aDPMk= From: Ondrej Zary To: Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3 v2] gspca_zc3xx: Enable short exposure times for OV7648 Date: Fri, 25 May 2018 11:08:43 +0200 Message-Id: <20180525090843.31735-3-linux@rainbow-software.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180525090843.31735-1-linux@rainbow-software.org> References: <20180525090843.31735-1-linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 50Hz and 60Hz power line frequency settings disable short (1/120s and 1/100s) exposure times for banding filter (causing overexposed image near lamps). No flicker setting enables them (when banding filter is disabled and they're not used). Seems that the logic is just the wrong way around. (This bug came from the Windows driver.) Signed-off-by: Ondrej Zary --- drivers/media/usb/gspca/zc3xx.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca/zc3xx.c b/drivers/media/usb/gspca/zc3xx.c index c72f2d9167d9..cf21991e3d99 100644 --- a/drivers/media/usb/gspca/zc3xx.c +++ b/drivers/media/usb/gspca/zc3xx.c @@ -3186,7 +3186,8 @@ static const struct usb_action ov7620_InitialScale[] = { /* 320x240 */ static const struct usb_action ov7620_50HZ[] = { {0xdd, 0x00, 0x0100}, /* 00,01,00,dd */ {0xaa, 0x2b, 0x0096}, /* 00,2b,96,aa */ - {0xaa, 0x75, 0x008a}, /* 00,75,8a,aa */ + /* enable 1/120s & 1/100s exposures for banding filter */ + {0xaa, 0x75, 0x008e}, {0xaa, 0x2d, 0x0005}, /* 00,2d,05,aa */ {0xa0, 0x00, ZC3XX_R190_EXPOSURELIMITHIGH}, /* 01,90,00,cc */ {0xa0, 0x04, ZC3XX_R191_EXPOSURELIMITMID}, /* 01,91,04,cc */ @@ -3202,7 +3203,8 @@ static const struct usb_action ov7620_50HZ[] = { static const struct usb_action ov7620_60HZ[] = { {0xdd, 0x00, 0x0100}, /* 00,01,00,dd */ {0xaa, 0x2b, 0x0000}, /* 00,2b,00,aa */ - {0xaa, 0x75, 0x008a}, /* 00,75,8a,aa */ + /* enable 1/120s & 1/100s exposures for banding filter */ + {0xaa, 0x75, 0x008e}, {0xaa, 0x2d, 0x0005}, /* 00,2d,05,aa */ {0xa0, 0x00, ZC3XX_R190_EXPOSURELIMITHIGH}, /* 01,90,00,cc */ {0xa0, 0x04, ZC3XX_R191_EXPOSURELIMITMID}, /* 01,91,04,cc */ @@ -3221,7 +3223,8 @@ static const struct usb_action ov7620_60HZ[] = { static const struct usb_action ov7620_NoFliker[] = { {0xdd, 0x00, 0x0100}, /* 00,01,00,dd */ {0xaa, 0x2b, 0x0000}, /* 00,2b,00,aa */ - {0xaa, 0x75, 0x008e}, /* 00,75,8e,aa */ + /* disable 1/120s & 1/100s exposures for banding filter */ + {0xaa, 0x75, 0x008a}, {0xaa, 0x2d, 0x0001}, /* 00,2d,01,aa */ {0xa0, 0x00, ZC3XX_R190_EXPOSURELIMITHIGH}, /* 01,90,00,cc */ {0xa0, 0x04, ZC3XX_R191_EXPOSURELIMITMID}, /* 01,91,04,cc */ -- Ondrej Zary