Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3374969imm; Fri, 25 May 2018 04:47:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpiRSl1zHBkg/cet02vGqY5nO7o9ZrVldly/yCy+JfQsq8H9bMPCiMSled6dMTXjLK4p+Ld X-Received: by 2002:a17:902:b489:: with SMTP id y9-v6mr2271405plr.385.1527248823422; Fri, 25 May 2018 04:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527248823; cv=none; d=google.com; s=arc-20160816; b=v1DeU5Pb0rnsk9mfEF0tbv9EUFVck1r5dsr/rU82FBvtC+OCoL0BkFHcoPfwQ1ICs3 dEDpzunPwl8Z6YjPpu9w+ZpbeZaMVzectgxZGR6j7DDoSzJUYDD4WgobVRWQFPkXVtoP NQ1P+QtFH4joWsjCC+BNeZWZXFi2eHrrEOsb1snlsQwWESsPxcqBvW8QKv5YY1pQ2T1g o51VTNkBgn96jVCoUGQPquNDPHWacn0MjOKL/c+TzacpoEVGgwaa5qTtZKg8e+XaG75X yC588nipvuGbxjxpV+0vkYhx1DcKzQfLJSZUxS47U2AKZamZihBBNiYLde540BW8/NmD uMBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=GjlPP6mSA1mvXommINOmJOCQsU68vFm9LshxLpGn96o=; b=ADHEzppvdVvEBl6kF95pD1MmERgRtRYnK7jm8/pNUZlGQasz1/1AGIfN7GD+mAfUzo X2rsL+Ajq4xHhXVPN8KN48OKTbUygrzwy4qf3ZGL8QFGGBKgKsHj6ThMOOTyval3U7or Z1tvtyjT4V/b+Py7IQac/mzLYLMoJW4ph3E6ei1UvOvEvrSv5wo2ZZOSikQ2PVATj3BL bPeIJzMLxC2lUyVdIEw9CzglzyWdd4xFuvAznwF16dazP6u1xyVolgIpfiwtN60ZfrqR K0reqmBS4BUaXhwFQ11I0W36ac02jnnepuFjS02OWEFrZ18HXLtUM8Pm1ZJu/k6yEUAC 2S5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12-v6si17969255pgn.631.2018.05.25.04.46.48; Fri, 25 May 2018 04:47:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966577AbeEYLlf (ORCPT + 99 others); Fri, 25 May 2018 07:41:35 -0400 Received: from ozlabs.org ([203.11.71.1]:33597 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966560AbeEYLld (ORCPT ); Fri, 25 May 2018 07:41:33 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 40skqJ4Wr0z9s32; Fri, 25 May 2018 21:41:32 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: c3f0515ea1277558e7c0c3240d17c77d2a3fcefe In-Reply-To: <20180404201230.27756-1-malat@debian.org> To: Mathieu Malaterre From: Michael Ellerman Cc: Mathieu Malaterre , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [v3,13/19] powerpc/52xx: Add missing functions prototypes Message-Id: <40skqJ4Wr0z9s32@ozlabs.org> Date: Fri, 25 May 2018 21:41:32 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-04-04 at 20:12:30 UTC, Mathieu Malaterre wrote: > The function prototypes were declared within a `#ifdef CONFIG_PPC_LITE5200` > block which would prevent them from being visible when compiling > `mpc52xx_pm.c`. Move the prototypes outside of the `#ifdef` block to fix > the following warnings treated as errors with W=1: > > arch/powerpc/platforms/52xx/mpc52xx_pm.c:58:5: error: no previous prototype for ‘mpc52xx_pm_prepare’ [-Werror=missing-prototypes] > arch/powerpc/platforms/52xx/mpc52xx_pm.c:113:5: error: no previous prototype for ‘mpc52xx_pm_enter’ [-Werror=missing-prototypes] > arch/powerpc/platforms/52xx/mpc52xx_pm.c:181:6: error: no previous prototype for ‘mpc52xx_pm_finish’ [-Werror=missing-prototypes] > > Suggested-by: Christophe Leroy > Signed-off-by: Mathieu Malaterre Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c3f0515ea1277558e7c0c3240d17c7 cheers