Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3552888imm;
        Fri, 25 May 2018 07:38:54 -0700 (PDT)
X-Google-Smtp-Source: AB8JxZp2rhtC8SZfx6nHlUzMZd67zOs/nRnfrVU753QtmGG1FRWZGRTlBZcJxcpyHUNt/vL+YeO+
X-Received: by 2002:a62:9c93:: with SMTP id u19-v6mr2913669pfk.74.1527259134386;
        Fri, 25 May 2018 07:38:54 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1527259134; cv=none;
        d=google.com; s=arc-20160816;
        b=pU4bHV+XadaH9M2ZomNILW9DI6dVqyOVn9QhzUyXcU3mNu1bzvZBUCOyJXqWVSLbN+
         8G0qm6+DUe6Gld8B7h7IBr6RQSm5lBU0zupteOw8tlKbi/6HsVLC5ElcIvCz9iFHr2tY
         iNeu4SK6DUZ9DGC5JfC3AqaR/9Q5TMCkOt518l7Gu0ThC8bCMPdrQ0h5IgJAfOvIiQbk
         C+yhLKbpU61LaafYZ7bhyo82fX5FvkxxEWIOJRq9oq/UEJ370SgihWdYaea0bdhetuIA
         FX7SpXJE6iNy65haTItUoSJ4nhJykPQElVWTgp7uCBKZB3coICLylS0iN7h9isF5MXKG
         5Khw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=o97WR8XKEVDhgnKo06kiKurFFr8ngo2ZxpD8zw6YB6k=;
        b=MRR66ygWJAx9dmKbZI267KmZz5Da/WGG+dj179fOd6fwYeuP9j4+zXSoRWDdIeABlb
         RoweccHCowMzKxLXTkW3a3VFAw1whGKNtq+EpEr+SZ7cEqyn8VdSY5ndKFuo0JNjOWdJ
         jRuct/UR4qITTBGeoxnqeTphHI8+TKSxwjP1pP89nCKycv1QIqm4NTXa9R0oS8LvCHWU
         akm6OLiyKV5RVGZXNbuGQFROHQFcMPoM4yFGdxfrBtAH0JKFKg+bo5jIT7J13SF4H4QB
         7RAKD7Z1aftssSuAC+IzliQCef7+id2x34DaDwILFT8u8bVbFeytV+h9PxanCzTGANvz
         0yYA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id b6-v6si22710873plx.211.2018.05.25.07.38.38;
        Fri, 25 May 2018 07:38:54 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936354AbeEYOg6 (ORCPT <rfc822;saikripd@gmail.com> + 99 others);
        Fri, 25 May 2018 10:36:58 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:11614 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S936092AbeEYOgy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 May 2018 10:36:54 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b081f8c0001>; Fri, 25 May 2018 07:37:00 -0700
Received: from HQMAIL103.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Fri, 25 May 2018 07:36:56 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Fri, 25 May 2018 07:36:56 -0700
Received: from BGMAIL102.nvidia.com (10.25.59.11) by HQMAIL103.nvidia.com
 (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 25 May
 2018 14:36:52 +0000
Received: from [10.25.73.249] (10.25.73.249) by bgmail102.nvidia.com
 (10.25.59.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 25 May
 2018 14:36:49 +0000
Subject: Re: [PATCH] net: stmmac: Use mutex instead of spinlock
To:     Thierry Reding <thierry.reding@gmail.com>,
        "David S. Miller" <davem@davemloft.net>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jon Hunter <jonathanh@nvidia.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20180524140907.24197-1-thierry.reding@gmail.com>
From:   Bhadram Varka <vbhadram@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <e8eb5681-4030-ed4d-e63c-90801e878140@nvidia.com>
Date:   Fri, 25 May 2018 20:06:47 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180524140907.24197-1-thierry.reding@gmail.com>
X-Originating-IP: [10.25.73.249]
X-ClientProxiedBy: BGMAIL102.nvidia.com (10.25.59.11) To bgmail102.nvidia.com
 (10.25.59.11)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 5/24/2018 7:39 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Some drivers, such as DWC EQOS on Tegra, need to perform operations that
> can sleep under this lock (clk_set_rate() in tegra_eqos_fix_speed()) for
> proper operation. Since there is no need for this lock to be a spinlock,
> convert it to a mutex instead.
> 
> Fixes: e6ea2d16fc61 ("net: stmmac: dwc-qos: Add Tegra186 support")
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---

Tested on P3310 Tegra186 platform.

Tested-by: Bhadram Varka <vbhadram@nvidia.com>

-- 
Bhadram