Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3759022imm; Fri, 25 May 2018 11:05:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrMGvaG0NVGs9x7IawWNgoj1pYYaio1BiroOhMbC1dpTFWHI0b/lCzvf+y5t5AgoFS7eWoj X-Received: by 2002:a17:902:b681:: with SMTP id c1-v6mr3621056pls.286.1527271513636; Fri, 25 May 2018 11:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527271513; cv=none; d=google.com; s=arc-20160816; b=ptlBh2X5FWdlzySQuoa4WVmoWUKQ09YcLvJSkUdquLEqIQraVCg8JBmC35U37Y85yS sAIUEZQJLC2IOJVICmBM+AsONjVYJ5m6D0YZBiZiO0xbNOKQjVDkDUKJ/gjn6u9Y9i+k NDmjSa6GLjVGGneSo2m25qucupsMPyhQ8crHi5cyVt38tj4KWimJB5mZFOLYkq3Ah+th JEPX4TSmRum/+dO2KDHDRbWIUCh1ItFw8tRtDMmwRJXxz1+oL+q19+zcHO3AA4XAJB8r Swx766nkQmKBJigXg+Z9Y3CMOljj3JPfPeHTEpmQIzWQSUPuuoaJ/Q3O/EGnrkvQTDw1 /hJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=GwVUd/HGBMWFcnWiMGtY5J9WCsfEP8UFyMjWI9Cuzp0=; b=UGg4tm0Yngo+xBRA0mt6VppENgIWal3YeR9/QnmoThcTDTCyD3KLpLHzoppRso6+A4 KBpWdFS1gYIoudlhr18vIhef8LQjDx1sDsvOySiAodj0exCfy6DVf5OTwQQSdzv7mkYj 11VjifJy2BfTviWNn0r+ZYVxgfoy1mdLZOjCZTcYv7H11gORGr9vUzVTDo1KC5E76/Y5 tDKZaiiAM93ASiqc+nvY0OF6JWVjgxSjeJT84avvo0FnMDpHz0NUtIC3JeUF2cV/mdrX uIssrye/QDai3Brnif1MW3B1JYK+AEOFq5N90k0PwEyNOuMhU3ee0nlPifUEyPfwYuB0 LUFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b35-v6si24219717plh.36.2018.05.25.11.04.57; Fri, 25 May 2018 11:05:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967595AbeEYSEs (ORCPT + 99 others); Fri, 25 May 2018 14:04:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:31609 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967473AbeEYSEq (ORCPT ); Fri, 25 May 2018 14:04:46 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2018 11:04:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,440,1520924400"; d="scan'208";a="57626306" Received: from spandruv-desk.jf.intel.com ([10.54.75.31]) by fmsmga004.fm.intel.com with ESMTP; 25 May 2018 11:04:46 -0700 Message-ID: <1527271485.14836.49.camel@linux.intel.com> Subject: Re: [PATCH] tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation From: Srinivas Pandruvada To: "Rafael J. Wysocki" , Doug Smythies Cc: dsmythies@telus.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Fri, 25 May 2018 11:04:45 -0700 In-Reply-To: <9152600.1bIX9UMnel@aspire.rjw.lan> References: <1525441582-23855-1-git-send-email-dsmythies@telus.net> <23851272.hyr4RImLsD@aspire.rjw.lan> <9152600.1bIX9UMnel@aspire.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-05-24 at 11:34 +0200, Rafael J. Wysocki wrote: > On Sunday, May 13, 2018 10:43:02 AM CEST Rafael J. Wysocki wrote: > > On Friday, May 4, 2018 3:46:22 PM CEST Doug Smythies wrote: > > > Allow the user to override the default trace buffer memory > > > allocation > > > by adding a command line option to override the default. > > > > > > The patch also: > > > > > > Adds a SIGINT (i.e. CTRL C exit) handler, > > > so that things can be cleaned up before exit. > > > > > > Moves the postion of some other cleanup from after to > > > before the potential "No valid data to plot" exit. > > > > > > Replaces all quit() calls with sys.exit, because > > > quit() is not supposed to be used in scripts. > > > > > > Signed-off-by: Doug Smythies > > > > Srinivas, any comments here? Somehow I missed this email. But looks fine. > > No concerns, so applied. Thanks! >