Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp23736imm; Fri, 25 May 2018 13:28:08 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoazFgX4XbrZJ5f8AgAJxgboueuD6wdL65tLQk6Rwx3O2pQ3YzaSw38WCgbiOvT0Kn/pyFf X-Received: by 2002:a65:6645:: with SMTP id z5-v6mr3165959pgv.43.1527280088500; Fri, 25 May 2018 13:28:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527280088; cv=none; d=google.com; s=arc-20160816; b=qKwwL2suBPD5GQaFQFC8Cf5bSQmQhR6XN1bbrG1fF9qJlAaFf0W88dnvLwgBMWThtw h9xeLQ30HkCsnbYCxDnekj7VqZfJ4DDFGod2IFwu9OW775PXDdOPdVmOKMaeUxn3GmvN 55d0nx7zUYbjVvFe2C6bYCKFmeJEJFu6fYP0KaqMnN3pKtvVhLKBsL583faZRj5fwAwk VOtLhTI1HIA1soybksebcSHFhlRC8RpiHnxZmmVexURt5ncc98OVBpZ43D9dqGH3r9QF RJ25+whygreBYud5MLGbbckIT1tdl0Gzy7ysdqnYltZVBpaYN5FAdRhSPeW+MNlYYhPw j9LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=CVlLILIYzxH3LJhi/UFQ53D/KLO/X7Rbpyn8XdOy0i4=; b=ZX4h1FCIqhuG9IlkYIpe48Q85YjfJ21L/KFy6vDtjY3WhLbXrg+MZ1U4wNzf8fPmIt I2yM27BqOfVmXLXWJzg/N/nWIHojXT4SpCxbJiaZ/FjVwjVrJvUR3v9GARCNV1ndwXnF vBfxRNspOJofOz4ZedVghA+jo1xnrUvn6oBQNqxe/V09usBshPU7IVfiNN/cxeOlt9LK mec36r4R39pXv+qcSxYVKQOv2ug3IAB/+LCcyZplE1r7iWzPiZrkmRGsObBNe4liT+lK XFQlDPaD0fYCgizSqVPzGHi6UMToEQK72HlG3fxc2H/0OfJWpHfBW0b3zrBWgnagjZcq zQIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 34-v6si24727372plz.66.2018.05.25.13.27.53; Fri, 25 May 2018 13:28:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968315AbeEYU1k (ORCPT + 99 others); Fri, 25 May 2018 16:27:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37356 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968175AbeEYU1i (ORCPT ); Fri, 25 May 2018 16:27:38 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D5EA138E87B6; Fri, 25 May 2018 13:27:38 -0700 (PDT) Date: Fri, 25 May 2018 16:27:36 -0400 (EDT) Message-Id: <20180525.162736.1851445273924939030.davem@davemloft.net> To: songliubraving@fb.com Cc: laoar.shao@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] tcp: use data length instead of skb->len in tcp_probe From: David Miller In-Reply-To: <630ED9AE-A932-4B6A-8236-D133CE3E0726@fb.com> References: <1527166097-10908-1-git-send-email-laoar.shao@gmail.com> <630ED9AE-A932-4B6A-8236-D133CE3E0726@fb.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 25 May 2018 13:27:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Song Liu Date: Thu, 24 May 2018 17:44:46 +0000 > We should also rename __entry->length to __entry->data_len, so that whoever > using this field will notice the change. Agreed.