Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Arnd Bergmann <arnd@arndb.de>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin Lau <kafai@fb.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH, net-next 1/2] bpf: btf: avoid -Wreturn-type warning
Thread-Topic: [PATCH, net-next 1/2] bpf: btf: avoid -Wreturn-type warning
Thread-Index: AQHT9HAeHmBMspT3K0mRxe5qBEwilqRA/KeA
Date:   Fri, 25 May 2018 21:53:11 +0000
Message-ID: <97F843D7-7E81-44B3-AE97-112ABFE8E892@fb.com>
References: <20180525213331.2115471-1-arnd@arndb.de>
In-Reply-To: <20180525213331.2115471-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31735B12AA337744AA1A4DF0AE6B59F9@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b38675c-2b01-49d5-c088-08d5c289e8d6
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2018 21:53:11.3614
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1421
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-25_08:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 25, 2018, at 2:33 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>=20
> gcc warns about a noreturn function possibly returning in
> some configurations:
>=20
> kernel/bpf/btf.c: In function 'env_type_is_resolve_sink':
> kernel/bpf/btf.c:729:1: error: control reaches end of non-void function [=
-Werror=3Dreturn-type]
>=20
> Using BUG() instead of BUG_ON() avoids that warning and otherwise
> does the exact same thing.
>=20
> Fixes: eb3f595dab40 ("bpf: btf: Validate type reference")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> kernel/bpf/btf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index 9cbeabb5aca3..2822a0cf4f48 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -749,7 +749,7 @@ static bool env_type_is_resolve_sink(const struct btf=
_verifier_env *env,
> 			!btf_type_is_array(next_type) &&
> 			!btf_type_is_struct(next_type);
> 	default:
> -		BUG_ON(1);
> +		BUG();
> 	}
> }
>=20
> --=20
> 2.9.0
>=20

Acked-by: Song Liu <songliubraving@fb.com>