Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp15882imm; Fri, 25 May 2018 15:03:53 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoBNIXCYhsrUU6nIEOzRN3veAoRNJcg7sHjMYAgKCQgDtPKdQPa+PoCk00+yN1I9yT0gYHs X-Received: by 2002:a17:902:b189:: with SMTP id s9-v6mr4290969plr.352.1527285833638; Fri, 25 May 2018 15:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527285833; cv=none; d=google.com; s=arc-20160816; b=D4TrB6cawC9PxEWFWsSlJvWmgVNMzoIc8vEQHqNNs77WXSLF4DYvculf1vc9j3G6PW jPoVp47jNqQXC05ZP35u09E+upZiy8Mx6qSqXNTlwb9jJpU+wKSyPpkR0gD/L1hsEd62 DFux930qxxEVtazgBjGrxMTXg7nK8wS8HobJ8NYsKoa477Y2LzBA/XpYxFEAIWi1QzkM c9dcv00AcBKH4nBn71YBmZEdmlUzqT/LLlqpT9KaYwp+jBm7u7YbSpPExoYRjSGcFf+I xHEiscABCMFrPWRmLF0KKU4j7l/C0Y2L4QNojWpBF2riHMy/DC5Zfkoe9NXrpQUqWXuo 8vCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=GEVHRWA+I7U/uPYPdhd3Qo9nyqtJEp60t3Enc3KKffg=; b=fDN5SRKxhBYjGSdGwmF7R8UAbjItbzfcG6HdORCcxfKhRKaKi0AE4QT7imO8t3RKev Ya6dZ8dMJspgkWvvT1h+gDe95pnwv06+VexzNzlmwr31IebtAKgHanHTzY1ncP9hN9j3 qpQ01O3pgzOfj3eYavSu9kArDzYKfDgS85Zc6cxT5D2wGqymKiZKzgH29NniD+AnCvHc X1MuoFDKNWMgvuiO6bb1qkxToItrE4ARTDD2kgxms6BEPy1qgOUIlezbBIbXE91AE7Vx uNj85WjQGbvJ5QweUkxdQHS9iky/+P9l0oYZWrH8kaQaQRsS/vcLe/mLxUY6ryOXfF/p Vtng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9-v6si19340116pgv.313.2018.05.25.15.03.38; Fri, 25 May 2018 15:03:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030733AbeEYWCC (ORCPT + 99 others); Fri, 25 May 2018 18:02:02 -0400 Received: from mga18.intel.com ([134.134.136.126]:17944 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030599AbeEYWBD (ORCPT ); Fri, 25 May 2018 18:01:03 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2018 15:01:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,441,1520924400"; d="scan'208";a="231900889" Received: from theros.lm.intel.com ([10.232.112.164]) by fmsmga006.fm.intel.com with ESMTP; 25 May 2018 15:01:01 -0700 From: Ross Zwisler To: Toshi Kani , Mike Snitzer , dm-devel@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, Ross Zwisler , linux-xfs@vger.kernel.org Subject: [PATCH resend 6/7] dm-snap: remove unnecessary direct_access() stub Date: Fri, 25 May 2018 16:00:54 -0600 Message-Id: <20180525220055.18920-7-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180525220055.18920-1-ross.zwisler@linux.intel.com> References: <20180525220055.18920-1-ross.zwisler@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-snap.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 216035be5661..0143b158d52d 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -2305,13 +2305,6 @@ static int origin_map(struct dm_target *ti, struct bio *bio) return do_origin(o->dev, bio); } -static long origin_dax_direct_access(struct dm_target *ti, pgoff_t pgoff, - long nr_pages, void **kaddr, pfn_t *pfn) -{ - DMWARN("device does not support dax."); - return -EIO; -} - /* * Set the target "max_io_len" field to the minimum of all the snapshots' * chunk sizes. @@ -2371,7 +2364,6 @@ static struct target_type origin_target = { .postsuspend = origin_postsuspend, .status = origin_status, .iterate_devices = origin_iterate_devices, - .direct_access = origin_dax_direct_access, }; static struct target_type snapshot_target = { -- 2.14.3