Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp21358imm; Fri, 25 May 2018 15:11:06 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpKULM8UADZMh4kwk5vC2Svi0U6AY644OHGzlSm/jHJVn1BmoD8ecvIFCRdy3ciM8lnHz1A X-Received: by 2002:a17:902:d891:: with SMTP id b17-v6mr4369525plz.0.1527286266684; Fri, 25 May 2018 15:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527286266; cv=none; d=google.com; s=arc-20160816; b=hB1q/CoaRJlyIA5p9FxTUFEKrObAkjg5JOqgSncN5ETgyIIpZYJ3jwyPDFY46Jg5bQ BZvFdoPv7UZvzbWOIuG6CT8NTJWh2Boe8DEAi5O7FcdVIel4NiJgtBSycD7TWgMjJxEA 4OFhC8YkO4AYickaV9T1IfbGPnQjq0pXZH2ABywqMBmA+AIS8DyLsMyE+GmRb60X3jaY k9ICXIqUMr1/1p4Mjzq5xG75uSs50i1vJr+ePITmK7bagSvINOEZJbwwVWY8YPbI785d uXTrXUto4Dlqp7B2ZeF5oWTUP11sGrizpFedrS01WLy1ROqws7w1h5AKNG6BnfohRp8l AQ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=2Z9l5DwSu2r94aOZJJgVWrp1cBanY7cuZ3rAhx/lIQo=; b=bd+itkHbnine7DWw/SUZGPmeMgQAPTYrLOXNV4KV9aCAtXr56+C60+AZrz9cq7hMG6 14W6gsOTe+xFs4X3jU2z3ZdldCH4CSZ/onU+V6h297QekSdISLYIFQWMIChwqf9s1lLj b8gag3pz3luDFK7x2TmtLCGv3jfcin3GNtDfHKQKN02euLm8MF1lLat+CRFLkvYk41ax 9fs7H8zZxtIsjBfAf82oVgytlcE+mV4l7fUeH+nexJa2b7fc0N1z8aaC9iQB1s0vKawD 2qqnyq11wj51K+wve1XKNvN0d+RhX4D9MoOme5ntOTZeFXVlZ8VUZJmUFfWUnsuTrF8j DtEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lrhD/aYI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p91-v6si24674529plb.457.2018.05.25.15.10.51; Fri, 25 May 2018 15:11:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lrhD/aYI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030648AbeEYWKi (ORCPT + 99 others); Fri, 25 May 2018 18:10:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:50746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030505AbeEYWKg (ORCPT ); Fri, 25 May 2018 18:10:36 -0400 Received: from localhost (unknown [69.71.5.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEE5F2086C; Fri, 25 May 2018 22:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527286235; bh=DdTFkr7xhMriTVOyEdkDh6274R7LJp52ieT1JGthWRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lrhD/aYID4dZmTiy33rmr2nVLQ6jb6CgRFBfiYrU1YmNg7VN75klkRkhVnf6D7WcM ZyD2WW69t203bNWnadpJ2EzEJXo3NXhp1RRdTV4Hc7tcN77zEWCvGMqG+txNp/WW6M sSP8+8QNeACbQ30KbT10vo8CIV0zD3AmvyKIifII= Date: Fri, 25 May 2018 17:10:24 -0500 From: Bjorn Helgaas To: Sinan Kaya Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, ryan@finnie.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Bjorn Helgaas , "Rafael J. Wysocki" , Greg Kroah-Hartman , Thomas Gleixner , Kate Stewart , Frederick Lawler , Dongdong Liu , Mika Westerberg , open list , Don Brace , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org Subject: Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown Message-ID: <20180525221024.GC92995@bhelgaas-glaptop.roam.corp.google.com> References: <1527043490-17268-1-git-send-email-okaya@codeaurora.org> <20180523213249.GD150632@bhelgaas-glaptop.roam.corp.google.com> <61f70fd6-52fd-da07-ce73-303f95132131@codeaurora.org> <20180524183502.GB85822@bhelgaas-glaptop.roam.corp.google.com> <984b9734-244d-04e9-946f-7524f148ff7c@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <984b9734-244d-04e9-946f-7524f148ff7c@codeaurora.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote: > On 5/24/2018 2:35 PM, Bjorn Helgaas wrote: > > That sounds like a reasonable idea, and it is definitely another can > > of worms. I looked briefly at some of the .shutdown() cases: > > should we throw it into 4.18 and see what happens? It wouldn't solve this particular problem because hpsa *does* have a .shutdown() method. The problem is that it doesn't work -- it's supposed to stop DMA and interrupts but it apparently doesn't. I think we need to fix hpsa first.