Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp627671imm; Sat, 26 May 2018 07:19:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLhye9p1KBrsytPyCzC2AUX5MpCpccdEA+SN5z4zHjHZRUOwm3RCidPZ169yA/E6EcEgGVj X-Received: by 2002:a63:3807:: with SMTP id f7-v6mr1881998pga.446.1527344391418; Sat, 26 May 2018 07:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527344391; cv=none; d=google.com; s=arc-20160816; b=UMVS6M5OPmEjZIaBMY454ZgPWvYSLDiNrup314JrTYAHmjit11WykftCvERNVYXf8T /87gjdtbAw9U7TYPwEHq3QlNgTjmDao7qPNJ/0J8VoK5mPRFsqkqcfiyjx98uAPAbsyD ILYq+S9yKZOkIo6DWwe04qGTgyykq3LNkPVKy9+a6teHscqGLeugFqIiYMcCyq8BHnou ccw+yff4d+483/YYxrVFrk8XQKijtfI8tWAMnfwyPmeOwVhtqmAK+JvXN5UfbS2zIwF2 TWoJJFn7hoGXF3flQfhAhCcEy9diZZ6eyKh9c2vTm84T0i6qwMXBagn2xtk3GNPsjU4P SOtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=WDE9gykxfaV6coWiLUjT+9folGo2SmrHutyyumabYYY=; b=Ok6w9FxLc2Kgio5Mo3rPAtZblGHYRZUcboBDYTOiNm2QWoKmWVfRaP3MksvZvIh4g4 o4g06drBlfLoqawcw5p/0liMWcUv1NKoZvR9bR7X0H/1xQJvyGeoayOqsJzL9Ob2k2YF FEtMDRUN8LMl+TQMULWo90T9DfgulI+Tf2oi3o6lyrGSStulym/KXrwsabc61LnNs7up ewv8MiyCDFrVE5Z4mH6anBCcn5maxBY7jRoKqgZX6jPvaLsDYbfVI+ghrpn29z+AgtXH bHmOONql8rGYwsQaI94Kg2Apj3hjT/4ZtE7igKh9eXFHtZiE6Pu7gpt0T8y8oeUO9rAx lWKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k191-v6si1743914pgd.19.2018.05.26.07.19.36; Sat, 26 May 2018 07:19:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031764AbeEZOSR (ORCPT + 99 others); Sat, 26 May 2018 10:18:17 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752095AbeEZOSQ (ORCPT ); Sat, 26 May 2018 10:18:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A83E2808255D; Sat, 26 May 2018 14:18:15 +0000 (UTC) Received: from flask (unknown [10.43.2.80]) by smtp.corp.redhat.com (Postfix) with SMTP id 4F95D2026DEF; Sat, 26 May 2018 14:18:12 +0000 (UTC) Received: by flask (sSMTP sendmail emulation); Sat, 26 May 2018 16:18:11 +0200 Date: Sat, 26 May 2018 16:18:11 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Arnd Bergmann Cc: Paolo Bonzini , Lan Tianyu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jim Mattson , Wanpeng Li , David Hildenbrand , Vitaly Kuznetsov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: x86: VMX: fix building without CONFIG_HYPERV Message-ID: <20180526141810.GA23390@flask> References: <20180525153640.3228067-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180525153640.3228067-1-arnd@arndb.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Sat, 26 May 2018 14:18:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Sat, 26 May 2018 14:18:15 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'rkrcmar@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-05-25 17:36+0200, Arnd Bergmann: > The global ms_hyperv variable is part of the hyperv support, so > we get a link error from accessing it in kernels that have this > turned off: > > arch/x86/kvm/vmx.o: In function `alloc_loaded_vmcs': > vmx.c:(.text+0x1654a): undefined reference to `ms_hyperv' > vmx.c:(.text+0x1657a): undefined reference to `ms_hyperv' > > This changes the condition to first check the compile-time > configuration symbol to avoid the link error. > > Fixes: ceef7d10dfb6 ("KVM: x86: VMX: hyper-v: Enlightened MSR-Bitmap support") > Signed-off-by: Arnd Bergmann Queued, thanks.