Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2054121imm; Mon, 28 May 2018 00:15:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoVKgrehSfnCL0eGfMOoNpq638oPK8fmQVZFnEC710fG3OfAQRfGnvB2rE48wQUtO3nHKcC X-Received: by 2002:a62:1549:: with SMTP id 70-v6mr12402366pfv.91.1527491756425; Mon, 28 May 2018 00:15:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527491756; cv=none; d=google.com; s=arc-20160816; b=LRH8n/V6ggudlCZaxa4zHfEMK276gmlq0fZc0bHt+TN4vPhS7FzTlYoFfqukOloL1q +A05U/UqWiFK5JjRRxQSeah6QE9wNHCRuZQJbtGXKQue+iIkg/HBMR91MZSuE/5lueyt cYjeNefgUCaKENajrUdJTrDcelwMBIoDaho0yVEGnnKkooz9Tay3T70JGhcuufMrUi1M bjLrty0I/cJU9AtbC0g/wfgG0IOXbks0xHDn31NzAsfqSGuPLcE1eFuIujXbNeHNvTg7 RGzTkrXAKGHnD8QCWIAObQMvkRC0OtwUM4v0YrlwFBPS7mSoeaxfITYcTdC8P+a5WkkM PauA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=m+ZH1X8Jb/kTp3WGheqO9uNybKBtTZjqWho41BZrazE=; b=B1yrwnWjkqZYQOVo1WwdiPlymEr+61jMO0PX7toIsPZREpVT954xg7ROmEcw7idxSV NYC1rIxP2RPSI6gxmODmlkwhkaZUpUOKoVffZxf6rFORPZx44xWhc2J2Ksm9PH/3vGuR 6S62RaHYp9Hjw+KGmLlC7mShol9FzGpPZrjdoTUIyIMcNvbyk20v0ER4Nj6QXmoFcyFG 2RJFsGYdZ+ucQy3bDpJ/Ga8cCdOGflkzpQwD2ZduDr3FrQqbtG05Rtx+Hl0xng4jLf0J N3pohwb5N9Va+e/Z+GQ1+lHoxwHfpgldZKuKI1hZP4oDn3XUoxfuVnh/BA3mArckdhN5 fhfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=cMlLa3bN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4-v6si2333344pgq.454.2018.05.28.00.15.41; Mon, 28 May 2018 00:15:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=cMlLa3bN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbeE1HP2 (ORCPT + 99 others); Mon, 28 May 2018 03:15:28 -0400 Received: from merlin.infradead.org ([205.233.59.134]:38520 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbeE1HP1 (ORCPT ); Mon, 28 May 2018 03:15:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=m+ZH1X8Jb/kTp3WGheqO9uNybKBtTZjqWho41BZrazE=; b=cMlLa3bNEoWKj2wXK5A78fHBF 9Ts27WQ1tkXWVBvgcvVjvbu8zWIco1SwXVSvw2YAjWPi+LeOMOHivViuFEt4H3sy/SMVHGBDorthu ItKezHXghTlz+ppBCVB8IpVGuCgsXd3gPKDdgtQpUd+E1RK0YLehctYuCTzsVZOQFdf8B9yodCFbl yLDLb5akNhFd3OzgyAv4/L4q/r9NJYUSv/D9EqH5oo/+onjptm6FmIwQN+82JstKTiAROKQjvKfbl f4hBhzLhw04aa7qPMBgflL7qqfkmU0GeAwd4d1K51PrzuuO2UynNd7Hp4Y4h76VjtSEOdjeG3JZaU IZB4vHdag==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNCN7-00059i-Eu; Mon, 28 May 2018 07:15:13 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BE0A72029F1CA; Mon, 28 May 2018 09:15:08 +0200 (CEST) Date: Mon, 28 May 2018 09:15:08 +0200 From: Peter Zijlstra To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, "Joel Fernandes (Google)" , Dietmar Eggemann , Morten Ramussen , Ingo Molnar , Juri Lelli , Vincent Guittot , Patrick Bellasi , Rohit Jain , kernel-team@android.com Subject: Re: [PATCH v2] sched: Remove obscure comment from select_task_rq_fair Message-ID: <20180528071508.GS12180@hirez.programming.kicks-ass.net> References: <20180528012447.115411-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180528012447.115411-1-joel@joelfernandes.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 27, 2018 at 06:24:47PM -0700, Joel Fernandes (Google) wrote: > This patch removes the obscure comment which was > saying this path can be entered only for wake-balance. The comment was meant to ask if we want to always do select_idle_siblings() and not only on wakeups.