Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2112248imm; Mon, 28 May 2018 01:45:43 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq71hdHF2ZK6Nwzlk7ShofRiV1cG2+Wy+8CBBfy4wYYnDXS4lvw6Baagq4OXaoFVW7KoYKJ X-Received: by 2002:a17:902:9a08:: with SMTP id v8-v6mr12717685plp.148.1527497143015; Mon, 28 May 2018 01:45:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527497142; cv=none; d=google.com; s=arc-20160816; b=CsFEnc6+muO8Mu0ltC6wWycXZGX2M2U7Lvw9B/Y+iJH1oaaNBoRRoN5faZyeRYjTDF ky2fCmV9RIFjFIP/vrgPV2lMeDtcZCgIqPji1fPYJ6jGv7lYZCowTdAFYY/666WdKtnT VUZE9UpXO8TLY5NZ/rL68h7U3423wfg3IBMZm9ULPTXc+SIeRYgUs4SvaZXdKOeoABKJ W/2WhuNUM3BI1OTNDYlIvH+ZMuPCaxBCsrybSHo9aqP2vyv5brpV/zk/ua03J4tu1izp 2KZ5GiobToksYDmCAQURqiDQlKOrp2jjLkQQuXiie3J/2i9Pl+61Fs5luKhg/pOxf56J bc0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=OLCcfZcxUEvo4vFLTZ2B7IzF4NUGUmc0tI7PVefgSxk=; b=YTXPitvyfrWexZko0yBLbmNOwSbMHPXfzFEn6eJwfb014HHzAJ/SfHRHD8kqCo1GkN fVTNNreyr+N4LhSl2CsEZlJ4xvMNE1UHAB6NZ2cbZo3gyaeEJb6L6YfGgLZ4EK7GQLWL 7U1wFTBsPGvQwHb4Rs+3Nl+KNbRVGw5lsyiwbjw1aMQaGpnoUl00V0KmHhLbgUwTShWy QneubHBj0lLjGEYZcb+WYqcyug+lWmij8Z9uAchxI4VrZOdYVnfDn2DOjY41UJKKsfvl pEgZKAHr9BogeTU4d7uvgDS9r9hQyEvggXpt9rg2ZCKtboovMz/1PoMb2CjBwA5U5ws6 wBog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19-v6si29873692pfn.241.2018.05.28.01.45.28; Mon, 28 May 2018 01:45:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbeE1Iou (ORCPT + 99 others); Mon, 28 May 2018 04:44:50 -0400 Received: from mail.bootlin.com ([62.4.15.54]:37780 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754043AbeE1Ios (ORCPT ); Mon, 28 May 2018 04:44:48 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 7A40920750; Mon, 28 May 2018 10:44:46 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 4AC8520719; Mon, 28 May 2018 10:44:46 +0200 (CEST) Date: Mon, 28 May 2018 10:44:46 +0200 From: Maxime Ripard To: Viresh Kumar Cc: arm@kernel.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs Message-ID: <20180528084446.g24fphqqac2hi3rr@flea> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l4dcsg23dumy77y5" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --l4dcsg23dumy77y5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 25, 2018 at 04:01:52PM +0530, Viresh Kumar wrote: > The cooling device properties, like "#cooling-cells" and > "dynamic-power-coefficient", should either be present for all the CPUs > of a cluster or none. If these are present only for a subset of CPUs of > a cluster then things will start falling apart as soon as the CPUs are > brought online in a different order. For example, this will happen > because the operating system looks for such properties in the CPU node > it is trying to bring up, so that it can register a cooling device. >=20 > Add such missing properties. >=20 > Fix other missing properties (clocks, OPP, clock latency) as well to > make it all work. >=20 > Signed-off-by: Viresh Kumar The prefix should be sunxi and not sun, but it looks good to me otherwise. Let me know what your preferred merge method is. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --l4dcsg23dumy77y5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlsLwX0ACgkQ0rTAlCFN r3RTFw/+LvuG8dQ9Ks/IdzZIq1rc1Nx/wOZ/ZXEjoSkAkGSNsZ8ybTgBgxcEbyiS mPRsoPKw2tF/nYdZfk31GzDoCTns64e/xuqdH5rKS+Dtu0h3NCsYY/8Nky6pHdfX Shbksby8TlVEu/1YYraB/l+xrSzUqGnz5OHVGcYhc5qhzE9jqgvrVyFt8JWRqhPT FlDKYHGox+fpqdEannhvPl2maPoT4Ox9b3ZNKihGQv5Ag/uUN2VpXUnjGI7AvSjY DLEcyU/4yyFkfX7NGWz5opWurePWAzwI2KRUO3SjDkXlawpmz5Mi1a0nZALcvsaG y85hxZypa354XEtWe2bQJQWBDLdeWzvHar9Y3H157BxwthyLuH/ZzCqDt1eThrxN b5fGm2uqyr/hHxWNjMtq/6exMvXD3E6zufZ3PhbW5BmqCKEIIPxLapRsu6Jsxb0Q G39zc6N9ml0qTPqJ5JDgPDoDxI1+pTN8BBV89mgVNlqcyX6e9xehU+y7Kgx0XrJL CMYlBAENIYosOWqdO2ZlxmkC03rRq+A4ZCvMbFhtc93VXT3ZQZxfHnJaX/m2HUK9 253UeU18vFs4SyUvwgFgU5QicpNqdzei+3/KV5c32frHZVZKgoSyswjjKcf7dnBG Bh+f3PvRXXgrE060DyqzNVBjrTEYKm9J3ImdjMlL8kpSivuF6Lw= =zAUF -----END PGP SIGNATURE----- --l4dcsg23dumy77y5--