Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2174690imm; Mon, 28 May 2018 03:14:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoE5TQWw1A6i4YLPiV1rT2pcO+cGuyA9NvLJ5SmD65Xg4yhu2PkRR9v7MH3Jkv0CiebHxTw X-Received: by 2002:a17:902:7e05:: with SMTP id b5-v6mr12777482plm.230.1527502457438; Mon, 28 May 2018 03:14:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527502457; cv=none; d=google.com; s=arc-20160816; b=EaoLx6Gg6Idnh6mTIBf2aW4oBZ16z8bcZ5zo7yMST4rFujFQRRdmIz8+PhDUaF3RlY reZ1mZpLIsIK4nG+r9AqcDqBH6+FvwipZrufv6nwNjP4rzQOutT8lof3gTUjO4PVx/hd AE6nNUJ9ROh3/5Q8XdEdnBJNaaKbELp2PEuJ6W4uNJC8wNyyUxMrOxCgQDwUDh07XzeP bFrcqjMflx5rphax8s2psFtGd39tRLcs1wlNXVw6EYHbwznV/+DvgmTTpq5o1mqlZr16 ueDitkcbJs3sVF5ekVkXByzvmYZGGZCJKEHrrUa/eSCwL5DNoVmoRhFMpfi1y7CQvQ+9 jmgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Dcw3w9DMSk5xa/en78KbArXkgu3Oxj1QIzgDzG6Hr9M=; b=eKlY4keztZiiTshXrs8F0VV7OWotKdmgldfRXlWQbQ/NVnH5qtwDw2MO3qTsBmptEy mk0vkvePdREBJu/TVue5mjv2s6Dy71jGvXdttQmdXN4cuPDk9ujTHVhHOt/8JFEhX9kP loGfwxoRs1Cn65wcqQcRaIhMgvLoQ0Qjxyi2wk2tDFHGpDz8mfDJY9UeTQsGhB1kwOVb sQwsVvLtM5Xx3j+6+UTRFMssspNp+dFdvUi6JLurPdB2nI5JI2h1Xm/4yTK2w8ps4B1b S2Pi089QGrvqZ1WKUNiRL3a87CKly5L7ZgBYKWe9IcqYBOgdEv6xUp3HfUi78vqxSMKG pkyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZX3xu0L+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q84-v6si24124116pgq.91.2018.05.28.03.14.02; Mon, 28 May 2018 03:14:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZX3xu0L+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936752AbeE1KNu (ORCPT + 99 others); Mon, 28 May 2018 06:13:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:33548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936810AbeE1KNn (ORCPT ); Mon, 28 May 2018 06:13:43 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EFE0B20843; Mon, 28 May 2018 10:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527502423; bh=SFCNI0oIbYc/Af9JYIWjz8U7qIJktrHaQU7s+VtTeQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZX3xu0L+mAkFunivzRspzzPvXakW41Pb6AbGljZyQzFwZ3gV2k8Sdq+im45ZH4opx 5Q25ztGZkmNIjZpWOMO1KZI1wjk3SyD2x35R6fMnYFrOT2++UDSHXJsM8L1FLHaNma n41KGWaNW6TR5ttW3zRux1Zz/1bYSm1JFnZKUzFA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dick Kennedy , James Smart , Hannes Reinecke , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 3.18 181/185] scsi: lpfc: Fix issue_lip if link is disabled Date: Mon, 28 May 2018 12:03:42 +0200 Message-Id: <20180528100116.414200144@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100050.700971285@linuxfoundation.org> References: <20180528100050.700971285@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Smart [ Upstream commit 2289e9598dde9705400559ca2606fb8c145c34f0 ] The driver ignored checks on whether the link should be kept administratively down after a link bounce. Correct the checks. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/lpfc/lpfc_attr.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -629,7 +629,12 @@ lpfc_issue_lip(struct Scsi_Host *shost) LPFC_MBOXQ_t *pmboxq; int mbxstatus = MBXERR_ERROR; + /* + * If the link is offline, disabled or BLOCK_MGMT_IO + * it doesn't make any sense to allow issue_lip + */ if ((vport->fc_flag & FC_OFFLINE_MODE) || + (phba->hba_flag & LINK_DISABLED) || (phba->sli.sli_flag & LPFC_BLOCK_MGMT_IO)) return -EPERM;