Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261331AbTICBDU (ORCPT ); Tue, 2 Sep 2003 21:03:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261447AbTICBDT (ORCPT ); Tue, 2 Sep 2003 21:03:19 -0400 Received: from dp.samba.org ([66.70.73.150]:36283 "EHLO lists.samba.org") by vger.kernel.org with ESMTP id S261331AbTICBDS (ORCPT ); Tue, 2 Sep 2003 21:03:18 -0400 From: Rusty Russell To: Hugh Dickins Cc: Jamie Lokier , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Futex non-page-pinning fix In-reply-to: Your message of "Tue, 02 Sep 2003 04:23:24 +0100." Date: Wed, 03 Sep 2003 09:58:06 +1000 Message-Id: <20030903010318.18D972C100@lists.samba.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 36 In message you write: > On Mon, 1 Sep 2003, Hugh Dickins wrote: > > > > 5. If you're not doing anything in __remove_from_page_cache (rightly > > trying to avoid hotpath), you do need to futex_rehash in mm/swap_state.c > > __delete_from_swap_cache (last time I did say without the __s, but that > > would miss an instance you need to catch). That will handle the swapoff > > case amongst others. > > Of course, the reason I originally said without the __s, was because > move_from_swap_cache uses __delete_from_swap_cache, and we don't want > interference there. So best convert that to use __remove_from_page_cache > instead, with INC_CACHE_INFO(del_total) outside the locking, after the > set_page_dirty: would improve symmetry between move_from_ and move_to_. But you previously said: Message-ID: > 2. Please leave mm/swap_state.c's move_to_swap_cache and move_from_swap_ > cache out of it. I already explained how those are for tmpfs files, and > it's only the file mapping and index you need to worry about, you won't > see a such page while it's assigned to swapper_space. If you're anxious > to show that you've visited everywhere that modifies page->mapping, then > add a comment or BUG, but not code which could mislead people into > thinking futexes really need to be rehashed there. Confused, Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/