Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2202959imm; Mon, 28 May 2018 03:52:35 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpWDosQFbZhelfwM8cuq15cZ6Zb9ztJp6/gqq5EXaayIVbW0rsvJbos0lBaYsfFnDedt1Gu X-Received: by 2002:a63:7f15:: with SMTP id a21-v6mr10160620pgd.21.1527504755229; Mon, 28 May 2018 03:52:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527504755; cv=none; d=google.com; s=arc-20160816; b=vSjXOgZzgUCPklsNQNLaxZ5NMp/M9DkZovUUlwHVMswgF2HXTWF+ibZgS8ch5WUz4G rigZk9ZwFO/WZVUA9xEt9U2zjSQ/XN/dUEUs73/eHtmEYqWnC8RFh71HwIyF7omvIuAp uKVNI+m+08u04T3QVm+sA4YvOs+NncBb0wYL5qTDimtONEeNWWiYQ69nhA6T2VBV6dRc YQrz9DfEpHl7zkxKJvuAwg/t+yzIJnsMhp4kk+FBnaNfcY8H8PPPBfApLFf22fUMyqk5 5C8RXpKrynJlnJw4MNsK6rtpBZKYg3v8AtHwDm0MdJkICZEun7CljfSJkqAwE//9nZDX JIkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=45ZPyLPqms/40eDvXdqBzYG3xMnsXZ6OaPV1HkGVo6w=; b=hY6gVg0koJc6HGhvY28geoF8ZsI/2B0tmT+UCp34mbpGezV/HZGKdr0O7r9Tov+pMJ +uoK59QeJCuZy43Kq3Byn2h/CJ7KqIfcZz3+gfd+SC3B8ihX+0H2ZX2v55COvaB72E9k rCpwEJoR7tBGZlEsk826I52sa1QwuEg+eKAgUQBk+G6l7ysFOwyPpg1FDCVxaE6hEJ1U Rv4LMG5zABS82fHbDXq9t9FRSGZv7CINb/AtwY/pcnWVZdFfSiX/Y1VO9Q80NG3U7Moe I1amQ9HGjskhISXRVE6lRMZ9n62fyqzf1ecjLeugMVhsikpbZK8hPIE0zRj5WpDepUF1 +LnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0Ju+OS4k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y90-v6si3032322pfd.47.2018.05.28.03.51.50; Mon, 28 May 2018 03:52:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0Ju+OS4k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163873AbeE1Kvp (ORCPT + 99 others); Mon, 28 May 2018 06:51:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163823AbeE1Kvh (ORCPT ); Mon, 28 May 2018 06:51:37 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 250DC206B7; Mon, 28 May 2018 10:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527504696; bh=Cb5eDj4JnLvPx8SOa0CeopuJ40GShpcEL7jls1oaz2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0Ju+OS4kz9x3esdf90nbvB2LH1yFdwSIGoVsT0q8CVAZLX+TjaIWsuhLg2wsedZTp qOLalu1+qqzS8ugMJyueYiaUUFmpJO3vB4K0fVyJQoSw+dmN030KH2TFSi6ZYo2aOr LdNCzza3lkQeh67Q1Cj+S7lq2ocy3P1OezlYud5g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ganesh Goudar , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 231/496] cxgb4: do not set needs_free_netdev for mgmt devs Date: Mon, 28 May 2018 12:00:16 +0200 Message-Id: <20180528100329.635379207@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100319.498712256@linuxfoundation.org> References: <20180528100319.498712256@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ganesh Goudar [ Upstream commit b06ef18a4c255609388ed6e068a1c69c797545e0 ] Do not set 'needs_free_netdev' as we do call free_netdev for mgmt net devices, doing both hits BUG_ON. Signed-off-by: Ganesh Goudar Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -4679,7 +4679,6 @@ static void dummy_setup(struct net_devic /* Initialize the device structure. */ dev->netdev_ops = &cxgb4_mgmt_netdev_ops; dev->ethtool_ops = &cxgb4_mgmt_ethtool_ops; - dev->needs_free_netdev = true; } static int config_mgmt_dev(struct pci_dev *pdev)