Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2208139imm; Mon, 28 May 2018 04:00:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJxzI/oIw+6tV+jebAEAnMq4Y4nFh8ATHUMEb1t63iJIUHsKkZpi9DDkg6GY65NiR2Y78wB X-Received: by 2002:a63:aa4c:: with SMTP id x12-v6mr3215590pgo.387.1527505207335; Mon, 28 May 2018 04:00:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527505207; cv=none; d=google.com; s=arc-20160816; b=qDHmSJI35R3Jlv/dSbJ9zb+eGz1qrqX4wCx8TISjAOMuf8CrgLnELFXTsAviJ6x7/G b8JYhDNLwdLjiClzmIQayLwV47bb3FCxdPJzJOpsyooiqzb8w4aSgaUV2JoiqU7iZl4+ 5kt0nyWm/EUUBuibBaxILw+xdMgwep17x4K9xWrHD6C5zK+oYNLE1YFQOOdn4q0p8Rhl EFXlvj+IEdfEoM9LYh9C2RorEdBvU/iU17goCIT4SYixWoC10wn1fwBhJFY2RHRBhL+V 8JrWsWj21pT6Mz2gZFaz6tT8o/KfJbgBKEr6oOn+M4QGLDQyvup4msVgdh8dS2C0nwqD NSTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=aNSxc8aEWnJbTV09+LrWjptaN9etQXQCbkYzLeroLPs=; b=sODUn9NqTwiTMz1qSfkSgiCXdycM4j165hILop/4SgevGlU26Z2deo4M5tcl6ckbVE t1iV+g4G+Cyj/VHzOglgBjS9r061u9ZyTST+5CX/JtqIUOOtKJMOhM2XXuO0nIPseDFd eG131KCur0w2v/a4m0EYmPBms6qTAaf2PUf/Z3GT93bcn83a5meDXbqc+HtTqGSOoVHh TVNwXwXw8/9y68CpGtursJkNK1+FmLV6E424B1pkA4ySo3PY143WuF5IDqcEO8LVkhpU e9oaJC7lAjn4BPEOFGqufVyUgdf+zf6rPx9yi+pjTWRXQ+BEP8iQxuDyqlx8hSMk0VVs Y+fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kljyY86K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r15-v6si5573855pgn.498.2018.05.28.03.59.52; Mon, 28 May 2018 04:00:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kljyY86K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938050AbeE1K6m (ORCPT + 99 others); Mon, 28 May 2018 06:58:42 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:41694 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938038AbeE1K6e (ORCPT ); Mon, 28 May 2018 06:58:34 -0400 Received: by mail-pl0-f65.google.com with SMTP id az12-v6so7026424plb.8 for ; Mon, 28 May 2018 03:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aNSxc8aEWnJbTV09+LrWjptaN9etQXQCbkYzLeroLPs=; b=kljyY86KJnBylZqnpAbvrAsCOjOi5jUyt14AG9CFAOlRLPJeQ71JvVouZ3uGB8Ld/z aaS3eWf6gu+y0o96KmPgaiH2UUWaDVHkSSEgFDrP3HpHd2M43bbyco6yXix65gQ5o/2j odmoEGYv9EpIkyxziwitNes2SEOsaBirKqJvg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aNSxc8aEWnJbTV09+LrWjptaN9etQXQCbkYzLeroLPs=; b=Qp5YLz2NWoLoVO/BwciwMJRLEAT0ZM6l/vW9abI9UXSHyeDfBdmx3d2KeEE2qFa2s+ aRp8C2ilDhww8g7enUX5FAbaPTthkConsw6xcOQmKMnd78eDjGfV6RfiJgPOYHqGREg3 ada1siGDvF3bMmFDo2VJBIGBMdFEBDDjMNlKOyeIS6SFMp8+nsUm0YgR4z19Xb3pyOw8 alCn1luqXlJLlaOt81PaJ1Sir4qKE/ecgS9ULMGWWYlPF6RCdAhB+Knky3DfaWR0wCbu PDDMqOsq9J5hOI5Lj4BXHN2ggdE+RJZWZTUdj+ljVaplHxKVmcWRHF9VXQDgaV0P3jRq qYfA== X-Gm-Message-State: ALKqPwchAA5JIjOlDZd0kkUWXSgaUttvtwEWiBX3eq4Vw0hrUd7y+l70 P4cxu2Nnn5B4nVTnvFqWcGxoJA== X-Received: by 2002:a17:902:2924:: with SMTP id g33-v6mr13318384plb.26.1527505113768; Mon, 28 May 2018 03:58:33 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id m5-v6sm19363495pfa.93.2018.05.28.03.58.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 May 2018 03:58:33 -0700 (PDT) Date: Mon, 28 May 2018 16:28:31 +0530 From: Viresh Kumar To: Simon Horman Cc: arm@kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das Subject: Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs Message-ID: <20180528105831.vesrswazlagynemq@vireshk-i7> References: <5821a6dbe413b5a217ca1e24ddf8ebfa63ba6ef0.1527244201.git.viresh.kumar@linaro.org> <20180528092331.3jon45nsqfdzs5ds@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180528092331.3jon45nsqfdzs5ds@verge.net.au> User-Agent: NeoMutt/20180323-120-3dd1ac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-05-18, 11:23, Simon Horman wrote: > [Cc Biju Das] > > On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote: > > The OPP properties, like "operating-points", should either be present > > for all the CPUs of a cluster or none. If these are present only for a > > subset of CPUs of a cluster then things will start falling apart as soon > > as the CPUs are brought online in a different order. For example, this > > will happen because the operating system looks for such properties in > > the CPU node it is trying to bring up, so that it can create an OPP > > table. > > > > Add such missing properties. > > > > Fix other missing property (clock latency) as well to make it all > > work. > > > > Signed-off-by: Viresh Kumar > > Thanks, this looks good to me and it looks like it should have: > > Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency scaling") Sure. Will you be picking this patch directly and send it part of your pull request ? Maybe add Fixes tag then only ? -- viresh