Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2225889imm; Mon, 28 May 2018 04:18:35 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoQ1gGs7Df0sx+7bnkS2QIPP0XFdhZwpbuAsbBm01HYGqRLoU+LniYYAGV88CGs6EPnUgm7 X-Received: by 2002:a62:d751:: with SMTP id v17-v6mr13055653pfl.39.1527506315233; Mon, 28 May 2018 04:18:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527506315; cv=none; d=google.com; s=arc-20160816; b=p7yP30mtMf/H+PuuiYKMxypoMmoleSyWlh2tPTHQl3aWLNC088ZHmhczGnVCeDcvkv PjwTFDiI4BHAEXTQylthK8PNzpDnPig1OMOvbXCJx22DAJwt+AW3BLSpqe1OBjyaBRL6 +BAzNIHPxKdMda5dNm9skNF//nCw/h//Hdug9xgK2Vu2Ek5hBQ3vu0Kg/zyE6qcqi8lg /Z1JLaF0rNRdJnL6Vujqcvbcfh3jFG/+7p9MsxhuHNEiXnT8J5dzPPcUpmn0YHsOdL5c bJuY88+BQGbVTvDBT2qqcAnQNdUyoEs1uTsDQkw5hbgCO0xz9Jk41zzCqjZGlojLsrrt 08Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=1lzjCtq3hPbWhQtucB4547wq58XEbBiXxZYuz5svPsg=; b=fWtgdBfFqa6THpKMhiMjFxSLSSys1yw6HMVa0YrTwmwYX8TEyZqVWm7HgDYOLEg0MU RPw705xCw+E5y1/NfTi4HJh9Bv0NwXtikgMhvsC46x7muwYteb71KX3WuN8e+7QLSOSD wMDKxi79OirZ1JJshu4ygCR+8SMT3nNBTvaDvPzODks6UBEIyDn8JXuM4umisRv/7O8b DjEShdkeWqj+SCxdzUecogvx04dNs8DpciqjkDpurOPJnZvwVwZY6NAFKHzL359/uS9n xeY5emLfaoevccqO7fkts7x6sDuONwqJDSvzcBq+9HreIepNLGdThUFebI2m7AU7CKDF CSLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1dtLg5/p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p73-v6si29783469pfk.275.2018.05.28.04.18.20; Mon, 28 May 2018 04:18:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1dtLg5/p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424706AbeE1LQf (ORCPT + 99 others); Mon, 28 May 2018 07:16:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:35448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424670AbeE1LQb (ORCPT ); Mon, 28 May 2018 07:16:31 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 86C5C2088E; Mon, 28 May 2018 11:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527506191; bh=oiJWG6Dq7JMiCyt4faVKd5bnndW9G6fRlrKqeN6on8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1dtLg5/pu2r94tt8as/pGATnzyMfucYqRp/AoAE/6WTR3oKiIybcFIKUUGogLhZ0e t+BrMIMFtR+zjvYW7M3TBaBzwyWFLergtqluRnPJWSdIuBFapjpYs6bHkDhzgMdrKf 9U/EQ7pRyf2IpViqp60S8vkGB7Odjuu/L2a3fLkg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Florian Fainelli , Herbert Xu , Sasha Levin Subject: [PATCH 4.16 238/272] hwrng: bcm2835 - Handle deferred clock properly Date: Mon, 28 May 2018 12:04:31 +0200 Message-Id: <20180528100300.334492143@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100240.256525891@linuxfoundation.org> References: <20180528100240.256525891@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren [ Upstream commit 7b4c5d30d0bd2b22c09d4d993a76e0973a873891 ] In case the probe of the clock is deferred, we would assume it is optional. This is wrong, so defer the probe of this driver until the clock is available. Fixes: 791af4f4907a ("hwrng: bcm2835 - Manage an optional clock") Signed-off-by: Stefan Wahren Acked-by: Florian Fainelli Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/char/hw_random/bcm2835-rng.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/char/hw_random/bcm2835-rng.c +++ b/drivers/char/hw_random/bcm2835-rng.c @@ -163,6 +163,8 @@ static int bcm2835_rng_probe(struct plat /* Clock is optional on most platforms */ priv->clk = devm_clk_get(dev, NULL); + if (IS_ERR(priv->clk) && PTR_ERR(priv->clk) == -EPROBE_DEFER) + return -EPROBE_DEFER; priv->rng.name = pdev->name; priv->rng.init = bcm2835_rng_init;