Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2312379imm; Mon, 28 May 2018 05:54:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpdf4eDfZZSgAq9rQ4KXCoUGmmB+CnIiC1VoLU+2es8j2rWzicNfTQS2KMnvCZrirSvScYs X-Received: by 2002:a62:1e02:: with SMTP id e2-v6mr13467453pfe.212.1527512074081; Mon, 28 May 2018 05:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527512074; cv=none; d=google.com; s=arc-20160816; b=pKHR5y2Tv6TgbDNCgBZFM98NrfNWWT7QHmBwssI+tBuBJhURl2bDV0M3QwXqHIgEqo Tc7WJZkU7C+khJdcIfBGomWXai/JFalsIe2JQQz+U+Cn/dH4FtU8VN/rnKiLOxYdK9c2 aAvSgpS9HpDgYTB4isivLJ3RhW3EO5RRv8sDyei5OnU7+xW4quL6gUFMRrOF7D56F+qh 3fWy8MuHjNV4/dioG8NlecaA6IntjrIQr9ftiOJOfJ9O+t/7qiCn/osNkRbr64e6Mq8c uhN1c/gsLNq0sXtsUYrfXl3tERZfZBMcMZXIDnF++lzuUx3nE2AdA317Pm3bwnkKVezV QBhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=ZI0tG+iIqWeGunxtt2Ns5q/VgsYJaTjp3uXtiIPAU5w=; b=LZPbdx8vXKWqUeUmrrjfrJwQUpPNadVc/cxeX2RKnHfYVv207OhxoPjFjOYlh+Vcy1 KYNuFxcAjtkaxNZtVq7yCumCqTpcrW1BhqhCz50m9Gy3rCyeuizqABb7oSbCPS8MLxkR y+f9RHbSBFRpIjrjrjpk6JOpo51f/oOeyd4Q2fGQCqnWO0kdZ+AMYl2szs9m3NUwcQPD WvrW9A6U9TOwEqM3DWiiqkCxFXRj7fY8uuJY8X46j2HENe03FKgNuiQopJmcgPZmVBR6 GjwHaqVe3SZYuke55maoN1VaaGlVf4CqnQnz63rAYGw9T0zn1HHfQBYTth/ywFVs3ZL5 SJlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zsDpaIrv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s88-v6si29664255pfa.339.2018.05.28.05.54.19; Mon, 28 May 2018 05:54:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zsDpaIrv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165057AbeE1Mxe (ORCPT + 99 others); Mon, 28 May 2018 08:53:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:44064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164369AbeE1Kza (ORCPT ); Mon, 28 May 2018 06:55:30 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCCF620883; Mon, 28 May 2018 10:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527504929; bh=TlXha+KpdFX8VTVFxhadtI+Q5uoYyNk2YqMT053AHPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zsDpaIrvJwkP+QYZosg/qdSgs3bIuVmh3WDWyBFqsWZ7qDs+WAIPmOPHsBIHPu529 D6wPnA47KjX06FRlXdwXuL/8tPoVQqXiVQPIfJbGJth2Q43Kp1BH2KNTMBdQcUPUcs dEjBJ1JwYSd4owUGshzRPIqS98CI1LxnlRrfqV+s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephen Hemminger , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 312/496] hv_netvsc: enable multicast if necessary Date: Mon, 28 May 2018 12:01:37 +0200 Message-Id: <20180528100332.971270788@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100319.498712256@linuxfoundation.org> References: <20180528100319.498712256@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephen Hemminger [ Upstream commit f03dbb06dc380274e351ca4b1ee1587ed4529e62 ] My recent change to netvsc drive in how receive flags are handled broke multicast. The Hyper-v/Azure virtual interface there is not a multicast filter list, filtering is only all or none. The driver must enable all multicast if any multicast address is present. Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast") Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/hyperv/rndis_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -856,7 +856,7 @@ static void rndis_set_multicast(struct w if (flags & IFF_PROMISC) { filter = NDIS_PACKET_TYPE_PROMISCUOUS; } else { - if (flags & IFF_ALLMULTI) + if (!netdev_mc_empty(rdev->ndev) || (flags & IFF_ALLMULTI)) filter |= NDIS_PACKET_TYPE_ALL_MULTICAST; if (flags & IFF_BROADCAST) filter |= NDIS_PACKET_TYPE_BROADCAST;