Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2334684imm; Mon, 28 May 2018 06:15:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrHUbc0xtLbvi2F2N7r/VKrF2j2x6PRgXwPgg3rjm4CwRdRpMl5n614mVlAHhRpUqffrijL X-Received: by 2002:a62:a6ce:: with SMTP id r75-v6mr13590428pfl.82.1527513348100; Mon, 28 May 2018 06:15:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527513348; cv=none; d=google.com; s=arc-20160816; b=RqyBJUc8/PgvOinrRcHPjTF+D7v7WSMcwwYtDWpIu+K0+abcpEKHz5S+SGUcJ2jLEd vPa9sD9fq2WbILI1XwAqfuOw+TJiKXsqgx2nCgza9tLKyJuCtoIAVD7xcvZPltyYixF0 solRPhKLmqZBP54T9krlfnLCMK8g6T1QhQVIs9iZN1ePn+5Wn6Z8Sc4i6liBUfLOToTd sxKuUcLFAYnVYUidcc0+Crgy8dkroOv74wELXBtf+tr1Lxcvnco382TbKa3sUcnx31xa 9SfFM90duKjLcGYnfV3FU69/ptOFq1gIiHRdwSXmqhRyEtcVc0+VBweGfdlB2lm7UYIS HCeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=WIJcbqfI2xZJFQGJqPQH9kg9UVhlCMaA7c+tjBHpy2o=; b=qlTDFy22r8nCkyNkoJXuVW8qkenZHjLFioQTKI0p6DV904OUinD7FcK88vafDthIQf ofQjaMHZh4Dzea9S+xLjkVc/yFLdvwmHXFZm/VzFMaZi2jwAFzFfMaZxZVBEO2ZR2N/X C0cllwlEU+JC40J7QIFRKqj2CfdgIBNyadAoqhvC6+XwAbx/lVJXIUIePTYOObX3xYoV hz9Wr33EmILncPFfSYmINHIgsnFbGTE8mc+wqrLeEB7DaWX7E0xOxMFWlIGVdbRGGXn4 fEgfyXUNMZr/2iKX/0UWEq/pSc/HN5J0y1+QQmbrFd+bCMLF8mIojkBQai715eOUodVG KhMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xMsK+kLt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6-v6si23140591pgv.420.2018.05.28.06.15.33; Mon, 28 May 2018 06:15:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xMsK+kLt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163673AbeE1Ku1 (ORCPT + 99 others); Mon, 28 May 2018 06:50:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163605AbeE1KuS (ORCPT ); Mon, 28 May 2018 06:50:18 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23D5120899; Mon, 28 May 2018 10:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527504617; bh=KCtji3h7imCUNBKKq46TGnrDBVYLCmXsALmdQbqWhVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xMsK+kLtkwKo1oM7PNFc/rmlFDjHr1MaB4UMt8AWPnH0M6Ycd32os4+7WL7VcVNQX tPZVgHPPBLalAriVJlA9YqH9UHoYWb857a80Sbd4UOFPq4X82X+VcmL07E74FmdKa0 nJumIross0GhRww1SM60Okg3SaElFiY2H3xtJsTo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ido Schimmel , David Ahern , Jiri Pirko , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 176/496] mlxsw: spectrum: Treat IPv6 unregistered multicast as broadcast Date: Mon, 28 May 2018 11:59:21 +0200 Message-Id: <20180528100327.289997278@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100319.498712256@linuxfoundation.org> References: <20180528100319.498712256@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ido Schimmel [ Upstream commit 9d45deb04c59b628b21fc5014aff4f9a1d38f969 ] When multicast snooping is enabled, the Linux bridge resorts to flooding unregistered multicast packets to all ports only in case it did not detect a querier in the network. The above condition is not reflected to underlying drivers, which is especially problematic in IPv6 environments, as multicast snooping is enabled by default and since neighbour solicitation packets might be treated as unregistered multicast packets in case there is no corresponding MDB entry. Until the Linux bridge reflects its querier state to underlying drivers, simply treat unregistered multicast packets as broadcast and allow them to reach their destination. Fixes: 9df552ef3e21 ("mlxsw: spectrum: Improve IPv6 unregistered multicast flooding") Signed-off-by: Ido Schimmel Reported-by: David Ahern Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c @@ -112,11 +112,11 @@ static const int mlxsw_sp_sfgc_bc_packet [MLXSW_REG_SFGC_TYPE_UNREGISTERED_MULTICAST_NON_IP] = 1, [MLXSW_REG_SFGC_TYPE_IPV4_LINK_LOCAL] = 1, [MLXSW_REG_SFGC_TYPE_IPV6_ALL_HOST] = 1, + [MLXSW_REG_SFGC_TYPE_UNREGISTERED_MULTICAST_IPV6] = 1, }; static const int mlxsw_sp_sfgc_mc_packet_types[MLXSW_REG_SFGC_TYPE_MAX] = { [MLXSW_REG_SFGC_TYPE_UNREGISTERED_MULTICAST_IPV4] = 1, - [MLXSW_REG_SFGC_TYPE_UNREGISTERED_MULTICAST_IPV6] = 1, }; static const int *mlxsw_sp_packet_type_sfgc_types[] = {