Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2353230imm; Mon, 28 May 2018 06:35:12 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq3GsehhzEG59q594SDYm6ZkOJ7Q9J2t/whFdrNtA7VTO1puPM9+inJcwR1HZgeM8SpRlbt X-Received: by 2002:a63:a807:: with SMTP id o7-v6mr10447839pgf.83.1527514512879; Mon, 28 May 2018 06:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527514512; cv=none; d=google.com; s=arc-20160816; b=tz7ddKHsjmlwy2B1b8/Hnl7i0O237h2Hlt9ZyZ4ZHiVpEnLh/2Z6UreVQx1rc4YsSS a6YpnkTfIx8mWgO5k1lQ/gSDYSe9k6izkb2gEH2xQGYnjyn6T1fUB4suv+K1erxOsi7k J+6WC3hKjT8mwH8dFEXLFpfFZKT1nR8bnaXrxuZuaZ8doXMplkU7cNWyo9IR9EGAIq0M wCxM7K1wtNaT6SiILOAkkh5+DPZVrEfIMoKh1zxgNMN0WwPhZrI8LoV4n1Qn9aBBLfsn OT6eeHTLwIytdevoNiCehCl14hVOwxLfFDTw5Rjdntj/GuIXajwE3f69G+Yec/yZp5LT 99Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=QXx4bFauFrHrGCrUsEqGODz5gIVNWdwtbsORSr5/ntw=; b=twfnCyiE6uf9b15qyU+iTwcLrxRIKDx02V3mKGRGaOBMLy6WMQGueulPGR4Z5IJLSP VvNabN8FwD6KdmzR4+Jv2Atuna6yxxcV/iLkzXcDKYRBIo2OkJ7ejogw0DrTTO+eMzr3 1nR4Idb4gR57/H1IE1toH8matCF5J8tWhcfxIlVzvxofI92wKLx9rsIX+Nb3nISZRSe9 HAaoCNuT1HokCDHK2AXDtpJKCK4UCsaaRJcIKCGLYa4n2wmezmML8MDUYWrSdSWhRq6y Rr+pT8eoF4d4gerP67QX3lrNhqwagAYLmvUEH4LOg7d8HR+gPIj2/Ni7NByWXXlaD/8E GBdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I2ydOuz+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z18-v6si1157995pgu.692.2018.05.28.06.34.57; Mon, 28 May 2018 06:35:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I2ydOuz+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937778AbeE1Kp6 (ORCPT + 99 others); Mon, 28 May 2018 06:45:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:36266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162593AbeE1Kpx (ORCPT ); Mon, 28 May 2018 06:45:53 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 100E1204EE; Mon, 28 May 2018 10:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527504352; bh=ZeDjVDoypbvu+CdlsJxA++eIMPYVHXNXD/boAnQhEeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I2ydOuz+bsh6ZBiyTb22Fy+bCJjRLglkZ6Q45gahx6URpfs4z6cfcY+AZm1EX8cXF YRRvXVJ8+G2TPj/lehpGpL9jLTu4cFRHq/TUnq6sDDfUiLjFQEDl30H7WFKgQjNU2N 2EeBieHs7QErgPV3ZbDoeSSfaoUvdARzzbTJbOMA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Boris Pismenny , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 075/496] tls: retrun the correct IV in getsockopt Date: Mon, 28 May 2018 11:57:40 +0200 Message-Id: <20180528100322.933116268@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100319.498712256@linuxfoundation.org> References: <20180528100319.498712256@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Boris Pismenny [ Upstream commit a1dfa6812b682eef750412dd5a90e7d38d7af068 ] Current code returns four bytes of salt followed by four bytes of IV. This patch returns all eight bytes of IV. fixes: 3c4d7559159b ("tls: kernel TLS support") Signed-off-by: Boris Pismenny Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- net/tls/tls_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/tls/tls_main.c +++ b/net/tls/tls_main.c @@ -299,7 +299,8 @@ static int do_tls_getsockopt_tx(struct s goto out; } lock_sock(sk); - memcpy(crypto_info_aes_gcm_128->iv, ctx->iv, + memcpy(crypto_info_aes_gcm_128->iv, + ctx->iv + TLS_CIPHER_AES_GCM_128_SALT_SIZE, TLS_CIPHER_AES_GCM_128_IV_SIZE); release_sock(sk); if (copy_to_user(optval,