Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2355635imm; Mon, 28 May 2018 06:37:41 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqnjAXiDkrI8N38/dPRS39TvRmzgRE/aHJqsK/QEFtJdOCV+3g2y+gDYE9IL+yVSeU2TM8I X-Received: by 2002:a17:902:9a06:: with SMTP id v6-v6mr13642379plp.21.1527514661672; Mon, 28 May 2018 06:37:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527514661; cv=none; d=google.com; s=arc-20160816; b=BhtwQUeRdxx1Bou7M11+r6NqsoVjEw/Qy6LxEx1pj8DRyTUeAHXlstwmMPkNcjqe43 1TOREVOWQy5pSGHLDoHKPL/BFu2YtmMdQhYt/PIqraUVC5vCPuUe87Vc2rrJsiGWcbYW h4yGZoUuUFpU8d041VcHLbMdok/L96hS3Mk+Qe8N6vZc6eEEgj4g43TicjeN3d1YhIq2 sX1FYHXYHJPwft1GN/IlXYwB14z1Ctz4jswr/xkdOWHX9k7JlWF0fdyiQ/UqZTiPLItb ptRVdXgX0YeZtS5U8DDvCg5GVlj9BgYMkZyClUh/HJkhTNaez3+eHt+2AElmoUgq0Bqh OzHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=yHUN4xbbXnpxa9vsWvjDz3vf7bwUs1BRgUSLtO16BWM=; b=oynJI3eWKK+qZUSHMs/LguxyzD+m0kc6LjcDWw5mXU/WNYjNEG3V9Mg37fgBokdVTV MoYdEjs9tayp0fIXpzLlg37Hj8HmDtPPZKSdx5mFwfXKAVKrppAbGnNltfsig7QlypM3 f3nQDbLaMpUodj4ki6KJDQ8XxmZC2hY+RCgdNxRtPlt1CpCFrSRp5FCNi56V60URBWv1 rzdti8g5swdubopJPbTdludsWV9WUo9/lX9dg3yknW1Yxk7yLWRKr7G15iV1p6Ee3WdC NYkatkevhPN/3htxBojw0uMVJuHYIUsWHfAXipeUUzjIHpwiTGWbpMvZF462crfX8n7b xmVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YN204mi8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p29-v6si8634910pgc.199.2018.05.28.06.37.25; Mon, 28 May 2018 06:37:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YN204mi8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165438AbeE1Ngw (ORCPT + 99 others); Mon, 28 May 2018 09:36:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:35930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937069AbeE1KpY (ORCPT ); Mon, 28 May 2018 06:45:24 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFB5D20660; Mon, 28 May 2018 10:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527504323; bh=pZ/evlWWQNthHv937dOrXigHBYUkb9iF7mAeVApTJBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YN204mi8LcORykQKhnG1IhBnRybSDEnRf2L1GGcywlBwGLxKiJkn6DoOI8/lm914P CPXFTrV4hPKHsYP3RA5XPeVV6wf1bYmi1VqAWt/P4hXZjH0sq6h4kitPd0+/z++LXV DeKU6vizqlvdvNW87a0lPAXSLUXHH9u97VqcloeA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ilan Peer , Luca Coelho , Johannes Berg , Sasha Levin Subject: [PATCH 4.14 096/496] mac80211: Fix sending ADDBA response for an ongoing session Date: Mon, 28 May 2018 11:58:01 +0200 Message-Id: <20180528100323.911299200@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528100319.498712256@linuxfoundation.org> References: <20180528100319.498712256@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilan Peer [ Upstream commit 3b07029729e347f288c70227cfe3c66b085d6b0b ] In case an ADDBA request is received while there is already an ongoing BA sessions with the same parameters, i.e., update flow, an ADBBA response with decline status was sent twice. Fix it. Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- net/mac80211/agg-rx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/net/mac80211/agg-rx.c +++ b/net/mac80211/agg-rx.c @@ -8,6 +8,7 @@ * Copyright 2007, Michael Wu * Copyright 2007-2010, Intel Corporation * Copyright(c) 2015-2017 Intel Deutschland GmbH + * Copyright (C) 2018 Intel Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -322,9 +323,6 @@ void ___ieee80211_start_rx_ba_session(st * driver so reject the timeout update. */ status = WLAN_STATUS_REQUEST_DECLINED; - ieee80211_send_addba_resp(sta->sdata, sta->sta.addr, - tid, dialog_token, status, - 1, buf_size, timeout); goto end; }